From: Joachim Nilsson <troglobit@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
roopa <roopa@cumulusnetworks.com>
Subject: Re: [RFC PATCH] net: bridge: multicast querier per VLAN support
Date: Wed, 18 Apr 2018 15:25:06 +0200 [thread overview]
Message-ID: <20180418132505.GA16964@troglobit> (raw)
In-Reply-To: <da36ee2f-d39b-d6c0-15b2-50bde81482ab@cumulusnetworks.com>
On Wed, Apr 18, 2018 at 04:14:26PM +0300, Nikolay Aleksandrov wrote:
> We want to avoid sysfs in general, all of networking config and stats
> are moving to netlink. It is better controlled and structured for such
> changes, also provides nice interfaces for automatic type checks etc.
Aha, didn't know that. Thanks! :)
> Also (but a minor reason) there is no tree/entity in sysfs for the vlans
> where to add this. It will either have to be a file which does some
> format string hack (like us currently) or will need to add new tree for
> them which I'd really like to avoid for the bridge.
Yup, I did some ugly sysfs patches to read queriers per VLAN like that, just
for some basic feedback. Really awful, although easy to debug because of it
being a simple file ... (I guess I'll have to make friends withe Netlink.)
> [..]
> Also after my vlan rhastable change, we have per-vlan context even today
> (e.g. per-vlan stats use it) so we'll just extend that.
Interesting, this I'll have to look at in more detail!
next prev parent reply other threads:[~2018-04-18 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 12:07 [RFC PATCH] net: bridge: multicast querier per VLAN support Joachim Nilsson
2018-04-18 12:31 ` Nikolay Aleksandrov
2018-04-18 13:07 ` Joachim Nilsson
2018-04-18 13:14 ` Nikolay Aleksandrov
2018-04-18 13:25 ` Joachim Nilsson [this message]
2018-04-18 15:54 ` Stephen Hemminger
2018-04-18 16:27 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418132505.GA16964@troglobit \
--to=troglobit@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.