From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 18 Apr 2018 14:29:37 +0000 Subject: [PATCH] drm: omapdrm: silence unititialized variable warning Message-Id: <20180418142937.GA13828@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Smatch complains that "area_free" could be used without being initialized. This code is several years old and premusably works fine so this can't be a very serious bug. But it's easy enough to silence the warning. If "area_free" is false at the end of the function then we return -ENOMEM. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c index d7f7bc9f061a..817be3c41863 100644 --- a/drivers/gpu/drm/omapdrm/tcm-sita.c +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c @@ -90,7 +90,7 @@ static int l2r_t2b(u16 w, u16 h, u16 a, s16 offset, { int i; unsigned long index; - bool area_free; + bool area_free = false; unsigned long slots_per_band = PAGE_SIZE / slot_bytes; unsigned long bit_offset = (offset > 0) ? offset / slot_bytes : 0; unsigned long curr_bit = bit_offset; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm: omapdrm: silence unititialized variable warning Date: Wed, 18 Apr 2018 17:29:37 +0300 Message-ID: <20180418142937.GA13828@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id 832226E266 for ; Wed, 18 Apr 2018 14:29:48 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org U21hdGNoIGNvbXBsYWlucyB0aGF0ICJhcmVhX2ZyZWUiIGNvdWxkIGJlIHVzZWQgd2l0aG91dCBi ZWluZwppbml0aWFsaXplZC4gIFRoaXMgY29kZSBpcyBzZXZlcmFsIHllYXJzIG9sZCBhbmQgcHJl bXVzYWJseSB3b3JrcyBmaW5lCnNvIHRoaXMgY2FuJ3QgYmUgYSB2ZXJ5IHNlcmlvdXMgYnVnLiAg QnV0IGl0J3MgZWFzeSBlbm91Z2ggdG8gc2lsZW5jZQp0aGUgd2FybmluZy4gIElmICJhcmVhX2Zy ZWUiIGlzIGZhbHNlIGF0IHRoZSBlbmQgb2YgdGhlIGZ1bmN0aW9uIHRoZW4Kd2UgcmV0dXJuIC1F Tk9NRU0uCgpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNs ZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vdGNtLXNpdGEuYyBi L2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL3RjbS1zaXRhLmMKaW5kZXggZDdmN2JjOWYwNjFhLi44 MTdiZTNjNDE4NjMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL3RjbS1zaXRh LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vdGNtLXNpdGEuYwpAQCAtOTAsNyArOTAs NyBAQCBzdGF0aWMgaW50IGwycl90MmIodTE2IHcsIHUxNiBoLCB1MTYgYSwgczE2IG9mZnNldCwK IHsKIAlpbnQgaTsKIAl1bnNpZ25lZCBsb25nIGluZGV4OwotCWJvb2wgYXJlYV9mcmVlOworCWJv b2wgYXJlYV9mcmVlID0gZmFsc2U7CiAJdW5zaWduZWQgbG9uZyBzbG90c19wZXJfYmFuZCA9IFBB R0VfU0laRSAvIHNsb3RfYnl0ZXM7CiAJdW5zaWduZWQgbG9uZyBiaXRfb2Zmc2V0ID0gKG9mZnNl dCA+IDApID8gb2Zmc2V0IC8gc2xvdF9ieXRlcyA6IDA7CiAJdW5zaWduZWQgbG9uZyBjdXJyX2Jp dCA9IGJpdF9vZmZzZXQ7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=