From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/3] lan78xx: Read LED states from Device Tree From: Andrew Lunn Message-Id: <20180418161121.GD3036@lunn.ch> Date: Wed, 18 Apr 2018 18:11:21 +0200 To: Phil Elwell Cc: Woojung Huh , Microchip Linux Driver Support , Rob Herring , Mark Rutland , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBBcHIgMTgsIDIwMTggYXQgMDQ6NDU6MjJQTSArMDEwMCwgUGhpbCBFbHdlbGwgd3Jv dGU6Cj4gQWRkIHN1cHBvcnQgZm9yIERUIHByb3BlcnR5ICJtaWNyb2NoaXAsbGVkLW1vZGVzIiwg YSB2ZWN0b3Igb2YgemVybwo+IHRvIGZvdXIgY2VsbHMgKHUzMnMpIGluIHRoZSByYW5nZSAwLTE1 LCBlYWNoIG9mIHdoaWNoIHNldHMgdGhlIG1vZGUKPiBmb3Igb25lIG9mIHRoZSBMRURzLiBTb21l IHBvc3NpYmxlIHZhbHVlcyBhcmU6Cj4gCj4gICAgIDA9bGluay9hY3Rpdml0eSAgICAgICAgICAx PWxpbmsxMDAwL2FjdGl2aXR5Cj4gICAgIDI9bGluazEwMC9hY3Rpdml0eSAgICAgICAzPWxpbmsx MC9hY3Rpdml0eQo+ICAgICA0PWxpbmsxMDAvMTAwMC9hY3Rpdml0eSAgNT1saW5rMTAvMTAwMC9h Y3Rpdml0eQo+ICAgICA2PWxpbmsxMC8xMDAvYWN0aXZpdHkgICAgMTQ9b2ZmICAgIDE1PW9uCj4g Cj4gVGhlc2UgdmFsdWVzIGFyZSBnaXZlbiBzeW1ib2xpYyBjb25zdGFudHMgaW4gYSBkdC1iaW5k aW5ncyBoZWFkZXIuCj4gCj4gQWxzbyB1c2UgdGhlIHByZXNlbmNlIG9mIHRoZSBEVCBwcm9wZXJ0 eSB0byBpbmRpY2F0ZSB0aGF0IHRoZQo+IExFRHMgc2hvdWxkIGJlIGVuYWJsZWQgLSBuZWNlc3Nh cnkgaW4gdGhlIGV2ZW50IHRoYXQgbm8gdmFsaWQgT1RQCj4gb3IgRUVQUk9NIGlzIGF2YWlsYWJs ZS4KCkhpIFBoaWwKCkFzIGkgc2FpZCBsYXN0IHdlZWssIHRoZXNlIGFyZSBQSFkgcHJvcGVydGll cywgc28gc2hvdWxkIGJlIGluIHRoZSBQSFkKbm9kZSBpbiBkZXZpY2UgdHJlZS4gSXQgc2hvdWxk IGJlIHRoZSBQSFkgZHJpdmVyIHdoaWNoIHBhcnNlcyB0aGVzZQpwcm9wZXJ0aWVzIGFuZCBjb25m aWd1cmVzIHRoZSBMRURzLCBub3QgdGhlIE1BQy4KCgkgICBBbmRyZXcKLS0tClRvIHVuc3Vic2Ny aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2Ii IGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1v cmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWlu Zm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2 2/3] lan78xx: Read LED states from Device Tree Date: Wed, 18 Apr 2018 18:11:21 +0200 Message-ID: <20180418161121.GD3036@lunn.ch> References: <1524066323-109628-1-git-send-email-phil@raspberrypi.org> <1524066323-109628-3-git-send-email-phil@raspberrypi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1524066323-109628-3-git-send-email-phil@raspberrypi.org> Sender: linux-kernel-owner@vger.kernel.org To: Phil Elwell Cc: Woojung Huh , Microchip Linux Driver Support , Rob Herring , Mark Rutland , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Apr 18, 2018 at 04:45:22PM +0100, Phil Elwell wrote: > Add support for DT property "microchip,led-modes", a vector of zero > to four cells (u32s) in the range 0-15, each of which sets the mode > for one of the LEDs. Some possible values are: > > 0=link/activity 1=link1000/activity > 2=link100/activity 3=link10/activity > 4=link100/1000/activity 5=link10/1000/activity > 6=link10/100/activity 14=off 15=on > > These values are given symbolic constants in a dt-bindings header. > > Also use the presence of the DT property to indicate that the > LEDs should be enabled - necessary in the event that no valid OTP > or EEPROM is available. Hi Phil As i said last week, these are PHY properties, so should be in the PHY node in device tree. It should be the PHY driver which parses these properties and configures the LEDs, not the MAC. Andrew