From: Bin Liu <b-liu@ti.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Arnd Bergmann <arnd@arndb.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support
Date: Wed, 18 Apr 2018 11:20:15 -0500 [thread overview]
Message-ID: <20180418162015.GG14921@uda0271908> (raw)
In-Reply-To: <20180413151505.32663-1-johan@kernel.org>
Johan,
On Fri, Apr 13, 2018 at 05:15:02PM +0200, Johan Hovold wrote:
> I've been carrying a patch out-of-tree since my work on improving the
> USB device-tree support which is needed to be able to describe USB
> topologies for musb based controllers.
>
> This patch, which associates the platform controller device with the
> glue device device-tree node, did not play well with the recent changes
> which added generic phy support to USB core however.
>
> Like the recent dwc2 regression fixed by Arnd after the device-tree
> #phy-cell changes, the generic phy code in USB core can now also fail
> indefinitly with -EPROBE_DEFER when the controller uses a legacy USB
> phy.
>
> The second patch addresses this for musb, which handles its own (legacy
> and generic) phys, but something more may possibly now be needed for
> other platforms with legacy phys.
>
> In the process of debugging this, I stumbled over another issue which
> caused the dsps legacy phy init two be called twice on every probe and
> which is fixed by the first patch.
>
> Johan
>
>
> Johan Hovold (3):
> USB: musb: dsps: drop duplicate phy initialisation
> USB: musb: host: prevent core phy initialisation
Are the two bugs only affecting you with your out-of-tree patch? It
seems don't have any functional impact for me. I need to make a decision
if these two patches need to go to the stable trees...
Regards,
-Bin.
next prev parent reply other threads:[~2018-04-18 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 15:15 [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support Johan Hovold
2018-04-18 16:20 ` Bin Liu [this message]
2018-04-18 18:46 ` Johan Hovold
2018-04-18 18:56 ` Bin Liu
2018-04-18 19:18 ` Martin Blumenstingl
2018-04-19 7:43 ` Johan Hovold
2018-04-19 21:54 ` Martin Blumenstingl
-- strict thread matches above, loose matches on Subject: below --
2018-04-13 15:15 [1/3] USB: musb: dsps: drop duplicate phy initialisation Johan Hovold
2018-04-13 15:15 ` [PATCH 1/3] " Johan Hovold
2018-04-13 15:15 [2/3] USB: musb: host: prevent core " Johan Hovold
2018-04-13 15:15 ` [PATCH 2/3] " Johan Hovold
2018-04-13 15:15 [3/3] USB: musb: dsps: propagate device-tree node Johan Hovold
2018-04-13 15:15 ` [PATCH 3/3] " Johan Hovold
2018-04-13 18:45 [1/3] USB: musb: dsps: drop duplicate phy initialisation Uwe Kleine-König
2018-04-13 18:45 ` [PATCH 1/3] " Uwe Kleine-König
2018-04-16 20:03 [3/3] USB: musb: dsps: propagate device-tree node Bin Liu
2018-04-16 20:03 ` [PATCH 3/3] " Bin Liu
2018-04-17 7:07 [3/3] " Johan Hovold
2018-04-17 7:07 ` [PATCH 3/3] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418162015.GG14921@uda0271908 \
--to=b-liu@ti.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.