From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f8oHX-0007yc-Nj for mharc-qemu-trivial@gnu.org; Wed, 18 Apr 2018 10:41:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8oHU-0007vz-Qw for qemu-trivial@nongnu.org; Wed, 18 Apr 2018 10:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8oHT-0003Hp-Lg for qemu-trivial@nongnu.org; Wed, 18 Apr 2018 10:41:56 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60588 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8oHO-0003EM-5Q; Wed, 18 Apr 2018 10:41:50 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE9164023112; Wed, 18 Apr 2018 14:41:49 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 816DA1134CCD; Wed, 18 Apr 2018 14:41:41 +0000 (UTC) Date: Wed, 18 Apr 2018 16:41:39 +0200 From: Cornelia Huck To: "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" Cc: Olaf Hering , Peter Maydell , Fam Zheng , qemu-trivial@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , "open list:All patches CC here" , Gerd Hoffmann , Paolo Bonzini Message-ID: <20180418164139.0206004d.cohuck@redhat.com> In-Reply-To: <20180418125545.GN27579@redhat.com> References: <20180418123838.3511-1-olaf@aepfle.de> <20180418144538.4aa2f492.cohuck@redhat.com> <20180418125545.GN27579@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 18 Apr 2018 14:41:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 18 Apr 2018 14:41:49 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] configure: require glib-2.24 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 14:41:58 -0000 On Wed, 18 Apr 2018 13:55:45 +0100 Daniel P. Berrang=C3=A9 wrote: > On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > > On Wed, 18 Apr 2018 14:38:37 +0200 > > Olaf Hering wrote: > > =20 > > > Since usage of g_realloc_n was introduced, glib-2.22 can not be used = anymore. > > > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > >=20 > > > Signed-off-by: Olaf Hering > > > --- > > > configure | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/configure b/configure > > > index 6e9b994f21..81760ef45a 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -3369,7 +3369,7 @@ fi > > > if test "$mingw32" =3D yes; then > > > glib_req_ver=3D2.30 > > > else > > > - glib_req_ver=3D2.22 > > > + glib_req_ver=3D2.24 > > > fi > > > glib_modules=3Dgthread-2.0 > > > if test "$modules" =3D yes; then > > > =20 > >=20 > > Are we ready to give up support for whatever distro is still on 2.22? > > (If yes, can we bump to an even newer glib version?) Or should we > > rather solve this by adding a g_realloc_n implementation for that case?= =20 >=20 > Version 2.22 was released in Sep 2009, so coming up for 9 years old now. >=20 > At some point we should to declare that platforms shipping >=3D NNN year > old versions of software are not a desirable target for QEMU. What is > our desired NNN value - 9 years feels awfully long to me. The curse of the enterprise distro, I suppose... (And they might have backported certain features without bumping the version number - I've run into that problem in the past.) >=20 > For libvirt we recently decided to become more aggressive[1] in culling o= ld > distros as supportable targets, declaring we'll only support non-EOL > distros (for short life distros), or for long life distros (RHEL, LTS, et= c) > the most recent version, and the recent minus-1 for 2 years overlap. That does not seem unreasonable. What about things like the MacOS stuff (like fink vs. homebrew, as Peter mentioned?) Other platforms? >=20 > Should we formalize similar guidelines for QEMU to give developers a > guide for when it is reasonable to increase the min required version of > any 3rd party library ? glib is a mandatory dep, but we've countless > other optional libraries we might wish to increase min versions for too, > and no guide on when it is reasonable todo so. If we decide on anything, we should definitely put it in writing :) We've had this discussion way too often in the past...