From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:60608 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbeDRSAD (ORCPT ); Wed, 18 Apr 2018 14:00:03 -0400 Date: Wed, 18 Apr 2018 10:59:06 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: Sergej Schumilo , linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org, jlayton@redhat.com, akpm@linux-foundation.org, Linus Torvalds , Cornelius Aschermann Subject: Re: Null-Pointer Deference in hfs.ko (Linux 4.15.0-15.16 Ubuntu) Message-ID: <20180418175906.GB5197@magnolia> References: <6A96C62E-1D01-44AD-B2C5-7A2258BADC0D@schumilo.de> <20180418173028.GA30953@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180418173028.GA30953@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Apr 18, 2018 at 10:30:28AM -0700, Matthew Wilcox wrote: > On Wed, Apr 18, 2018 at 06:26:41PM +0200, Sergej Schumilo wrote: > > Dear all, > > The following null pointer dereference bug was found by a modified version of the kAFL fuzzer (https://github.com/RUB-SysSec/kAFL). I have attached the causing hfs filesystem image, the dmesg report and the source code of a simple mounting tool to reproduce this issue. > > > > A local users who have been granted the privileges necessary to mount filesystems (or a system components which auto mounts filesystems) could trigger a null pointer dereference or a kernel panic (depending on panic_on_oops). > > I have to say this isn't going to rank very highly in terms of bugs we're > likely to spend a lot of time on. Almost nobody uses HFS on Linux, > and it has no maintainer. I'd suggest that Ubuntu disables it from > their configuration, or if it's important to them, that they contribute > somebody's time to working on it. > > You'd probably get a more interesting response if you fuzzed ext4, btrfs > or XFS. Or FAT or iso9660; things people are likely to have an USB keys. > There may be a tooling problem here where some filesystems should be > whitelisted for automounting. I just don't think you're going to find > anyone interested in fixing this. They already are fuzzing ext4 and xfs and generating a fair amount of list / bugzilla traffic. Regrettable that almost nobody sends us patches to fix the things they find, which at some point is just going to make the review backlog problems worse as peoples' attention get diverted to triaging the flood of reports. Sorry just being a grumpy maintainer. --D