From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Fix disk names when not using nvme multipath
Date: Thu, 19 Apr 2018 10:50:01 +0200 [thread overview]
Message-ID: <20180419085001.GA22593@lst.de> (raw)
In-Reply-To: <20180418160942.GN11513@localhost.localdomain>
On Wed, Apr 18, 2018@10:09:42AM -0600, Keith Busch wrote:
> On Wed, Apr 18, 2018@05:34:45PM +0200, Christoph Hellwig wrote:
> > True. We should do that anyway. I'll turn this into a real series
> > with a few more final touches tomorrow.
>
> I started this before I saw your message:
Even better :)
> static bool multipath = true;
> -module_param(multipath, bool, 0644);
> +module_param(multipath, bool, 0444);
> MODULE_PARM_DESC(multipath,
I think this part should be split into a separate patch as it's already
unsafe.
Otherwise this looks ok to me, but I wonder if the helper is really
worth the effort.
prev parent reply other threads:[~2018-04-19 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 22:03 [PATCH] nvme: Fix disk names when not using nvme multipath Keith Busch
2018-04-18 6:44 ` Christoph Hellwig
2018-04-18 13:26 ` Keith Busch
2018-04-18 15:04 ` Christoph Hellwig
2018-04-18 15:34 ` Keith Busch
2018-04-18 15:34 ` Christoph Hellwig
2018-04-18 16:09 ` Keith Busch
2018-04-19 8:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419085001.GA22593@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.