From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
rfried@codeaurora.org, bjorn.andersson@linaro.org,
Daniel Mack <daniel@zonque.org>
Subject: Re: wcn36xx: use READ_ONCE() to access desc->ctrl
Date: Thu, 19 Apr 2018 16:23:37 +0000 (UTC) [thread overview]
Message-ID: <20180419162338.01C7360C55@smtp.codeaurora.org> (raw)
In-Reply-To: <20180410173558.32425-1-daniel@zonque.org>
Daniel Mack <daniel@zonque.org> wrote:
> When accessing shared memory to check for the stat of submitted
> descriptors, make sure to use READ_ONCE(). This will guarantee the
> compiler treats these memory locations as volatile and doesn't apply
> any caching.
>
> While this doesn't fix any particular problem I ran into, it's best
> practice to do it this way.
>
> Note that this patch also removes the superflous extra condition check
> in the do-while loop in reap_tx_dxes(), as the loop will break
> instantly anyway in that case.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9ff6fde86fd2 wcn36xx: use READ_ONCE() to access desc->ctrl
--
https://patchwork.kernel.org/patch/10333551/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-04-19 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:35 [PATCH] wcn36xx: use READ_ONCE() to access desc->ctrl Daniel Mack
2018-04-10 18:17 ` Ramon Fried
2018-04-11 6:58 ` Daniel Mack
2018-04-12 1:49 ` Ramon Fried
2018-04-19 16:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419162338.01C7360C55@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@zonque.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.