From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 00/11] Modernize mdio-gpio
Date: Thu, 19 Apr 2018 22:20:57 +0200 [thread overview]
Message-ID: <20180419202057.GD4069@lunn.ch> (raw)
In-Reply-To: <CACRpkdaXuJHMBS5Vodrj4CzgB7MwiJp_gXJuQrjEOLF4ARPydQ@mail.gmail.com>
On Thu, Apr 19, 2018 at 09:52:09PM +0200, Linus Walleij wrote:
> On Thu, Apr 19, 2018 at 1:02 AM, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > This patchset is inspired by a previous version by Linus Walleij
> >
> > It reworks the mdio-gpio code to make use of gpio descriptors instead
> > of gpio numbers. However compared to the previous version, it retains
> > support for platform devices. It does however remove the platform_data
> > header file. The needed GPIOs are now passed by making use of a gpiod
> > lookup table. e.g:
>
> Looks good to me, but wasn't this what Florian was NACKing?
Hi Linus
At the time, i don't think either Florian or i knew about gpiod lookup
tables. It was only when i got deep into this patchset i found them.
> I thought he was going to add some x86 MDIO using platform data,
> and then I suppose he wanted to use something more than some
> GPIO descriptors, maybe IRQ etc (who knows)?
I now have said x86 MDIO device, connecting to an Ethernet switch. It
works :-)
Andrew
next prev parent reply other threads:[~2018-04-19 20:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 23:02 [PATCH net-next 00/11] Modernize mdio-gpio Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 01/11] net: phy_ mdio-gpio: Fixup , which should be ; Andrew Lunn
2018-04-19 20:00 ` David Miller
2018-04-18 23:02 ` [PATCH net-next 02/11] net: phy: mdio-gpio: Remove reset function Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 03/11] net: phy: mdio-bitbang: Remove reset support Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 04/11] net: phy: mdio-gpio: remove support for ignoring turn around Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 05/11] net: phy: mdio-gpio: remove support for phy mask Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 06/11] net: phy: mdio-gpio: Remove support for IRQs in platform data Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 07/11] net: phy: mdio-gpio: Swap to using gpio descriptors Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 08/11] net: phy: mdio-gpio: Move allocation for bitbanging data Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 09/11] net: phy: mdio-gpio: Parse properties directly into bitbang structure Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 10/11] net: phy: mdio-gpio: Add #defines for the GPIO index's Andrew Lunn
2018-04-18 23:02 ` [PATCH net-next 11/11] net: phy: mdio-gpio: Remove redundant platform data header Andrew Lunn
2018-04-19 19:52 ` [PATCH net-next 00/11] Modernize mdio-gpio Linus Walleij
2018-04-19 20:20 ` Andrew Lunn [this message]
2018-04-19 19:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419202057.GD4069@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.