From: Kalle Valo <kvalo@codeaurora.org>
To: Kenneth Lu <kuohsianglu@gmail.com>
Cc: kvalo@qca.qualcomm.com, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: ath10k: remove variables which set but not used
Date: Fri, 20 Apr 2018 10:01:18 +0000 (UTC) [thread overview]
Message-ID: <20180420100118.368D360FEF@smtp.codeaurora.org> (raw)
In-Reply-To: <20180318075014.GA26784@blackstone>
Kenneth Lu <kuohsianglu@gmail.com> wrote:
> Variable buf_len and num_vdev_stats are bging assigned but never read.
> These are redundant and can be remove.
>
> Signed-off-by: Kenneth Lu <kuohsianglu@gmail.com>
Fails to compile:
drivers/net/wireless/ath/ath10k/wmi.c: In function 'ath10k_wmi_10_4_op_pull_fw_stats':
drivers/net/wireless/ath/ath10k/wmi.c:3067:18: error: 'num_vdev_stats' undeclared (first use in this function); did you mean 'num_pdev_stats'?
for (i = 0; i < num_vdev_stats; i++) {
^~~~~~~~~~~~~~
num_pdev_stats
drivers/net/wireless/ath/ath10k/wmi.c:3067:18: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [drivers/net/wireless/ath/ath10k/wmi.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath10k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10291063/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-04-20 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 7:50 [PATCH] ath10k: remove variables which set but not used Kenneth Lu
2018-03-18 7:50 ` Kenneth Lu
2018-04-20 10:01 ` Kalle Valo [this message]
2018-04-20 10:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420100118.368D360FEF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kuohsianglu@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.