From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <bp@suse.de>
Received: from mx2.suse.de ([195.135.220.15])	by Galois.linutronix.de with
 esmtps (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256)	(Exim 4.80)	(envelope-from
 <bp@suse.de>)	id 1f9Zme-0001di-3r	for speck@linutronix.de; Fri, 20 Apr 2018
 19:25:18 +0200
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])
	by mx2.suse.de (Postfix) with ESMTP id 8AC92AD00
	for <speck@linutronix.de>; Fri, 20 Apr 2018 17:25:10 +0000 (UTC)
Date: Fri, 20 Apr 2018 19:25:05 +0200
From: Borislav Petkov <bp@suse.de>
Subject: [MODERATED] Re: [patch 06/11] [PATCH v2 06/10] Linux Patch #6
Message-ID: <20180420172505.GN13977@pd.tnic>
References: <20180420022613.203909041@localhost.localdomain>
MIME-Version: 1.0
In-Reply-To: <20180420022613.203909041@localhost.localdomain>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Thu, Apr 19, 2018 at 10:25:46PM -0400, speck for konrad.wilk_at_oracle.com=
 wrote:
> x86/ssb: Provide boot parameters to select which SSB/MD mitigation to use
>=20
> mdd stands for "Memory Disambiguation Disable". It is used to disable
> a common industry performance optimization known as "Speculative
> Store Bypass" in which loads from addresses to which a recent store
> has occurred may (speculatively) see an older value. Intel refers
> to this feature as "Memory Disambiguation", which is part of their
> "Smart Memory Access" capability in Haswell and later processors.

...

> +static enum ssb_mitigation_cmd __init ssb_parse_cmdline(void)
> +{
> +	char arg[20];
> +	int ret, i;
> +	enum ssb_mitigation_cmd cmd =3D SSB_CMD_AUTO;
> +
> +	/*
> +	 * On Intel it is exposed in CPUID as Memory Disambiguation Disable
> +	 * bit.
> +	 */
> +	if (!boot_cpu_has(X86_FEATURE_MDD))
> +                return SSB_CMD_NONE;

Some whitespace damage?

ERROR: code indent should use tabs where possible
#247: FILE: arch/x86/kernel/cpu/bugs.c:391:
+                return SSB_CMD_NONE;$

WARNING: please, no spaces at the start of a line
#247: FILE: arch/x86/kernel/cpu/bugs.c:391:
+                return SSB_CMD_NONE;$


--=20
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton, HR=
B 21284 (AG N=C3=BCrnberg)
--=20