From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake Date: Fri, 20 Apr 2018 11:03:32 -0700 Message-ID: <20180420180331.GE3304@intel.com> References: <20180411044213.383-1-ianwmorrison@gmail.com> <871sfmhz88.fsf@intel.com> <87lgdugc85.fsf@intel.com> <83F5C7385F545743AD4FB2A62F75B073338FD128@ORSMSX108.amr.corp.intel.com> <87r2nefbnn.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87r2nefbnn.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: "Srivatsa, Anusha" , "airlied@linux.ie" , Greg KH , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Ian W MORRISON , "Wajdeczko, Michal" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMTcsIDIwMTggYXQgMTI6MDI6NTJQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAxNiBBcHIgMjAxOCwgIlNyaXZhdHNhLCBBbnVzaGEiIDxhbnVzaGEuc3Jp dmF0c2FAaW50ZWwuY29tPiB3cm90ZToKPiA+Pi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4g Pj5Gcm9tOiBKYW5pIE5pa3VsYSBbbWFpbHRvOmphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbV0K PiA+PlNlbnQ6IFdlZG5lc2RheSwgQXByaWwgMTEsIDIwMTggNToyNyBBTQo+ID4+VG86IElhbiBX IE1PUlJJU09OIDxpYW53bW9ycmlzb25AZ21haWwuY29tPgo+ID4+Q2M6IFZpdmksIFJvZHJpZ28g PHJvZHJpZ28udml2aUBpbnRlbC5jb20+OyBTcml2YXRzYSwgQW51c2hhCj4gPj48YW51c2hhLnNy aXZhdHNhQGludGVsLmNvbT47IFdhamRlY3prbywgTWljaGFsCj4gPj48TWljaGFsLldhamRlY3pr b0BpbnRlbC5jb20+OyBHcmVnIEtIIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz47Cj4gPj5h aXJsaWVkQGxpbnV4LmllOyBqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tOyBsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnOwo+ID4+c3RhYmxlQHZnZXIua2VybmVsLm9yZzsgaW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgZHJpLQo+ID4+ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gPj5TdWJqZWN0OiBSZTogW1JFU0VORCBQQVRDSCAxLzFdIGRybS9pOTE1L2dsazog QWRkIE1PRFVMRV9GSVJNV0FSRSBmb3IKPiA+PkdlbWluaWxha2UKPiA+Pgo+ID4+T24gV2VkLCAx MSBBcHIgMjAxOCwgSWFuIFcgTU9SUklTT04gPGlhbndtb3JyaXNvbkBnbWFpbC5jb20+IHdyb3Rl Ogo+ID4+PiA8c25pcD4KPiA+Pj4KPiA+Pj4+Cj4gPj4+PiBOQUsgb24gaW5kaXNjcmltaW5hdGUg Q2M6IHN0YWJsZS4gVGhlcmUgYXJlIHplcm8gZ3VhcmFudGVlcyB0aGF0Cj4gPj4+PiBvbGRlciBr ZXJuZWxzIHdpbGwgd29yayB3aXRoIHdoYXRldmVyIGZpcm13YXJlIHlvdSB0aHJvdyBhdCB0aGVt Lgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSSBpbmNsdWRlZCAnQ2M6IHN0YWJsZScgc28gdGhlIHBhdGNo IHdvdWxkIGdldCBhZGRlZCB0byB0aGUgdjQuMTYgYW5kCj4gPj4+IHY0LjE1IGtlcm5lbHMgd2hp Y2ggSSBoYXZlIHRlc3RlZCB3aXRoIHRoZSBwYXRjaC4gSSBmb3VuZCB0aGF0IGVhcmxpZXIKPiA+ Pj4ga2VybmVscyBkaWRuJ3Qgc3VwcG9ydCB0aGUgJ2xpbnV4LWZpcm13YXJlJyBwYWNrYWdlIHJl cXVpcmVkIHRvIGdldAo+ID4+PiB3aWZpIHdvcmtpbmcgb24gSW50ZWwncyBuZXcgR2VtaW5pIExh a2UgTlVDLgo+ID4+Cj4gPj5Zb3UgcmVhbGl6ZSB0aGF0IHRoaXMgcGF0Y2ggc2hvdWxkIGhhdmUg bm90aGluZyB0byBkbyB3aXRoIHdpZmk/Cj4gPj4KPiA+PlJvZHJpZ28sIEFudXNoYSwgaWYgeW91 IHRoaW5rIENjOiBzdGFibGUgaXMgYXBwcm9wcmlhdGUsIHBsZWFzZSBpbmRpY2F0ZSB0aGUgc3Bl Y2lmaWMKPiA+PnZlcnNpb25zIG9mIHN0YWJsZSBpdCBpcyBhcHByb3ByaWF0ZSBmb3IuCj4gPgo+ ID4gSGkgSmFuaSwKPiA+Cj4gPiBUaGUgc3RhYmxlIGtlcm5lbCB2ZXJzaW9uIGlzIDQuMTIgYW5k IGJleW9uZC4KPiA+IEl0IGlzIGFwcHJvcHJpYXRlIHRvIGFkZCB0aGUgQ0M6IHN0YWJsZSBpbiBt eSBvcGluaW9uCj4gCj4gV2hvIHRlc3RlZCB0aGUgZmlybXdhcmUgd2l0aCB2NC4xMiBhbmQgbGF0 ZXI/IFdlIG9ubHkgaGF2ZSB0aGUgQ0kKPiByZXN1bHRzIGFnYWluc3QgKmN1cnJlbnQqIGRybS10 aXAuIFdlIGRvbid0IGV2ZW4ga25vdyBhYm91dCB2NC4xNi4KPiAKCkkgdW5kZXJzdGFuZCB5b3Vy IGNvbmNlcm5zLCBidXQgdGhlIHByb2JsZW0gd2FzIHRoYXQgb3VyIG9sZCBwcm9jZXNzCndhcyBh IGJpdCAobG90PykgbWVzc2VkIGFuZCB0aGVyZSB3YXMgdGhlIHVucmVsaWFibGUgdGltZQp1bnRp bCB0aGUgZmlybXdhcmUgcmVhbGx5IGxhbmRzIG9uIGxpbnV4LWZpcm13YXJlLmdpdC4gU28gTU9E VUxFX0ZJUk1XQVJFCmNhbGwgd2FzIG9ubHkgYWRkZWQgYWZ0ZXIgZmlybXdhcmUgd2FzIHJlYWxs eSB0aGVyZSBvbiBmaXJtd2FyZSByZXBvc2l0b3J5CmJ1dCBpdCB3YXNuJ3QgYWJvdXQgdGhlIHRl c3RpbmcuCgpJbiBvdGhlciB3b3JkcywgdGhlIGJ1bXAgdmVyc2lvbiBwYXRjaCB3YXMgbWVyZ2Vk IGFmdGVyIHRlc3RlZCwgYnV0Ck1PRFVMRV9GSVJNV0FSRSB3YXMgbGVmdCBiZWhpbmQgYmVjYXVz ZSBmaXJtd2FyZSBibG9iIHRvb2sgYSB3aGlsZSB0byBnZXQKcHVsbGVkIGludG8gbGludXgtZmly bXdhcmUuZ2l0IGFuZCB3ZSBlbmQgdXAgZm9yZ2V0dGluZyB0byBhZGQgaXQgdGhlcmUuCgpJbiBt eSBvcGluaW9uIGl0IHNob3VsZCBiZSBzYWZlIHRvIGFkZCB0aGUgTU9EVUxFX0ZJUk1XQVJFIHRo ZXJlCmJhc2VkIG9uIHRoZSB0ZXN0cyBmcm9tIHdoZW4gdGhlIHZlcnNpb24gd2FzIGJ1bXBlZC4K Cj4gSSdtIG5vdCBnb2luZyB0byBhY2sgYW5kIHRha2UgcmVzcG9uc2liaWxpdHkgZm9yIHRoZSBz dGFibGUgYmFja3BvcnRzCj4gdW5sZXNzIHNvbWVvbmUgYWN0dWFsbHkgY29tZXMgZm9yd2FyZCB3 aXRoIGNyZWRpYmxlIFRlc3RlZC1ieXMuCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+Cj4gPiBB bnVzaGEKPiA+PkJSLAo+ID4+SmFuaS4KPiA+Pgo+ID4+Pgo+ID4+Pj4KPiA+Pj4+IFBTLiBIb3cg aXMgdGhpcyBhICJSRVNFTkQiPyBJIGhhdmVuJ3Qgc2VlbiB0aGlzIGJlZm9yZS4KPiA+Pj4+Cj4g Pj4+Cj4gPj4+IEl0IGlzIGEgJ1JFU0VORCcgZm9yIHRoYXQgdmVyeSByZWFzb24uIEkgaW5pdGlh bGx5IHNlbnQgdGhlIHBhdGNoIHRvCj4gPj4+IHRoZSBzYW1lIHBlb3BsZSBhcyBhIHNpbWlsYXIg cGF0Y2gKPiA+Pj4gKGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTAxNDM2Mzcv KSBob3dldmVyIGFmdGVyIHJlYWxpc2luZwo+ID4+PiB0aGlzIG9taXR0ZWQgcmVxdWlyZWQgYWRk cmVzc2VzIEkgYWRkZWQgdGhlbSBhbmQgcmVzZW50IHRoZSBwYXRjaC4KPiA+Pj4KPiA+Pj4gQmVz dCByZWdhcmRzLAo+ID4+PiBJYW4KPiA+Pgo+ID4+LS0KPiA+PkphbmkgTmlrdWxhLCBJbnRlbCBP cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2222762-1524247428-2-15909201974209662771 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1524247427; b=vxgf53XZ8AZCsrCnY2f3Ty+YZnmdal81Z4SiGF58vEVNKmj6wR AyDekWNaPNPk4qiFDfVpYJpcgGdwzn2/T9V1NVEd/diJ5DISYhFD5+oyZ4DGIzaE he7Og5/Z7HOJ6dzp81ATH/5iHwDgPJCzeNZqR5h715ubSw9BgE4eQ/WDitkhlu1C vG8Ctdoiy/+kLSRwrPaaE+lMzZZBWho1cvAbQ32J4pSd/kmWljDwsuI2DB2cwyH1 oFznIQjkR8TOn8qQLQ6QK3uk8BVLA0oBWbzlfv+yX1zGhMQjdeCWHIit9PIH81ii MtR8YPnEuNb7AhlwOWsRIOAJ+AuXO2EvCZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=fm2; t=1524247427; bh=ZnwcqJpoqMJQWx363E5PxRWHOmWVNc Iqc0Z7iLmaMvE=; b=HmEIOMmSTOZtMjU6G1XgVyFV84BVs9xjO+fyEHM5qe9hLO PdNUbG9HF6k0b8BGY18k9QbtEbrLYd+NlOIC0x33fBpeLD2tQVkCbDF/sQJAnmIm dacyitD8ep6YZQH8EBosS2Ty7sNZphUaF9YjSBwsNR44ZlVujq994xQMhLZ2BCG0 eO/4uGXxoE52J5b+cPZRoxv/tPGjlPvpdUMBoof7Dsbpt66NvaC7j9UsLkRus8ro wIC31qfpcoNUp79kuYaa9xVdfEdHrcD7OTr96lWDFNTqkRMSO0STNm475gHnRswE Vnr40i9JpJTOMAMmkQJSwTfjZCOGOWLRYwe3NT0g== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfDEmsUjScvXx0ZAVcHljGnPS3WFpvpHpN/PtWtubi/tQZR/cnkxbd7yp4+iQ/Kl9+/Y76HeS6REdO4/u0CU0aQkglHKTkX4P4Saxqozdpfa/pYJfTTBS lpmiB8YfiXUYTG/n7lxmJTK/Fqe45g2+jxtJus9lnkaSg+1usDtPDb7sRgPGMAyxFadlaR9L5UXTn0iEctP/QS8QhjaUtPsi3cTy37VzDddr9JPgaAa3Rjgg X-CM-Analysis: v=2.3 cv=NPP7BXyg c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=ag1SF4gXAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=823g-tNlgnTRFbieJmkA:9 a=CjuIK1q_8ugA:10 a=Yupwre4RP9_Eg_Bd0iYG:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753475AbeDTSDq (ORCPT ); Fri, 20 Apr 2018 14:03:46 -0400 Received: from mga03.intel.com ([134.134.136.65]:58650 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753499AbeDTSDp (ORCPT ); Fri, 20 Apr 2018 14:03:45 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,302,1520924400"; d="scan'208";a="49523907" Date: Fri, 20 Apr 2018 11:03:32 -0700 From: Rodrigo Vivi To: Jani Nikula Cc: "Srivatsa, Anusha" , Ian W MORRISON , "airlied@linux.ie" , Greg KH , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Wajdeczko, Michal" Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake Message-ID: <20180420180331.GE3304@intel.com> References: <20180411044213.383-1-ianwmorrison@gmail.com> <871sfmhz88.fsf@intel.com> <87lgdugc85.fsf@intel.com> <83F5C7385F545743AD4FB2A62F75B073338FD128@ORSMSX108.amr.corp.intel.com> <87r2nefbnn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r2nefbnn.fsf@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Apr 17, 2018 at 12:02:52PM +0300, Jani Nikula wrote: > On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote: > >>-----Original Message----- > >>From: Jani Nikula [mailto:jani.nikula@linux.intel.com] > >>Sent: Wednesday, April 11, 2018 5:27 AM > >>To: Ian W MORRISON > >>Cc: Vivi, Rodrigo ; Srivatsa, Anusha > >>; Wajdeczko, Michal > >>; Greg KH ; > >>airlied@linux.ie; joonas.lahtinen@linux.intel.com; linux-kernel@vger.kernel.org; > >>stable@vger.kernel.org; intel-gfx@lists.freedesktop.org; dri- > >>devel@lists.freedesktop.org > >>Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for > >>Geminilake > >> > >>On Wed, 11 Apr 2018, Ian W MORRISON wrote: > >>> > >>> > >>>> > >>>> NAK on indiscriminate Cc: stable. There are zero guarantees that > >>>> older kernels will work with whatever firmware you throw at them. > >>>> > >>> > >>> I included 'Cc: stable' so the patch would get added to the v4.16 and > >>> v4.15 kernels which I have tested with the patch. I found that earlier > >>> kernels didn't support the 'linux-firmware' package required to get > >>> wifi working on Intel's new Gemini Lake NUC. > >> > >>You realize that this patch should have nothing to do with wifi? > >> > >>Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific > >>versions of stable it is appropriate for. > > > > Hi Jani, > > > > The stable kernel version is 4.12 and beyond. > > It is appropriate to add the CC: stable in my opinion > > Who tested the firmware with v4.12 and later? We only have the CI > results against *current* drm-tip. We don't even know about v4.16. > I understand your concerns, but the problem was that our old process was a bit (lot?) messed and there was the unreliable time until the firmware really lands on linux-firmware.git. So MODULE_FIRMWARE call was only added after firmware was really there on firmware repository but it wasn't about the testing. In other words, the bump version patch was merged after tested, but MODULE_FIRMWARE was left behind because firmware blob took a while to get pulled into linux-firmware.git and we end up forgetting to add it there. In my opinion it should be safe to add the MODULE_FIRMWARE there based on the tests from when the version was bumped. > I'm not going to ack and take responsibility for the stable backports > unless someone actually comes forward with credible Tested-bys. > > BR, > Jani. > > > > > > Anusha > >>BR, > >>Jani. > >> > >>> > >>>> > >>>> PS. How is this a "RESEND"? I haven't seen this before. > >>>> > >>> > >>> It is a 'RESEND' for that very reason. I initially sent the patch to > >>> the same people as a similar patch > >>> (https://patchwork.kernel.org/patch/10143637/) however after realising > >>> this omitted required addresses I added them and resent the patch. > >>> > >>> Best regards, > >>> Ian > >> > >>-- > >>Jani Nikula, Intel Open Source Technology Center > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel