From: Darren Hart <dvhart@infradead.org>
To: Mario.Limonciello@dell.com
Cc: rdunlap@infradead.org, andy.shevchenko@gmail.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
Date: Fri, 20 Apr 2018 14:52:51 -0700 [thread overview]
Message-ID: <20180420215251.GF11546@fury> (raw)
In-Reply-To: <d7ec4d23554a4d92a2ed59354483900a@ausx13mpc120.AMER.DELL.COM>
On Fri, Apr 20, 2018 at 05:55:28PM +0000, Mario.Limonciello@dell.com wrote:
>
> > -----Original Message-----
> > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> > owner@vger.kernel.org] On Behalf Of Randy Dunlap
> > Sent: Friday, April 20, 2018 12:53 PM
> > To: Limonciello, Mario; dvhart@infradead.org; Andy Shevchenko
> > Cc: LKML; platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
> >
> > On 04/20/18 10:42, Mario Limonciello wrote:
> > > As reported by Randy Dunlap:
> > >>> WARNING: unmet direct dependencies detected for DELL_SMBIOS
> > >>> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> > >>> && (DCDBAS [=m] ||
> > >>> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
> > >>> Selected by [y]:
> > >>> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
> > >>> && DMI [=y]
> > >>> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
> > >>> ACPI_VIDEO [=n]=n)
> > >>> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y]
> > >>>
> > >
> > > Right now it's possible to set dell laptop to compile in but this
> > > causes dell-smbios to compile in which breaks if dcdbas is a module.
> > >
> > > Dell laptop shouldn't select dell-smbios anymore, but depend on it.
> > >
> > > Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on
> > DCDBAS)
> >
> > meta-comment: the SHA-1 ID should be the first 12 characters of the commit ID
> > according to Documentation/process/submitting-patches.rst.
>
> Thanks for letting me, I didn't realize that.
>
> Darren, let me know if you want me to resubmit with this adjustment or if you
> can adjust when you queue for testing.
Will fix locally.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-04-20 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 17:42 [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain Mario Limonciello
2018-04-20 17:53 ` Randy Dunlap
2018-04-20 17:55 ` Mario.Limonciello
2018-04-20 17:55 ` Mario.Limonciello
2018-04-20 21:52 ` Darren Hart [this message]
2018-04-20 21:52 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420215251.GF11546@fury \
--to=dvhart@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.