From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx49VMojklkqmW/PFqgH7RHhrmomHdO6lyU7e19xX8W0vAIpuUv3CQKMbwbuoJ12YepSBWtlb ARC-Seal: i=1; a=rsa-sha256; t=1524405988; cv=none; d=google.com; s=arc-20160816; b=xHja87v6PY/nyajQXHB1EOM+6GrjkP952V1trY4qxzooBtvVWHcK08RqFLHB0j4CUf 5jvQhaVJZ8i+Sw8Cihxwww+NRhqE4OQ5k6qtD76djlXEfyOdYQFyhI2Qo40t7yDLfliV JhHuQbUly4l7d5XFBHV+s6Ue4jmqqyqqiUZnOlEylJkEmYf4C+htlIdKNGfbyhnxtiW5 QoitiRgdHr5OTKauQdQOojRD+J8IPU6DBq2Y2F+3Ud6nr+oiNMDqMKLuHH2PargxqJHv 3wMkwweHzG/wuuswogk11ug5GjigJKV7svWUty9TYh3f0jZ68SNjJUNM9v0R5E3ttQRn oeNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=RmYeOGssPHvGnrmuAsTKeSrUP6Rf18UMezwVtHQhZz4=; b=pEyYbPt7c7rJrnWu2qIXtfUi35mY5dGd+D0V5VVwr5cw7iXPWQypi+8VzapkxJ+WNV vofrcoAVGAsib8LSJxQBCkm4pp/jDQJONpqjE24YphIQ2RPiZ2bOS7eD3vR4f+0iWmLO xnx9Eb27BDfFqAkDYX+5eFmp9yblUD1/wQZagpcLDBTxnp2z20Xk29KjM7WElOihwx7D RYNaOw3I8Hk8RgFT9oJVWmvdALj3t/htg5LnywTeIiL8SfPd0DzQblnyVtSv2D3zmn7P cH1a1JWSQYYAcUf82JtlVYRoTcUQ0J0huWco8kWrF7YuJLtAeNPyTHRDwRY4QhI2qXRe fyWA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tuba Yavuz , Felipe Balbi Subject: [PATCH 4.14 037/164] USB: gadget: f_midi: fixing a possible double-free in f_midi Date: Sun, 22 Apr 2018 15:51:44 +0200 Message-Id: <20180422135136.927335276@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135135.400265110@linuxfoundation.org> References: <20180422135135.400265110@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598454885662324670?= X-GMAIL-MSGID: =?utf-8?q?1598455533331182675?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yavuz, Tuba commit 7fafcfdf6377b18b2a726ea554d6e593ba44349f upstream. It looks like there is a possibility of a double-free vulnerability on an error path of the f_midi_set_alt function in the f_midi driver. If the path is feasible then free_ep_req gets called twice: req->complete = f_midi_complete; err = usb_ep_queue(midi->out_ep, req, GFP_ATOMIC); => ... usb_gadget_giveback_request => f_midi_complete (CALLBACK) (inside f_midi_complete, for various cases of status) free_ep_req(ep, req); // first kfree if (err) { ERROR(midi, "%s: couldn't enqueue request: %d\n", midi->out_ep->name, err); free_ep_req(midi->out_ep, req); // second kfree return err; } The double-free possibility was introduced with commit ad0d1a058eac ("usb: gadget: f_midi: fix leak on failed to enqueue out requests"). Found by MOXCAFE tool. Signed-off-by: Tuba Yavuz Fixes: ad0d1a058eac ("usb: gadget: f_midi: fix leak on failed to enqueue out requests") Acked-by: Felipe Balbi Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/f_midi.c | 3 ++- drivers/usb/gadget/u_f.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -405,7 +405,8 @@ static int f_midi_set_alt(struct usb_fun if (err) { ERROR(midi, "%s: couldn't enqueue request: %d\n", midi->out_ep->name, err); - free_ep_req(midi->out_ep, req); + if (req->buf != NULL) + free_ep_req(midi->out_ep, req); return err; } } --- a/drivers/usb/gadget/u_f.h +++ b/drivers/usb/gadget/u_f.h @@ -64,7 +64,9 @@ struct usb_request *alloc_ep_req(struct /* Frees a usb_request previously allocated by alloc_ep_req() */ static inline void free_ep_req(struct usb_ep *ep, struct usb_request *req) { + WARN_ON(req->buf == NULL); kfree(req->buf); + req->buf = NULL; usb_ep_free_request(ep, req); }