From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS Date: Mon, 23 Apr 2018 15:20:14 +0200 Message-ID: <20180423132014.GB24093@kroah.com> References: <20180422140508.GA21446@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E6AAD@SW-EX-MBX01.diasemi.com> <2E89032DDAA8B9408CB92943514A0337014C1E6B41@SW-EX-MBX01.diasemi.com> <20180423082528.GA20868@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E6D67@SW-EX-MBX01.diasemi.com> <20180423112818.GA22932@kroah.com> <2E89032DDAA8B9408CB92943514A0337014C1E6D83@SW-EX-MBX01.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1E6D83@SW-EX-MBX01.diasemi.com> Sender: linux-kernel-owner@vger.kernel.org To: Adam Thomson Cc: Heikki Krogerus , Guenter Roeck , Sebastian Reichel , Hans de Goede , Jun Li , "linux-usb@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-Id: linux-pm@vger.kernel.org On Mon, Apr 23, 2018 at 12:47:47PM +0000, Adam Thomson wrote: > On 23 April 2018 12:28, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote: > > > On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > > > > > > > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote: > > > > > On 22 April 2018 21:58, Adam Thomson wrote: > > > > > > > > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > > > > > > > > > > > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote: > > > > > > > > This commit adds code to handle requesting of PPS APDOs. Switching > > > > > > > > between standard PDOs and APDOs, and re-requesting an APDO to > > > > > > > > modify operating voltage/current will be triggered by an > > > > > > > > external call into TCPM. > > > > > > > > > > > > > > > > Signed-off-by: Adam Thomson > > > > > > > > > > Acked-by: Heikki Krogerus > > > > > > > > Reviewed-by: Guenter Roeck > > > > > > > > --- > > > > > > > > drivers/usb/typec/tcpm.c | 517 > > > > > > > ++++++++++++++++++++++++++++++++++++++++++++++- > > > > > > > > include/linux/usb/pd.h | 4 +- > > > > > > > > include/linux/usb/tcpm.h | 1 + > > > > > > > > 3 files changed, 509 insertions(+), 13 deletions(-) > > > > > > > > > > > > > > This patch adds build warnings to the tree, so I can't take it, sorry. > > > > > > > Please fix up and resend. > > > > > > > > > > > > No problem. Sorry for that. Will take a look and resolve the warnings. > > > > > > > > > > Sadly this is going to be a bit more than 'resolve the warnings' task now as Jun > > > > > Li's patch set has now made it in before me which means I need to rebase PDO > > > > > Selection because of his changes. :( > > > > > > > > Someone was going to have to do that, sorry :( > > > > > > Just as an FYI, this patch will produce warnings until the associated > > > power_supply interface patch (number 5 in the series previously sent) is > > > included as that makes use of the new API. Not sure how I can get around that > > > so I guess we have to wait on Sebastian to give the nod for the rest of the > > > power_supply patches before this can make it through. > > > > That's not good. There has to be a way to prevent a build warning from > > happening... > > If we're ok with '__maybe_unused' then I can add that. Wasn't sure if something > like that would be acceptable for this scenario. I don't remember what the warning was, or what the code was either, sorry... From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v7,1/6] typec: tcpm: Add core support for sink side PPS From: Greg Kroah-Hartman Message-Id: <20180423132014.GB24093@kroah.com> Date: Mon, 23 Apr 2018 15:20:14 +0200 To: Adam Thomson Cc: Heikki Krogerus , Guenter Roeck , Sebastian Reichel , Hans de Goede , Jun Li , "linux-usb@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Support Opensource List-ID: T24gTW9uLCBBcHIgMjMsIDIwMTggYXQgMTI6NDc6NDdQTSArMDAwMCwgQWRhbSBUaG9tc29uIHdy b3RlOgo+IE9uIDIzIEFwcmlsIDIwMTggMTI6MjgsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToK PiAKPiA+IE9uIE1vbiwgQXByIDIzLCAyMDE4IGF0IDExOjA2OjI1QU0gKzAwMDAsIEFkYW0gVGhv bXNvbiB3cm90ZToKPiA+ID4gT24gMjMgQXByaWwgMjAxOCAwOToyNSwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+ID4gPgo+ID4gPiA+IE9uIE1vbiwgQXByIDIzLCAyMDE4IGF0IDA3OjQ5OjM4 QU0gKzAwMDAsIEFkYW0gVGhvbXNvbiB3cm90ZToKPiA+ID4gPiA+IE9uIDIyIEFwcmlsIDIwMTgg MjE6NTgsIEFkYW0gVGhvbXNvbiB3cm90ZToKPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IE9uIDIyIEFw cmlsIDIwMTggMTU6MDUsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gPiBPbiBGcmksIE1hciAyMywgMjAxOCBhdCAxMDoxMjoyMEFNICswMDAwLCBBZGFt IFRob21zb24gd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiBUaGlzIGNvbW1pdCBhZGRzIGNvZGUgdG8g aGFuZGxlIHJlcXVlc3Rpbmcgb2YgUFBTIEFQRE9zLiBTd2l0Y2hpbmcKPiA+ID4gPiA+ID4gPiA+ IGJldHdlZW4gc3RhbmRhcmQgUERPcyBhbmQgQVBET3MsIGFuZCByZS1yZXF1ZXN0aW5nIGFuIEFQ RE8gdG8KPiA+ID4gPiA+ID4gPiA+IG1vZGlmeSBvcGVyYXRpbmcgdm9sdGFnZS9jdXJyZW50IHdp bGwgYmUgdHJpZ2dlcmVkIGJ5IGFuCj4gPiA+ID4gPiA+ID4gPiBleHRlcm5hbCBjYWxsIGludG8g VENQTS4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBZGFt IFRob21zb24KPiA+IDxBZGFtLlRob21zb24uT3BlbnNvdXJjZUBkaWFzZW1pLmNvbT4KPiA+ID4g PiA+ID4gPiA+IEFja2VkLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51 eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gPiBSZXZpZXdlZC1ieTogR3VlbnRlciBSb2VjayA8 bGludXhAcm9lY2stdXMubmV0Pgo+ID4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gPiAg ZHJpdmVycy91c2IvdHlwZWMvdGNwbS5jIHwgNTE3Cj4gPiA+ID4gPiA+ID4gKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ID4gPiA+ID4gPiA+ICBpbmNs dWRlL2xpbnV4L3VzYi9wZC5oICAgfCAgIDQgKy0KPiA+ID4gPiA+ID4gPiA+ICBpbmNsdWRlL2xp bnV4L3VzYi90Y3BtLmggfCAgIDEgKwo+ID4gPiA+ID4gPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwg NTA5IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gVGhpcyBwYXRjaCBhZGRzIGJ1aWxkIHdhcm5pbmdzIHRvIHRoZSB0cmVlLCBzbyBJIGNh bid0IHRha2UgaXQsIHNvcnJ5Lgo+ID4gPiA+ID4gPiA+IFBsZWFzZSBmaXggdXAgYW5kIHJlc2Vu ZC4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gTm8gcHJvYmxlbS4gU29ycnkgZm9yIHRoYXQuIFdp bGwgdGFrZSBhIGxvb2sgYW5kIHJlc29sdmUgdGhlIHdhcm5pbmdzLgo+ID4gPiA+ID4KPiA+ID4g PiA+IFNhZGx5IHRoaXMgaXMgZ29pbmcgdG8gYmUgYSBiaXQgbW9yZSB0aGFuICdyZXNvbHZlIHRo ZSB3YXJuaW5ncycgdGFzayBub3cgYXMgSnVuCj4gPiA+ID4gPiBMaSdzIHBhdGNoIHNldCBoYXMg bm93IG1hZGUgaXQgaW4gYmVmb3JlIG1lIHdoaWNoIG1lYW5zIEkgbmVlZCB0byByZWJhc2UgUERP Cj4gPiA+ID4gPiBTZWxlY3Rpb24gYmVjYXVzZSBvZiBoaXMgY2hhbmdlcy4gOigKPiA+ID4gPgo+ ID4gPiA+IFNvbWVvbmUgd2FzIGdvaW5nIHRvIGhhdmUgdG8gZG8gdGhhdCwgc29ycnkgOigKPiA+ ID4KPiA+ID4gSnVzdCBhcyBhbiBGWUksIHRoaXMgcGF0Y2ggd2lsbCBwcm9kdWNlIHdhcm5pbmdz IHVudGlsIHRoZSBhc3NvY2lhdGVkCj4gPiA+IHBvd2VyX3N1cHBseSBpbnRlcmZhY2UgcGF0Y2gg KG51bWJlciA1IGluIHRoZSBzZXJpZXMgcHJldmlvdXNseSBzZW50KSBpcwo+ID4gPiBpbmNsdWRl ZCBhcyB0aGF0IG1ha2VzIHVzZSBvZiB0aGUgbmV3IEFQSS4gTm90IHN1cmUgaG93IEkgY2FuIGdl dCBhcm91bmQgdGhhdAo+ID4gPiBzbyBJIGd1ZXNzIHdlIGhhdmUgdG8gd2FpdCBvbiBTZWJhc3Rp YW4gdG8gZ2l2ZSB0aGUgbm9kIGZvciB0aGUgcmVzdCBvZiB0aGUKPiA+ID4gcG93ZXJfc3VwcGx5 IHBhdGNoZXMgYmVmb3JlIHRoaXMgY2FuIG1ha2UgaXQgdGhyb3VnaC4KPiA+IAo+ID4gVGhhdCdz IG5vdCBnb29kLiAgVGhlcmUgaGFzIHRvIGJlIGEgd2F5IHRvIHByZXZlbnQgYSBidWlsZCB3YXJu aW5nIGZyb20KPiA+IGhhcHBlbmluZy4uLgo+IAo+IElmIHdlJ3JlIG9rIHdpdGggJ19fbWF5YmVf dW51c2VkJyB0aGVuIEkgY2FuIGFkZCB0aGF0LiBXYXNuJ3Qgc3VyZSBpZiBzb21ldGhpbmcKPiBs aWtlIHRoYXQgd291bGQgYmUgYWNjZXB0YWJsZSBmb3IgdGhpcyBzY2VuYXJpby4KCkkgZG9uJ3Qg cmVtZW1iZXIgd2hhdCB0aGUgd2FybmluZyB3YXMsIG9yIHdoYXQgdGhlIGNvZGUgd2FzIGVpdGhl ciwKc29ycnkuLi4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBs aW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBt YWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92 Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=