From: Greg KH <gregkh@linuxfoundation.org>
To: Jefferson Capovilla <jefcap@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings()
Date: Mon, 23 Apr 2018 15:25:32 +0200 [thread overview]
Message-ID: <20180423132532.GA16104@kroah.com> (raw)
In-Reply-To: <20180404013050.GA31356@jefcap-VirtualBox>
On Tue, Apr 03, 2018 at 10:30:50PM -0300, Jefferson Capovilla wrote:
> Fix 'line over 80 characters' issue found by checkpatch.pl script in
> mtk_set_link_ksettings().
>
> Signed-off-by: Jefferson Capovilla <jefcap@gmail.com>
> ---
> drivers/staging/mt7621-eth/ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
> index 38ba0c0..e9f4092 100644
> --- a/drivers/staging/mt7621-eth/ethtool.c
> +++ b/drivers/staging/mt7621-eth/ethtool.c
> @@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
> mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
> mac->phy_flags = MTK_PHY_FLAG_PORT;
> } else if (mac->hw->mii_bus) {
> - mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
> + mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
> + cmd->base.phy_address);
> if (!mac->phy_dev)
> return -ENODEV;
> mac->phy_flags = MTK_PHY_FLAG_ATTACH;
> @@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
> }
>
> return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
> -
You did this too :(
Don't lie in a changelog text, please fix up and resend.
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-04-23 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 1:30 [PATCH] staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings() Jefferson Capovilla
2018-04-23 13:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423132532.GA16104@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jefcap@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.