From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [RFC v2 4/9] libxl_qmp: Move the buffer realloc to
 the same scope level as read
Date: Mon, 23 Apr 2018 15:50:27 +0100
Message-ID: <20180423145027.GB1980@perard>
References: <20180416173227.22671-1-anthony.perard@citrix.com>
 <20180416173227.22671-5-anthony.perard@citrix.com>
 <20180423090339.g7ikb3h2ss25afmj@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Received: from all-amaz-eas1.inumbo.com ([34.197.232.57])
 by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from
 <srs0=l+ue=hm=citrix.com=prvs=644fc49e2=anthony.perard@srs-us1.protection.inumbo.net>)
 id 1fAcnY-0007XD-F6
 for xen-devel@lists.xenproject.org; Mon, 23 Apr 2018 14:50:32 +0000
Content-Disposition: inline
In-Reply-To: <20180423090339.g7ikb3h2ss25afmj@citrix.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gTW9uLCBBcHIgMjMsIDIwMTggYXQgMTA6MDM6MzlBTSArMDEwMCwgV2VpIExpdSB3cm90ZToK
PiBPbiBNb24sIEFwciAxNiwgMjAxOCBhdCAwNjozMjoyMlBNICswMTAwLCBBbnRob255IFBFUkFS
RCB3cm90ZToKPiA+IEluIHFtcF9uZXh0KCksIHRoZSBpbm5lciBsb29wIHNob3VsZCBvbmx5IHRy
eSB0byBwYXJzZSBtZXNzYWdlcyBmcm9tCj4gPiBRTVAsIGlmIHRoZXJlIGlzIG1vcmUgdGhhbiBv
bmUuCj4gPiAKPiA+IFRoZSBoYW5kbGluZyBvZiB0aGUgcmVjZWl2ZSBidWZmZXIgKCdpbmNvbXBs
ZXRlJyksIHNob3VsZCBiZSBkb25lIGF0IHRoZQo+ID4gc2FtZSBzY29wZSBsZXZlbCBhcyByZWFk
KCkuIEl0IGRvZXNuJ3QgbmVlZCB0byBiZSBoYW5kbGUgbW9yZSB0aGF0IG9uY2UKPiA+IGFmdGVy
IGEgcmVhZC4KPiA+IAo+IAo+IEluIGdlbmVyYWwgSSBhZ3JlZSB0aGlzIGlzIGEgYmV0dGVyIGlk
ZWEgdGhhbiB0aGUgY3VycmVudCBjb2RlLgo+IAo+ID4gQmVmb3JlIHRoaXMgcGF0Y2gsIHdoZW4g
b24gbWVzc2FnZSB3aGF0IGhhbmRsZWQsIHRoZSBpbm5lciBsb29wIHdvdWxkCj4gCj4gU29ycnks
IEkgZmFpbGVkIHRvIHBhcnNlICJ3aGVuIG9uIG1lc3NhZ2Ugd2hhdCBoYW5kbGVkIi4KCkkgcHJv
YmFibHkgd2FudGVkIHRvIHdyaXRlOiAid2hlbiBvbmUgbWVzc2FnZSB3YXMgaGFuZGxlZCIuIElz
IHRoaXMKYmV0dGVyPwoKPiA+IHJlc3RhcnQgYnkgYWRkaW5nIHRoZSAnYnVmZmVyJyBpbnRvICdp
bmNvbXBsZXRlJyAoYWZ0ZXIgcmVhbGxvY2F0aW9uKS4KPiA+IFNpbmNlICdyZCcgd2FzIG5vdCBy
ZXNldCwgdGhlIGJ1ZmZlciB3b3VsZCBiZSBzdHJjYXQgYSBzZWNvbmQgdGltZS4KPiA+IEFmdGVy
IHRoYXQsIHRoZSBzdHJlYW0gZnJvbSB0aGUgUU1QIHNlcnZlciB3b3VsZCBoYXZlIHN5bnRheCBl
cnJvciwgYW5kCj4gPiB0aGUgcGFyc29yIHdvdWxkIHRocm93IGVycm9ycy4KPiA+IAo+ID4gVGhp
cyBpcyB1bmxpa2VseSB0byBoYXBwZW4gYXMgdGhlIHJlY2VpdmUgYnVmZmVyIGlzIHZlcnkgbGFy
Z2UuIEFuZAo+ID4gcmVjZWl2aW5nIHR3byBtZXNzYWdlcyBpbiBhIHJvdyBpcyB1bmxpa2VseS4g
SW4gdGhlIGN1cnJlbnQgY2FzZSwgdGhpcwo+ID4gY291bGQgYmUgYW4gZXZlbnQgYW5kIGEgcmVz
cG9uc2UgdG8gYSBjb21tYW5kLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFS
RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiA+IC0tLQo+ID4gIHRvb2xzL2xpYnhsL2xp
YnhsX3FtcC5jIHwgMzEgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmls
ZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm
ZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jIGIvdG9vbHMvbGlieGwvbGlieGxfcW1w
LmMKPiA+IGluZGV4IDRkMjA3YzM4NDIuLmEyNWY0NDVmYjYgMTAwNjQ0Cj4gPiAtLS0gYS90b29s
cy9saWJ4bC9saWJ4bF9xbXAuYwo+ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfcW1wLmMKPiA+
IEBAIC01MjQsMjMgKzUyNCwyNCBAQCBzdGF0aWMgaW50IHFtcF9uZXh0KGxpYnhsX19nYyAqZ2Ms
IGxpYnhsX19xbXBfaGFuZGxlciAqcW1wKQo+ID4gIAo+ID4gICAgICAgICAgREVCVUdfUkVQT1JU
X1JFQ0VJVkVEKHFtcC0+ZG9taWQsIHFtcC0+YnVmZmVyLCAoaW50KXJkKTsKPiA+ICAKPiA+ICsg
ICAgICAgIGlmIChpbmNvbXBsZXRlKSB7Cj4gPiArICAgICAgICAgICAgc2l6ZV90IGN1cnJlbnRf
cG9zID0gcyAtIGluY29tcGxldGU7Cj4gPiArICAgICAgICAgICAgaW5jb21wbGV0ZSA9IGxpYnhs
X19yZWFsbG9jKGdjLCBpbmNvbXBsZXRlLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBpbmNvbXBsZXRlX3NpemUgKyByZCArIDEpOwo+ID4gKyAgICAgICAgICAg
IHN0cm5jYXQoaW5jb21wbGV0ZSArIGluY29tcGxldGVfc2l6ZSwgcW1wLT5idWZmZXIsIHJkKTsK
PiA+ICsgICAgICAgICAgICBzID0gaW5jb21wbGV0ZSArIGN1cnJlbnRfcG9zOwo+IAo+IFRoaXMg
Y2FuIGJlIGRyb3BwZWQsIGJlY2F1c2UgcyBpcyBub3QgY2hhbmdlZC4gSXQgaXMganVzdCB0aGUg
cmV2ZXJzYWwKPiBvZiB3aGF0IGlzIGEgZmV3IGxpbmVzIGFib3ZlLgoKTm8sIHJlYWxsb2MgbWF5
IGNoYW5nZSB0aGUgbG9jYXRpb24gb2YgdGhlIGFsbG9jYXRlZCBtZW1vcnkuIFNvLCBiZXR3ZWVu
CiJjdXJyZW50X3BvcyA9IHMgLSBpbmNvbXBsZXRlIiBhbmQgInMgPSBpbmNvbXBsZXRlICsgY3Vy
cmVudF9wb3MiLCB0aGUKdmFsdWUgb2YgJ2luY29tcGxldGUnIG1heSBoYXZlIGNoYW5nZWQuCgo+
ID4gKyAgICAgICAgICAgIGluY29tcGxldGVfc2l6ZSArPSByZDsKPiA+ICsgICAgICAgICAgICBz
X2VuZCA9IGluY29tcGxldGUgKyBpbmNvbXBsZXRlX3NpemU7Cj4gPiArICAgICAgICB9IGVsc2Ug
ewo+ID4gKyAgICAgICAgICAgIGluY29tcGxldGUgPSBsaWJ4bF9fc3RybmR1cChnYywgcW1wLT5i
dWZmZXIsIHJkKTsKPiA+ICsgICAgICAgICAgICBpbmNvbXBsZXRlX3NpemUgPSByZDsKPiA+ICsg
ICAgICAgICAgICBzID0gaW5jb21wbGV0ZTsKPiA+ICsgICAgICAgICAgICBzX2VuZCA9IHMgKyBy
ZDsKPiA+ICsgICAgICAgICAgICByZCA9IDA7Cj4gCj4gVGhpcyBjYW4gYmUgZHJvcHBlZC4KPiAK
PiBBbmQgSSB0aGluayB3ZSBzaG91bGQgdGFrZSB0aGlzIGNoYW5nZSB0byBjaGFuZ2UgImluY29t
cGxldGUiIHRvCj4gc29tZXRoaW5nIG1vcmUgbWVhbmluZ2Z1bCwgbGlrZSAicW1wX21zZ19idWYi
LgoKSSB0aGluayB0aGF0IGNhbiBiZSBkb25lLgoKCi0tIApBbnRob255IFBFUkFSRAoKX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp
bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w
cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==