From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 03/16] xen: link against xentoolcore Date: Mon, 23 Apr 2018 16:05:53 +0100 Message-ID: <20180423150553.GC1980@perard> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fAd2U-0000cA-3c for xen-devel@lists.xenproject.org; Mon, 23 Apr 2018 15:05:58 +0000 Content-Disposition: inline In-Reply-To: <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Ian Jackson Cc: Juergen Gross , Ross Lagerwall , Stefano Stabellini , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMDU6NDU6MDZQTSArMDEwMCwgSWFuIEphY2tzb24gd3Jv dGU6Cj4gRnJvbTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Cj4g Cj4gWGVuIGxpYnJhcmllcyBpbiA0LjEwIGluY2x1ZGUgYSBuZXcgeGVudG9vbGNvcmUgbGlicmFy eS4gIFRoaXMKPiBjb250YWlucyB0aGUgeGVudG9vbGNvcmVfcmVzdHJpY3RfYWxsIGZ1bmN0aW9u IHdoaWNoIHdlIGFyZSBhYm91dCB0bwo+IHdhbnQgdG8gdXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IElhbiBKYWNrc29uIDxJYW4uSmFja3NvbkBldS5jaXRyaXguY29tPgo+IEFja2VkLWJ5OiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gLS0tCj4gdjU6IE1vcmUg dHJ1dGhmdWwgY29tbWl0IG1lc3NhZ2UuCj4gLS0tCj4gIGNvbmZpZ3VyZSB8IDggKysrKystLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvY29uZmlndXJlIGIvY29uZmlndXJlCj4gaW5kZXggMGExOWIwMy4uZjU4MDI1 NSAxMDA3NTUKPiAtLS0gYS9jb25maWd1cmUKPiArKysgYi9jb25maWd1cmUKPiBAQCAtMjE4OCw3 ICsyMTg4LDcgQEAgaWYgdGVzdCAiJHhlbiIgIT0gIm5vIiA7IHRoZW4KPiAgICAgICAgJCgkcGtn X2NvbmZpZyAtLW1vZHZlcnNpb24geGVuY29udHJvbCB8IHNlZCAncy9cLi8gL2cnKSApIgo+ICAg ICAgeGVuPXllcwo+ICAgICAgeGVuX3BjPSJ4ZW5jb250cm9sIHhlbnN0b3JlIHhlbmd1ZXN0IHhl bmZvcmVpZ25tZW1vcnkgeGVuZ250dGFiIgo+IC0gICAgeGVuX3BjPSIkeGVuX3BjIHhlbmV2dGNo biB4ZW5kZXZpY2Vtb2RlbCIKPiArICAgIHhlbl9wYz0iJHhlbl9wYyB4ZW5ldnRjaG4geGVuZGV2 aWNlbW9kZWwgeGVudG9vbGNvcmUiCgpJIHRoaW5rIHdlIHdhbnQgdG8gY2hlY2sgaWYgInhlbnRv b2xjb3JlIiBwa2dfY29uZmlnIGV4aXN0IGJlZm9yZSB0cnlpbmcKdG8gdXNlIGl0LiBPdGhlcndp dGgsIHRoYXQgaXMgbm90IGdvaW5nIHRvIHdvcmsgd2l0aCBYZW4gb2xkZXIgdGhhbgo0LjEwLgoK YHBrZy1jb25maWcgLS1saWJzYCB3aWxsIHRocm93IGFuIGVycm9yIHdpdGhvdXQgcHJpbnRpbmcg YW55dGhpbmcgaWYKb25lIG9mIHRoZSBsaWJyYXJ5IGRvZXNuJ3QgZXhpc3QuCgpJbnN0ZWFkLCB3 ZSBjb3VsZCBkbyB0aGlzOgppZiAkcGtnX2NvbmZpZyAtLWV4aXN0cyB4ZW50b29sY29yZTsgdGhl bgogIHhlbl9wYys9IiB4ZW50b29sY29yZSIKZmkKCj4gICAgICBRRU1VX0NGTEFHUz0iJFFFTVVf Q0ZMQUdTICQoJHBrZ19jb25maWcgLS1jZmxhZ3MgJHhlbl9wYykiCj4gICAgICBsaWJzX3NvZnRt bXU9IiQoJHBrZ19jb25maWcgLS1saWJzICR4ZW5fcGMpICRsaWJzX3NvZnRtbXUiCj4gICAgICBM REZMQUdTPSIkKCRwa2dfY29uZmlnIC0tbGlicyAkeGVuX3BjKSAkTERGTEFHUyIKCgotLSAKQW50 aG9ueSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAd2Z-0002Vt-7x for qemu-devel@nongnu.org; Mon, 23 Apr 2018 11:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAd2U-0007l4-CW for qemu-devel@nongnu.org; Mon, 23 Apr 2018 11:06:03 -0400 Received: from smtp03.citrix.com ([162.221.156.55]:24522) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAd2U-0007kO-2B for qemu-devel@nongnu.org; Mon, 23 Apr 2018 11:05:58 -0400 Date: Mon, 23 Apr 2018 16:05:53 +0100 From: Anthony PERARD Message-ID: <20180423150553.GC1980@perard> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> Subject: Re: [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: qemu-devel@nongnu.org, Ross Lagerwall , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > From: Anthony PERARD > > Xen libraries in 4.10 include a new xentoolcore library. This > contains the xentoolcore_restrict_all function which we are about to > want to use. > > Signed-off-by: Ian Jackson > Acked-by: Stefano Stabellini > --- > v5: More truthful commit message. > --- > configure | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 0a19b03..f580255 100755 > --- a/configure > +++ b/configure > @@ -2188,7 +2188,7 @@ if test "$xen" != "no" ; then > $($pkg_config --modversion xencontrol | sed 's/\./ /g') )" > xen=yes > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab" > - xen_pc="$xen_pc xenevtchn xendevicemodel" > + xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore" I think we want to check if "xentoolcore" pkg_config exist before trying to use it. Otherwith, that is not going to work with Xen older than 4.10. `pkg-config --libs` will throw an error without printing anything if one of the library doesn't exist. Instead, we could do this: if $pkg_config --exists xentoolcore; then xen_pc+=" xentoolcore" fi > QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)" > libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu" > LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS" -- Anthony PERARD