All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Diego Viola <diego.viola@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	len.brown@intel.com, rui.zhang@intel.com,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)
Date: Mon, 23 Apr 2018 18:44:25 +0200	[thread overview]
Message-ID: <20180423164425.GS4129@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180423155801.GQ4129@hirez.programming.kicks-ass.net>

On Mon, Apr 23, 2018 at 05:58:01PM +0200, Peter Zijlstra wrote:
> Thomas, we could not find the de-rate stuff, but the above can be
> simplified; what happens is:
> 
> 	cs->flags |= UNSTABLE;
> 	schedule_work(&watchdog_work)
> 	  kthread_run(clocksource_watchdog_kthread)

Also, Thomas, do you remember why we spawn a short running kthread from
a work ? Can't we simply run the whole thing from the worker thread?

> 	    __clocksource_watchdog_kthread()
> 	      if (cs->flags & UNSTABLE)
> 	        __clocksource_change_rating()
> 	   clocksource_select()
> 

  reply	other threads:[~2018-04-23 16:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22  2:19 Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included) Diego Viola
2018-04-22 17:47 ` Diego Viola
2018-04-22 18:24   ` Diego Viola
2018-04-23  9:16 ` Peter Zijlstra
2018-04-23  9:27   ` Rafael J. Wysocki
2018-04-23 11:23   ` Diego Viola
2018-04-23 11:48     ` Peter Zijlstra
2018-04-23 11:49       ` Diego Viola
2018-04-23 12:38         ` Peter Zijlstra
2018-04-23 12:49           ` Diego Viola
2018-04-23 13:24             ` Diego Viola
2018-04-23 14:00           ` Peter Zijlstra
2018-04-23 14:02             ` Diego Viola
2018-04-23 15:10             ` Peter Zijlstra
2018-04-23 16:12               ` Diego Viola
2018-04-23 15:58           ` Peter Zijlstra
2018-04-23 16:44             ` Peter Zijlstra [this message]
2018-04-24  9:06               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180423164425.GS4129@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=diego.viola@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.