From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
rfried@codeaurora.org, bjorn.andersson@linaro.org,
loic.poulain@linaro.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [v2] wcn36xx: pass correct BSS index when deleting BSS keys
Date: Tue, 24 Apr 2018 05:57:29 +0000 (UTC) [thread overview]
Message-ID: <20180424055729.942DC6085F@smtp.codeaurora.org> (raw)
In-Reply-To: <20180412122330.6916-1-daniel@zonque.org>
Daniel Mack <daniel@zonque.org> wrote:
> The firmware message to delete BSS keys expects a BSS index to be passed.
> This field is currently hard-coded to 0. Fix this by passing in the index
> we received from the firmware when the BSS was configured.
>
> The encryption type in that message also needs to be set to what was used
> when the key was set, so the assignment of vif_priv->encrypt_type is now
> done after the firmware command was sent. This reportedly fixes the
> following error in AP mode:
>
> wcn36xx: ERROR hal_remove_bsskey response failed err=6
>
> Also, AFAIU, when a BSS is deleted, the firmware apparently drops all the
> keys associated with it. Trying to remove the key explicitly afterwards
> will hence lead to the following message:
>
> wcn36xx: ERROR hal_remove_bsskey response failed err=16
>
> This is now suppressed with an extra check for the BSS index validity.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
0fc8bb50bbfc wcn36xx: pass correct BSS index when deleting BSS keys
--
https://patchwork.kernel.org/patch/10338447/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-04-24 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 12:23 [PATCH v2] wcn36xx: pass correct BSS index when deleting BSS keys Daniel Mack
2018-04-24 5:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424055729.942DC6085F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@zonque.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.