From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 1/7] asm-generic, media: allow COMPILE_TEST with virt_to_bus Date: Tue, 24 Apr 2018 07:25:36 -0300 Message-ID: <20180424072536.65f0fc1c@vento.lan> References: Reply-To: MJPEG-tools user list Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: mjpeg-users-bounces@lists.sourceforge.net To: Arnd Bergmann Cc: linux-arch , mjpeg-users@lists.sourceforge.net, Mauro Carvalho Chehab , Linux Media Mailing List List-Id: linux-arch.vger.kernel.org Em Tue, 24 Apr 2018 09:55:55 +0200 Arnd Bergmann escreveu: > On Fri, Apr 20, 2018 at 7:42 PM, Mauro Carvalho Chehab > wrote: > > The virt_to_bus/bus_to_virt macros are arch-specific. Some > > archs don't support it. Yet, as it is interesting to allow > > doing compilation tests on non-ia32/ia64 archs, provide a > > fallback for such archs. > > > > While here, enable COMPILE_TEST for two media drivers that > > depends on it. > > > > Signed-off-by: Mauro Carvalho Chehab > > I'd prefer not to do this: virt_to_bus() is deprecated for good reasons, > and I'd rather see the drivers fixed to use dma-mapping.h correctly. > > One problem with your patch is that not all architectures include > asm-generic/io.h, so it likely breaks allmodconfig builds on architectures > that don't use that file and don't provide virt_to_bus() either. I see. I will drop this patch then. I might eventually try to fix the Zoran driver some day, with is the only media driver that uses virt_to_bus(), if I switch some day my builds to default to ARM, but such task has very low priority to me. Thanks, Mauro ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from osg.samsung.com ([64.30.133.232]:55947 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756125AbeDXKZm (ORCPT ); Tue, 24 Apr 2018 06:25:42 -0400 Date: Tue, 24 Apr 2018 07:25:36 -0300 From: Mauro Carvalho Chehab Subject: Re: [PATCH 1/7] asm-generic, media: allow COMPILE_TEST with virt_to_bus Message-ID: <20180424072536.65f0fc1c@vento.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Linux Media Mailing List , Mauro Carvalho Chehab , mjpeg-users@lists.sourceforge.net, linux-arch Message-ID: <20180424102536.F3EI6IfdfJvsxl_hvoryT5Kb1OBKnwCflgy7etKRPh0@z> Em Tue, 24 Apr 2018 09:55:55 +0200 Arnd Bergmann escreveu: > On Fri, Apr 20, 2018 at 7:42 PM, Mauro Carvalho Chehab > wrote: > > The virt_to_bus/bus_to_virt macros are arch-specific. Some > > archs don't support it. Yet, as it is interesting to allow > > doing compilation tests on non-ia32/ia64 archs, provide a > > fallback for such archs. > > > > While here, enable COMPILE_TEST for two media drivers that > > depends on it. > > > > Signed-off-by: Mauro Carvalho Chehab > > I'd prefer not to do this: virt_to_bus() is deprecated for good reasons, > and I'd rather see the drivers fixed to use dma-mapping.h correctly. > > One problem with your patch is that not all architectures include > asm-generic/io.h, so it likely breaks allmodconfig builds on architectures > that don't use that file and don't provide virt_to_bus() either. I see. I will drop this patch then. I might eventually try to fix the Zoran driver some day, with is the only media driver that uses virt_to_bus(), if I switch some day my builds to default to ARM, but such task has very low priority to me. Thanks, Mauro