From: Javier Arteaga <javier@emutex.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Dan O'Donovan <dan@emutex.com>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nicola Lunghi <nicola.lunghi@emutex.com>
Subject: Re: [PATCH v2 2/3] iio: adc128s052: add ACPI _HID AANT1280
Date: Tue, 24 Apr 2018 11:51:06 +0100 [thread overview]
Message-ID: <20180424105106.33efoxuhizcxcz5e@localhost> (raw)
In-Reply-To: <CAHp75VfONiaWmuadb2ijFcqrdr0QLexmxyd6kHUTxxH-itYtUQ@mail.gmail.com>
Hi Andy,
On Tue, Apr 24, 2018 at 01:08:31AM +0300, Andy Shevchenko wrote:
> > + if (ACPI_COMPANION(&spi->dev)) {
>
> > + const struct acpi_device_id *ad_id;
> > +
> > + ad_id = acpi_match_device(spi->dev.driver->acpi_match_table,
> > + &spi->dev);
> > + if (!ad_id)
> > + return -ENODEV;
> > +
> > + config = ad_id->driver_data;
>
> There is a new API to get it by one call.
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?id=b283f157611f129f5bbbf7d06f5af860d76797fd
That looks much cleaner. Will do for a v3.
Thank you!
next prev parent reply other threads:[~2018-04-24 10:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:38 [PATCH v2 0/3] iio: adc128s052: add matching options Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 1/3] iio: adc128s052: Add pin-compatible IDs Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 2/3] iio: adc128s052: add ACPI _HID AANT1280 Javier Arteaga
2018-04-23 22:08 ` Andy Shevchenko
2018-04-24 10:51 ` Javier Arteaga [this message]
2018-04-23 21:38 ` [PATCH v2 3/3] iio: adc128s052: reuse "compatible" for ACPI _DSD Javier Arteaga
2018-10-25 15:35 ` [PATCH v3 0/3] iio: adc128s052: add matching options Dan O'Donovan
2018-10-25 15:35 ` [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs Dan O'Donovan
2018-10-28 15:35 ` Jonathan Cameron
2018-10-30 19:37 ` Rob Herring
2018-10-30 19:37 ` Rob Herring
2018-10-25 15:35 ` [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280 Dan O'Donovan
2018-10-25 17:46 ` Andy Shevchenko
2018-10-26 10:13 ` Dan O'Donovan
2018-10-26 12:12 ` Andy Shevchenko
2018-10-27 17:14 ` Himanshu Jha
2018-10-28 11:42 ` Jonathan Cameron
2018-10-28 11:42 ` Jonathan Cameron
2018-10-28 11:56 ` Jonathan Cameron
2018-10-25 15:35 ` [PATCH v3 3/3] iio: adc128s052: use SPDX-License-Identifier Dan O'Donovan
2018-10-28 11:58 ` Jonathan Cameron
2018-10-25 17:49 ` [PATCH v3 0/3] iio: adc128s052: add matching options Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424105106.33efoxuhizcxcz5e@localhost \
--to=javier@emutex.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan@emutex.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicola.lunghi@emutex.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.