From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 0/3] cpufreq: dt: Allow platforms to provide suspend/resume hooks Date: Tue, 24 Apr 2018 11:08:25 +0200 Message-ID: <20180424110825.50436168@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Viresh Kumar Cc: Andrew Lunn , Vincent Guittot , Jason Cooper , linux-pm@vger.kernel.org, Gregory Clement , Rafael Wysocki , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgVmlyZXNoLAoKT24gVHVlLCAyNCBBcHIgMjAxOCAxMTozNzozMyArMDUzMCwgVmlyZXNoIEt1 bWFyCjx2aXJlc2gua3VtYXJAbGluYXJvLm9yZz4gd3JvdGU6Cgo+IEhpIE1pcXVlbCwKPiAKPiBU aGlzIGlzIGluIHJlc3BvbnNlIHRvIHRoZSBwYXRjaFsxXSB5b3Ugc2VudC4KClRoYW5rIHlvdSB2 ZXJ5IG11Y2ggZm9yIHRha2luZyB0aGUgdGltZSB0byBsb29rIGludG8gaXQuCgo+IAo+IEkgaGF2 ZSB1cGRhdGVkIHRoZSBjcHVmcmVxLWR0IGRyaXZlciB0byBhbGxvdyBwbGF0Zm9ybSBzcGVjaWZp Ywo+IHN1c3BlbmQvcmVzdW1lIGhvb2tzIGFuZCBkb25lIHNvbWUgbWlub3IgY2xlYW51cCBpbiB0 aGUgZHJpdmVyLiBJIGhhdmUKPiB1cGRhdGVkIHlvdXIgcGF0Y2ggYW5kIGFwcGxpZWQgdGhhdCBv biB0b3Agb2YgYWxsIHRoaXMuIEkgaGF2ZW4ndCB0ZXN0ZWQKPiBhbnkgb2YgdGhpcyBhbmQgd291 bGQgbmVlZCB5b3VyIGhlbHAgdG8gZ2V0IHRoYXQgZG9uZS4KCkkgdGVzdGVkIG9uIGFuIEVzcHJl c3NvQmluIChBcm1hZGEgMzcyMCksIGl0IHdvcmtzLgoKSG93ZXZlciwgSSBmaXJzdCBoYWQgYSBw YW5pYyBkdWUgdG8gdGhlIGNsb2NrIGJlaW5nICdwdXQnIHR3aWNlLiBJCnN1Z2dlc3QgeW91IHRv IG1lcmdlIHRoaXMgWzFdIGludG8gdGhlIHNlY29uZCBwYXRjaC4gV2l0aCB0aGlzIChvcgpzb21l dGhpbmcgc2ltaWxhcik6CgpUZXN0ZWQtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxA Ym9vdGxpbi5jb20+CgpBbmQgdGhlIHBhdGggZXJyb3Igd2FzIHJlYWNoZWQgYmVjYXVzZSBJIGRp ZCBub3Qgc2VsZWN0IHRoZSBjcHVmcmVxLWR0CmRyaXZlciBpbiBtZW51Y29uZmlnLCB3aGljaCBJ IHRoaW5rIHNob3VsZCBiZSBzZWxlY3RlZCBieSBkZWZhdWx0IHdoZW4KZW5hYmxpbmcgdGhlIGFy bWFkYTM3eHgtY3B1ZnJlcSBkcml2ZXIuIEkgd3JvdGUgYSBzbWFsbCBwYXRjaCBmb3IKdGhhdCB0 b28sIHNlZSBbMl0uIFRlbGwgbWUgaWYgeW91IHdhbnQgbWUgdG8gc2VuZCBpdCBvZiBpZiB5b3Ug d2FudCB0bwppbmNsdWRlIGl0IGluIHRoZSBuZXh0IHZlcnNpb24gPwoKWzFdIGh0dHA6Ly9jb2Rl LmJ1bGl4Lm9yZy9hdXpkcWEtMzIzNjQ2ClsyXSBodHRwOi8vY29kZS5idWxpeC5vcmcvZTF5azVo LTMyMzY0NwoKVGhhbmsgeW91LApNaXF1w6hsCgoKPiAKPiBUaGFua3MuCj4gCj4gLS0KPiB2aXJl c2gKPiAKPiBbMV0gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci8yMDE4MDQyMTE0MTk0My4yNTcw NS0xLW1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20KPiAKPiBNaXF1ZWwgUmF5bmFsICgxKToKPiAg IGNwdWZyZXE6IGFkZCBzdXNwZW5kL3Jlc3VtZSBzdXBwb3J0IGluIEFybWFkYSAzN3h4IERWRlMg ZHJpdmVyCj4gCj4gVmlyZXNoIEt1bWFyICgyKToKPiAgIGNwdWZyZXE6IGR0OiBBbGxvdyBwbGF0 Zm9ybSBzcGVjaWZpYyBzdXNwZW5kL3Jlc3VtZSBjYWxsYmFja3MKPiAgIGNwdWZyZXE6IGFybWFk YTogRnJlZSByZXNvdXJjZXMgb24gZXJyb3IgcGF0aHMKPiAKPiAgZHJpdmVycy9jcHVmcmVxL2Fy bWFkYS0zN3h4LWNwdWZyZXEuYyB8IDEwNyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tCj4gIGRyaXZlcnMvY3B1ZnJlcS9jcHVmcmVxLWR0LmMgICAgICAgICAgfCAgMTAgKysrLQo+ ICBkcml2ZXJzL2NwdWZyZXEvY3B1ZnJlcS1kdC5oICAgICAgICAgIHwgICA1ICsrCj4gIDMgZmls ZXMgY2hhbmdlZCwgMTA0IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAoKCgotLSAK TWlxdWVsIFJheW5hbCwgQm9vdGxpbiAoZm9ybWVybHkgRnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVk IExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Tue, 24 Apr 2018 11:08:25 +0200 Subject: [PATCH 0/3] cpufreq: dt: Allow platforms to provide suspend/resume hooks In-Reply-To: References: Message-ID: <20180424110825.50436168@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Viresh, On Tue, 24 Apr 2018 11:37:33 +0530, Viresh Kumar wrote: > Hi Miquel, > > This is in response to the patch[1] you sent. Thank you very much for taking the time to look into it. > > I have updated the cpufreq-dt driver to allow platform specific > suspend/resume hooks and done some minor cleanup in the driver. I have > updated your patch and applied that on top of all this. I haven't tested > any of this and would need your help to get that done. I tested on an EspressoBin (Armada 3720), it works. However, I first had a panic due to the clock being 'put' twice. I suggest you to merge this [1] into the second patch. With this (or something similar): Tested-by: Miquel Raynal And the path error was reached because I did not select the cpufreq-dt driver in menuconfig, which I think should be selected by default when enabling the armada37xx-cpufreq driver. I wrote a small patch for that too, see [2]. Tell me if you want me to send it of if you want to include it in the next version ? [1] http://code.bulix.org/auzdqa-323646 [2] http://code.bulix.org/e1yk5h-323647 Thank you, Miqu?l > > Thanks. > > -- > viresh > > [1] https://lkml.kernel.org/r/20180421141943.25705-1-miquel.raynal at bootlin.com > > Miquel Raynal (1): > cpufreq: add suspend/resume support in Armada 37xx DVFS driver > > Viresh Kumar (2): > cpufreq: dt: Allow platform specific suspend/resume callbacks > cpufreq: armada: Free resources on error paths > > drivers/cpufreq/armada-37xx-cpufreq.c | 107 +++++++++++++++++++++++++++++----- > drivers/cpufreq/cpufreq-dt.c | 10 +++- > drivers/cpufreq/cpufreq-dt.h | 5 ++ > 3 files changed, 104 insertions(+), 18 deletions(-) > -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com