From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: simplify procfs code for seq_file instances Date: Tue, 24 Apr 2018 16:23:04 +0200 Message-ID: <20180424142304.GE26136@lst.de> References: <20180419124140.9309-1-hch@lst.de> <20180419185750.GD2066@avx2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180419185750.GD2066@avx2> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Alexey Dobriyan Cc: linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alessandro Zummo , Alexandre Belloni , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Corey Minyard , linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Viro , Jiri Slaby , Andrew Morton , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , megaraidlinux.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > git://git.infradead.org/users/hch/misc.git proc_create > > > I want to ask if it is time to start using poorman function overloading > with _b_c_e(). There are millions of allocation functions for example, > all slightly difference, and people will add more. Seeing /proc interfaces > doubled like this is painful. Function overloading is totally unacceptable. And I very much disagree with a tradeoff that keeps 5000 lines of code vs a few new helpers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:59581 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758365AbeDXOVg (ORCPT ); Tue, 24 Apr 2018 10:21:36 -0400 Date: Tue, 24 Apr 2018 16:23:04 +0200 From: Christoph Hellwig To: Alexey Dobriyan Cc: Christoph Hellwig , Andrew Morton , Alexander Viro , Greg Kroah-Hartman , Jiri Slaby , Corey Minyard , Alessandro Zummo , Alexandre Belloni , linux-acpi@vger.kernel.org, drbd-dev@lists.linbit.com, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, devel@driverdev.osuosl.org, linux-afs@lists.infradead.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: simplify procfs code for seq_file instances Message-ID: <20180424142304.GE26136@lst.de> References: <20180419124140.9309-1-hch@lst.de> <20180419185750.GD2066@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180419185750.GD2066@avx2> Sender: linux-rtc-owner@vger.kernel.org List-ID: On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > git://git.infradead.org/users/hch/misc.git proc_create > > > I want to ask if it is time to start using poorman function overloading > with _b_c_e(). There are millions of allocation functions for example, > all slightly difference, and people will add more. Seeing /proc interfaces > doubled like this is painful. Function overloading is totally unacceptable. And I very much disagree with a tradeoff that keeps 5000 lines of code vs a few new helpers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 9F1601056F9F for ; Tue, 24 Apr 2018 16:21:34 +0200 (CEST) Date: Tue, 24 Apr 2018 16:23:04 +0200 From: Christoph Hellwig To: Alexey Dobriyan Message-ID: <20180424142304.GE26136@lst.de> References: <20180419124140.9309-1-hch@lst.de> <20180419185750.GD2066@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180419185750.GD2066@avx2> Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Corey Minyard , linux-ide@vger.kernel.org, Greg Kroah-Hartman , jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Alexander Viro , Jiri Slaby , Andrew Morton , linux-ext4@vger.kernel.org, Christoph Hellwig , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] simplify procfs code for seq_file instances List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > git://git.infradead.org/users/hch/misc.git proc_create > > > I want to ask if it is time to start using poorman function overloading > with _b_c_e(). There are millions of allocation functions for example, > all slightly difference, and people will add more. Seeing /proc interfaces > doubled like this is painful. Function overloading is totally unacceptable. And I very much disagree with a tradeoff that keeps 5000 lines of code vs a few new helpers. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3158210-1524579703-2-4017432761644618160 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.137', Host='smtp4.osuosl.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1524579702; b=r4b8hFOETQvqAu7gR02PpyVf2BnolCM8K0tljV+GBWP4fWxtZN qzwbWG0t44Wox8bsSNahrpImRC37pudA9bubNJJhnWS6sYX5q+IGmQHgTdFpWjuO Jdk5Dfbd2TvoqeaATD5uGv/IfhwiXq/keSy6rprN9pQ2kEs75hnLewL+cahcII2K zh8SI6AahsGenVwr5njbw9gs9BVUrgUaxPx6d3iYF+hmGBYtI6xXHCVZEGznTDn5 B47mOURygSk7ruiYSH0uCLTWnl4LTQVFlCRcFC5nuPWLXfQJTB1PJEOrJJmyJmav O8yzdXnUpg72/r6myCmtKpMezCYC2ZQE+Lpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=fm2; t=1524579702; bh=+eKPZ fGUnEgcloqoB/ifAU3xUG1ODFbN3jLUtizJKjM=; b=rUc+ELzB3uaZUXgLrIZPJ r0IaviHU4TKdd4aWgRHcyJiklXcIPApvfnASjaNJ8QmRwfN2ClSjh7nA/cYGsNuT Jo7S9ay9K6lxd25TS1w3f92Gsl4xGMXQDAEz7n3amQoubLkLx8YgSA5kSpcia+15 G73pyg97GqBAGora6Ly2MjVUWpmteblPI4aY2EEthrYX5RrAHJr7eI3IXB/8TFX5 Hm0jceBjYM6b6yfrJE207K9i4RDV9RYcGAPN337QTMueaJclx7ujX4olOcZwdLAx Sme5RL4Sn+yJhxJEUixdwriW7iBdeKpURRe7QKX3XSVgognt0Myh6kSLX0oL1/ce g== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=lst.de header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-cm=discussion score=0; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=lst.de header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfHWGPr2l6Ns+7lnp0TrD/jY7T0dVWV1FYcMZVor3HbZDrhPg2yLrIn5mRrkOaLEiaUD3GZX7S46jzRvrIXw8tuLVWOIQ1BEHC2o0TPVVlQr1Wq74HqoH +YywQMeGakMHNmYZR+RVZ8d+gbf+TEqEiksgtyMQxy5Hw28+T0PoL5cljm0NuxvZTrUERcGnTTRZPPoBblsIuB/5TzHMAUI1PRLQ93M4WX2FLrQz6EtMxV4N SdgK38uSraImG+jFPC0QYQ== X-CM-Analysis: v=2.3 cv=Tq3Iegfh c=1 sm=1 tr=0 a=584k1XxxM9pnnVd4MmWcNA==:117 a=584k1XxxM9pnnVd4MmWcNA==:17 a=kj9zAlcOel0A:10 a=Kd1tUaAdevIA:10 a=-uNXE31MpBQA:10 a=jJxKW8Ag-pUA:10 a=JfrnYn6hAAAA:8 a=DDOyTI_5AAAA:8 a=yjP-KMLsiVDQ3MBg87kA:9 a=CjuIK1q_8ugA:10 a=1CNFftbPRP8L7MoqJWF3:22 a=_BcfOz0m4U4ohdxiHPKc:22 cc=dsc X-ME-CMScore: 0 X-ME-CMCategory: discussion X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Tue, 24 Apr 2018 16:23:04 +0200 From: Christoph Hellwig To: Alexey Dobriyan Subject: Re: simplify procfs code for seq_file instances Message-ID: <20180424142304.GE26136@lst.de> References: <20180419124140.9309-1-hch@lst.de> <20180419185750.GD2066@avx2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180419185750.GD2066@avx2> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Corey Minyard , linux-ide@vger.kernel.org, Greg Kroah-Hartman , jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Alexander Viro , Jiri Slaby , Andrew Morton , linux-ext4@vger.kernel.org, Christoph Hellwig , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > git://git.infradead.org/users/hch/misc.git proc_create > > > I want to ask if it is time to start using poorman function overloading > with _b_c_e(). There are millions of allocation functions for example, > all slightly difference, and people will add more. Seeing /proc interfaces > doubled like this is painful. Function overloading is totally unacceptable. And I very much disagree with a tradeoff that keeps 5000 lines of code vs a few new helpers. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel