From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report Date: Tue, 24 Apr 2018 16:54:07 +0100 Message-ID: <20180424155407.GK20310@redhat.com> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-16-git-send-email-ian.jackson@eu.citrix.com> <23263.17660.17771.980752@mariner.uk.xensource.com> <20180424151830.GI20310@redhat.com> <1e72b98a-5553-5990-2327-c86c75952e87@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fB0Gj-0002Dl-KN for xen-devel@lists.xenproject.org; Tue, 24 Apr 2018 15:54:13 +0000 Content-Disposition: inline In-Reply-To: <1e72b98a-5553-5990-2327-c86c75952e87@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eric Blake Cc: Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org, Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org, Ross Lagerwall , Paolo Bonzini , Anthony PERARD , Ian Jackson , Alistair Francis , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBBcHIgMjQsIDIwMTggYXQgMTA6NDM6MDlBTSAtMDUwMCwgRXJpYyBCbGFrZSB3cm90 ZToKPiBPbiAwNC8yNC8yMDE4IDEwOjQwIEFNLCBFcmljIEJsYWtlIHdyb3RlOgo+ID4gT24gMDQv MjQvMjAxOCAxMDoxOCBBTSwgRGFuaWVsIFAuIEJlcnJhbmfDqSB3cm90ZToKPiA+IAo+ID4+PiAg LSBzdGF0aWMgdm9pZCB2cmVwb3J0KHJlcG9ydF90eXBlIHR5cGUsIGNvbnN0IGNoYXIgKmZtdCwg dmFfbGlzdCBhcCkKPiA+Pj4gICsgc3RhdGljIHZvaWQgdnJlcG9ydChyZXBvcnRfdHlwZSB0eXBl LCBpbnQgZXJybm92YWwsIGNvbnN0IGNoYXIgKmZtdCwgdmFfbGlzdCBhcCkKPiA+Pj4gLi4uCj4g Pj4+ICArICAgICBpZiAoZXJybm92YWwgPj0gMCkgewo+ID4+PiAgKyAgICAgICAgIGVycm9yX3By aW50ZigiOiAlcyIsIHN0cmVycm9yKGVycm5vdmFsKTsKPiA+Pj4gICsgICAgIH0KPiA+Pj4KPiA+ Pj4gYW5kIHRoZW4gYWRkIGJvdGgKPiA+Pj4gICBlcnJvcl9yZXBvcnRfZXJybm8KPiA+Pj4gICBl cnJvcl92cmVwb3J0X2Vycm5vCj4gPj4+IHdpdGggdGhlIG9idmlvdXMgc2VtYW50aWNzLgo+ID4+ Cj4gPj4gVGhhdCB3b3VsZCBiZSBuaWNlLCBiZWNhdXNlIHRoZW4gd2UgY2FuIG1ha2UgdGhlc2Ug dHdvIGZ1bmN0aW9ucyBhY3R1YWxseQo+ID4+IHVzZSBzdHJlcnJvcl9yKCkgaW5zdGVhZCBvZiBz dHJlcnJvcigpLCBmb3IgdGhyZWFkIHNhZmV0eSBvbiBhbGwgcGxhdGZvcm1zLgo+ID4gCj4gPiBF eGNlcHQgdGhhdCBzdHJlcnJvcl9yKCkgaXMgYSBiZWFyIHRvIHVzZSBwb3J0YWJseSwgZ2l2ZW4g dGhhdCBnbGliYydzCj4gPiBkZWZhdWx0IGRlY2xhcmF0aW9uIGRpZmZlcnMgZnJvbSB0aGUgUE9T SVggcmVxdWlyZW1lbnQgKHlvdSBjYW4gZm9yY2UKPiA+IGdsaWJjIHRvIGdpdmUgeW91IHRoZSBQ T1NJWCB2ZXJzaW9uLCBidXQgZG9pbmcgc28gY2F1c2VzIHlvdSB0byBsb3NlCj4gPiBhY2Nlc3Mg dG8gbWFueSBvdGhlciB1c2VmdWwgZXh0ZW5zaW9ucykuICBJdCdzIHJhdGhlciB0ZWxsaW5nIHRo YXQgJ2dpdAo+ID4gZ3JlcCBzdHJlcnJvcl9yJyBjdXJyZW50bHkgY29tZXMgdXAgZW1wdHkuCj4g Cj4gVGhhdCBzYWlkLCBnbGliJ3MgZ19zdHJlcnJvcigpIG1heSBiZSBzdWl0YWJsZSBmb3IgdGhp cyBwdXJwb3NlLAo+IGFsdGhvdWdoIHdlIGFyZSBjdXJyZW50bHkgdXNpbmcgaXQgb25seSBpbiB0 ZXN0cy9pdnNobWVtLXRlc3QuYy4KClllcywgdGhhdCB1c2VzIHN0cmVycm9yX3IgaW50ZXJuYWxs eSwgb3Igc3RyZXJyb3JfcyBvbiBXaW5kb3dzOgoKaHR0cHM6Ly9naXRsYWIuZ25vbWUub3JnL0dO T01FL2dsaWIvYmxvYi9tYXN0ZXIvZ2xpYi9nc3RyZnVuY3MuYyNMMTIzNgoKClJlZ2FyZHMsCkRh bmllbAotLSAKfDogaHR0cHM6Ly9iZXJyYW5nZS5jb20gICAgICAtby0gICAgaHR0cHM6Ly93d3cu ZmxpY2tyLmNvbS9waG90b3MvZGJlcnJhbmdlIDp8Cnw6IGh0dHBzOi8vbGlidmlydC5vcmcgICAg ICAgICAtby0gICAgICAgICAgICBodHRwczovL2ZzdG9wMTM4LmJlcnJhbmdlLmNvbSA6fAp8OiBo dHRwczovL2VudGFuZ2xlLXBob3RvLm9yZyAgICAtby0gICAgaHR0cHM6Ly93d3cuaW5zdGFncmFt LmNvbS9kYmVycmFuZ2UgOnwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB0Gn-0005ll-V3 for qemu-devel@nongnu.org; Tue, 24 Apr 2018 11:54:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fB0Gm-00006R-9J for qemu-devel@nongnu.org; Tue, 24 Apr 2018 11:54:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37464 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fB0Gm-00006N-2h for qemu-devel@nongnu.org; Tue, 24 Apr 2018 11:54:16 -0400 Date: Tue, 24 Apr 2018 16:54:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180424155407.GK20310@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-16-git-send-email-ian.jackson@eu.citrix.com> <23263.17660.17771.980752@mariner.uk.xensource.com> <20180424151830.GI20310@redhat.com> <1e72b98a-5553-5990-2327-c86c75952e87@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1e72b98a-5553-5990-2327-c86c75952e87@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Ian Jackson , Juergen Gross , Stefano Stabellini , Markus Armbruster , Michael Tokarev , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Ross Lagerwall , Paolo Bonzini , Anthony PERARD , xen-devel@lists.xenproject.org, Alistair Francis On Tue, Apr 24, 2018 at 10:43:09AM -0500, Eric Blake wrote: > On 04/24/2018 10:40 AM, Eric Blake wrote: > > On 04/24/2018 10:18 AM, Daniel P. Berrang=C3=A9 wrote: > >=20 > >>> - static void vreport(report_type type, const char *fmt, va_list a= p) > >>> + static void vreport(report_type type, int errnoval, const char *= fmt, va_list ap) > >>> ... > >>> + if (errnoval >=3D 0) { > >>> + error_printf(": %s", strerror(errnoval); > >>> + } > >>> > >>> and then add both > >>> error_report_errno > >>> error_vreport_errno > >>> with the obvious semantics. > >> > >> That would be nice, because then we can make these two functions act= ually > >> use strerror_r() instead of strerror(), for thread safety on all pla= tforms. > >=20 > > Except that strerror_r() is a bear to use portably, given that glibc'= s > > default declaration differs from the POSIX requirement (you can force > > glibc to give you the POSIX version, but doing so causes you to lose > > access to many other useful extensions). It's rather telling that 'g= it > > grep strerror_r' currently comes up empty. >=20 > That said, glib's g_strerror() may be suitable for this purpose, > although we are currently using it only in tests/ivshmem-test.c. Yes, that uses strerror_r internally, or strerror_s on Windows: https://gitlab.gnome.org/GNOME/glib/blob/master/glib/gstrfuncs.c#L1236 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|