All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v2 0/5] logging enhancements
Date: Tue, 24 Apr 2018 09:58:03 -0700	[thread overview]
Message-ID: <20180424165808.23292-1-stephen@networkplumber.org> (raw)

This patch set improves the log-level option in EAL.
It adds symbolic names for log levels (error, info, debug, etc)
and shell style matching of log levels.
   --log-level='pmd.ixgbe.*:debug'

The original syntax (which is maintained for compatibility)
used numeric values, comma as separator and regular expression
to match log level.

It was often documented as:
   --log-level='pmd.ixgbe.*,8' ...
but this only worked by accident. The period was really
a regular expression match any character (not match a period);
and the asterisk in regular expression is match repeated value.

v2
  - make facility table constant
  - rebase to include support for dynamic log late binding
  - add patch to make saving log level a private API
  - update driver docs

Stephen Hemminger (5):
  eal: make syslog facility table const
  eal: allow symbolic log levels
  eal: make eal_log_level save private
  log: add ability to match dynamic log based on shell pattern
  doc: update guides for current preferrred log level syntax

 doc/guides/contributing/coding_style.rst   |   2 +-
 doc/guides/cryptodevs/dpaa2_sec.rst        |   2 +-
 doc/guides/cryptodevs/dpaa_sec.rst         |   2 +-
 doc/guides/faq/faq.rst                     |  23 ++---
 doc/guides/nics/dpaa2.rst                  |   4 +-
 doc/guides/nics/qede.rst                   |   2 +-
 doc/guides/nics/sfc_efx.rst                |  12 +--
 doc/guides/nics/tap.rst                    |   2 +-
 lib/librte_eal/common/eal_common_log.c     | 103 ++++++++++++++++---
 lib/librte_eal/common/eal_common_options.c | 113 +++++++++++++--------
 lib/librte_eal/common/eal_private.h        |   6 ++
 lib/librte_eal/common/include/rte_log.h    |  44 +++-----
 12 files changed, 203 insertions(+), 112 deletions(-)

-- 
2.17.0

             reply	other threads:[~2018-04-24 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 16:58 Stephen Hemminger [this message]
2018-04-24 16:58 ` [PATCH v2 1/5] eal: make syslog facility table const Stephen Hemminger
2018-04-24 16:58 ` [PATCH v2 2/5] eal: allow symbolic log levels Stephen Hemminger
2018-04-24 16:58 ` [PATCH v2 3/5] eal: make eal_log_level save private Stephen Hemminger
2018-04-24 23:55   ` Thomas Monjalon
2018-04-24 16:58 ` [PATCH v2 4/5] log: add ability to match dynamic log based on shell pattern Stephen Hemminger
2018-04-25  0:02   ` Thomas Monjalon
2018-04-25  0:08   ` Thomas Monjalon
2018-04-24 16:58 ` [PATCH v2 5/5] doc: update guides for current preferrred log level syntax Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424165808.23292-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.