From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: matthew.s.atwood@intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Intel: Add a Kaby Lake PCI ID
Date: Tue, 24 Apr 2018 10:46:43 -0700 [thread overview]
Message-ID: <20180424174642.GJ27583@intel.com> (raw)
In-Reply-To: <20180424174226.GI27583@intel.com>
On Tue, Apr 24, 2018 at 10:42:26AM -0700, Rodrigo Vivi wrote:
> On Mon, Apr 23, 2018 at 03:08:31PM -0700, matthew.s.atwood@intel.com wrote:
> > From: Matt Atwood <matthew.s.atwood@intel.com>
>
> Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
>
> (I'm adding this and pushing. Thanks for the patch)
>
> >
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
ops... I take it back... sorry
I just reviewed the id and had match the
spec and kernel patch, but I had forgotten here we need a different
identifier for this platform.
You are just redefining the existent one. You need to define a new
one and add enable it.
>
> > ---
> > intel/intel_chipset.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> > index 01d250e..6b8fd1d 100644
> > --- a/intel/intel_chipset.h
> > +++ b/intel/intel_chipset.h
> > @@ -203,6 +203,7 @@
> > #define PCI_CHIP_KABYLAKE_ULX_GT2 0x591E
> > #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> > #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> > +#define PCI_CHIP_KABYLAKE_M_GT2 0x591C
> > #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
> > #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B
> > #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-24 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 22:08 [PATCH] Intel: Add a Kaby Lake PCI ID matthew.s.atwood
2018-04-24 17:42 ` Rodrigo Vivi
2018-04-24 17:46 ` Rodrigo Vivi [this message]
2018-04-24 17:55 ` matthew.s.atwood
2018-04-24 18:18 ` Rodrigo Vivi
2018-04-24 19:05 ` matthew.s.atwood
2018-04-24 19:42 ` matthew.s.atwood
2018-04-24 20:06 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424174642.GJ27583@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=matthew.s.atwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.