diff for duplicates of <20180424200906.GC174675@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 8a1ff86..6b68f59 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On Tue, Apr 24, 2018 at 02:58:45PM -0500, Serge E. Hallyn wrote: > > > > > > + WARN(1, "big key algorithm changed?"); > > > > > > Please avoid using WARN() WARN_ON() etc. -> > > syzbot would catch it and panic() due to panic_on_warn == 1. +> > > syzbot would catch it and panic() due to panic_on_warn = 1. > > > > But it is really a programming bug in this case (and it seems better > > than BUG()...). Isn't this exactly the sort of case we want to catch? diff --git a/a/content_digest b/N1/content_digest index b0c0b0a..1110c99 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\020180424195845.GB23575@mail.hallyn.com\0" "From\0Eric Biggers <ebiggers3@gmail.com>\0" "Subject\0Re: [PATCH 1/3] big key: get rid of stack array allocation\0" - "Date\0Tue, 24 Apr 2018 13:09:06 -0700\0" + "Date\0Tue, 24 Apr 2018 20:09:06 +0000\0" "To\0Serge E. Hallyn <serge@hallyn.com>\0" "Cc\0Tycho Andersen <tycho@tycho.ws>" Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> @@ -27,7 +27,7 @@ "> > > > > > +\t\tWARN(1, \"big key algorithm changed?\");\n" "> > > \n" "> > > Please avoid using WARN() WARN_ON() etc.\n" - "> > > syzbot would catch it and panic() due to panic_on_warn == 1.\n" + "> > > syzbot would catch it and panic() due to panic_on_warn = 1.\n" "> > \n" "> > But it is really a programming bug in this case (and it seems better\n" "> > than BUG()...). Isn't this exactly the sort of case we want to catch?\n" @@ -49,4 +49,4 @@ "\n" Eric -dcccf6eb52c0a0b5008d1a892242d32c11f66eb412b5af1497d3d393ea93243f +f181e36f6e0e26b2681143acd7c430c65ed8b2cba525ae3ac1f1ae96379ed599
diff --git a/a/1.txt b/N2/1.txt index 8a1ff86..adc41c0 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,5 +1,5 @@ On Tue, Apr 24, 2018 at 02:58:45PM -0500, Serge E. Hallyn wrote: -> Quoting Tycho Andersen (tycho@tycho.ws): +> Quoting Tycho Andersen (tycho at tycho.ws): > > On Tue, Apr 24, 2018 at 11:46:38PM +0900, Tetsuo Handa wrote: > > > Tycho Andersen wrote: > > > > > > + if (unlikely(crypto_aead_ivsize(big_key_aead) != GCM_AES_IV_SIZE)) { @@ -27,3 +27,7 @@ pr_warn(). But here it is appropriate. Unfortunately a lot of developers still seem confused; improving the comments in include/asm-generic/bug.h might help. Eric +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index b0c0b0a..424dd82 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,23 +4,14 @@ "ref\0201804242346.FHI69745.SQMHFVOOFLFOJt@I-love.SAKURA.ne.jp\0" "ref\020180424145104.GC3125@cisco\0" "ref\020180424195845.GB23575@mail.hallyn.com\0" - "From\0Eric Biggers <ebiggers3@gmail.com>\0" - "Subject\0Re: [PATCH 1/3] big key: get rid of stack array allocation\0" + "From\0ebiggers3@gmail.com (Eric Biggers)\0" + "Subject\0[PATCH 1/3] big key: get rid of stack array allocation\0" "Date\0Tue, 24 Apr 2018 13:09:06 -0700\0" - "To\0Serge E. Hallyn <serge@hallyn.com>\0" - "Cc\0Tycho Andersen <tycho@tycho.ws>" - Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> - dhowells@redhat.com - keyrings@vger.kernel.org - linux-security-module@vger.kernel.org - linux-kernel@vger.kernel.org - kernel-hardening@lists.openwall.com - jmorris@namei.org - " Jason@zx2c4.com\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Tue, Apr 24, 2018 at 02:58:45PM -0500, Serge E. Hallyn wrote:\n" - "> Quoting Tycho Andersen (tycho@tycho.ws):\n" + "> Quoting Tycho Andersen (tycho at tycho.ws):\n" "> > On Tue, Apr 24, 2018 at 11:46:38PM +0900, Tetsuo Handa wrote:\n" "> > > Tycho Andersen wrote:\n" "> > > > > > +\tif (unlikely(crypto_aead_ivsize(big_key_aead) != GCM_AES_IV_SIZE)) {\n" @@ -47,6 +38,10 @@ "pr_warn(). But here it is appropriate. Unfortunately a lot of developers still\n" "seem confused; improving the comments in include/asm-generic/bug.h might help.\n" "\n" - Eric + "Eric\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -dcccf6eb52c0a0b5008d1a892242d32c11f66eb412b5af1497d3d393ea93243f +8eec4048738f19310ed145e009b698aaf40ff08bd584ae6f6875cf76d637f45f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.