From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 2/3] drm/i915/dp: Fix sink-crc reads. Date: Tue, 24 Apr 2018 13:55:57 -0700 Message-ID: <20180424205555.GG1994@intel.com> References: <20180424025659.23659-1-dhinakaran.pandiyan@intel.com> <20180424025659.23659-2-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DE8B6E05C for ; Tue, 24 Apr 2018 20:55:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180424025659.23659-2-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBcHIgMjMsIDIwMTggYXQgMDc6NTY6NThQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBTaW5rIGNyYyBpcyBjYWxjdWxhdGVkIGJ5IHRoZSBzaW5rIGZvciBzdGF0 aWMgZnJhbWVzIGlycmVzcGVjdGl2ZSBvZgo+IHdoYXQgdGhlIGRyaXZlciBzZXRzIGluIFRFU1Rf U0lOS19TVEFSVCBkcGNkLiBTaW5jZSBQU1IgaXMgdGhlIG9ubHkgdXNlCj4gY2FzZSBmb3Igc2lu ayBjcmMsIHdlIGRvbid0IHJlYWxseSBuZWVkIHRoZSBzaW5rX2NyY197c3RhcnQsIHN0b3B9IGNv ZGUuCj4gCj4gVGhlIHNlY29uZCBwcm9ibGVtIHdpdGggdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRp b24gaXMgdmJsYW5rIHdhaXRzLgo+IEVuYWJsaW5nIHZibGFuayBpbnRlcnJ1cHRzIHRyaWdnZXJz IFBTUiBleGl0LCB3aGljaCBtZWFucyB3ZSBhcmVuJ3QKPiByZWFsbHkgcmVhZGluZyB0aGUgY29y cmVjdCBDUkMgdmFsdWVzIGZvciBQU1IgdGVzdHMuIHZibGFuayB3YWl0cyBhcmUKPiByZXBsYWNl ZCBieSBkZWxheXMuCj4gCj4gV2l0aCB0aGUgY2hhbmdlcyBtYWRlIGluIHRoaXMgcGF0Y2gsIHNp bmsgQ1JDIGlzIGF2YWlsYWJsZSBvbmx5IGZvcgo+IHN0YXRpYyBmcmFtZXMuIEkgaGF2ZSB0ZXN0 ZWQgdGhpcyBvbiBhIFNLTCBsYXB0b3Agd2l0aCBQU1IgcGFuZWwuCj4gCj4gU2lnbmVkLW9mZi1i eTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIHwgICAyICstCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgIHwgMTE0ICsrKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAg ICB8ICAgMyArLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEwNCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1 Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IDJmMDVm NTI2MmJiYS4uMzVmYTE0MThjYzA3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2Zz LmMKPiBAQCAtMjc4NCw3ICsyNzg0LDcgQEAgc3RhdGljIGludCBpOTE1X3NpbmtfY3JjKHN0cnVj dCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkKPiAgCj4gIAkJaW50ZWxfZHAgPSBlbmNfdG9faW50 ZWxfZHAoc3RhdGUtPmJlc3RfZW5jb2Rlcik7Cj4gIAo+IC0JCXJldCA9IGludGVsX2RwX3Npbmtf Y3JjKGludGVsX2RwLCBjcnRjX3N0YXRlLCBjcmMpOwo+ICsJCXJldCA9IGludGVsX2RwX3Npbmtf Y3JjKGludGVsX2RwLCBjcmMpOwo+ICAJCWlmIChyZXQpCj4gIAkJCWdvdG8gZXJyOwo+ICAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA3ZGNjODc0YjdkOGYuLjczNTJhYjYzMWVhOCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0zODc2LDMyICszODc2LDE4IEBAIGlu dGVsX2RwX2NvbmZpZ3VyZV9tc3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQkJCQlp bnRlbF9kcC0+aXNfbXN0KTsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2Ny Y19zdG9wKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gLQkJCQkgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlLCBib29sIGRpc2FibGVfd2EpCj4gK2ludCBpbnRlbF9kcF9z aW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OCAqY3JjKQo+ICB7Cj4gLQlzdHJ1 Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2Rw KTsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3Bv cnQtPmJhc2UuYmFzZS5kZXYpOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0 b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gLQl1OCBidWY7Cj4gLQlpbnQg cmV0ID0gMDsKPiAtCWludCBjb3VudCA9IDA7Cj4gLQlpbnQgYXR0ZW1wdHMgPSAxMDsKPiArCWlu dCBjb3VudCA9IDAsIHJldCA9IDAsIGF0dGVtcHRzOwo+ICAKPiAtCWlmIChkcm1fZHBfZHBjZF9y ZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApIHsKPiAtCQlEUk1f REVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBiZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsKPiAt CQlyZXQgPSAtRUlPOwo+IC0JCWdvdG8gb3V0Owo+IC0JfQo+ICsJZm9yIChhdHRlbXB0cyA9IDA7 IGF0dGVtcHRzIDwgMyAmJiBjb3VudCA9PSAwOyBhdHRlbXB0cysrKSB7Cj4gKwkJdTggYnVmOwo+ ICAKPiAtCWlmIChkcm1fZHBfZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lO SywKPiAtCQkJICAgICAgIGJ1ZiAmIH5EUF9URVNUX1NJTktfU1RBUlQpIDwgMCkgewo+IC0JCURS TV9ERUJVR19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+ IC0JCXJldCA9IC1FSU87Cj4gLQkJZ290byBvdXQ7Cj4gLQl9Cj4gLQo+IC0JZG8gewo+IC0JCWlu dGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4gKwkJLyog V2FpdCBmb3IgYXBwcm94aW1hdGVseSBoYWxmIGEgZnJhbWUsIHdlIGNhbm5vdCB3YWl0IGZvciBh Cgp0aGF0IHNob3VsZCBiZSBkZXBlbmRlbmQgb24gdGhlIG1vZGUgdGltaW5ncyByaWdodD8hCkkg bWVhbiwgSSdtIG5vdCBhZ2FpbnN0IHNvbWUgcmFuZG9tIHZhbHVlIHRoYXQgbWF0Y2hlcyBtb3N0 IHVzZWQgY2FzZXMsCmJ1dCBJIGJlbGlldmUgdGhlIHN0YXRlbWVudCBzaG91bGQgYmUgZGlmZmVy ZW50LgoKPiArCQkgKiB2YmxhbmsgaW50ZXJydXB0IGFzIGl0IHRyaWdnZXJzIFBTUiBleGl0Lgo+ ICsJCSAqLwo+ICsJCWlmIChhdHRlbXB0cykKPiArCQkJdXNsZWVwX3JhbmdlKDgwMDAsIDg1MDAp Owo+ICAKPiAgCQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gIAkJCQkg ICAgICBEUF9URVNUX1NJTktfTUlTQywgJmJ1ZikgPCAwKSB7Cj4gQEAgLTM5MDksOTMgKzM4OTUs MTkgQEAgc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHAsCj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KPiAgCQljb3VudCA9IGJ1ZiAmIERQX1RF U1RfQ09VTlRfTUFTSzsKPiAtCX0gd2hpbGUgKC0tYXR0ZW1wdHMgJiYgY291bnQpOwo+IC0KPiAt CWlmIChhdHRlbXB0cyA9PSAwKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiVElNRU9VVDogU2luayBD UkMgY291bnRlciBpcyBub3QgemVyb2VkIGFmdGVyIGNhbGN1bGF0aW9uIGlzIHN0b3BwZWRcbiIp Owo+IC0JCXJldCA9IC1FVElNRURPVVQ7Cj4gIAl9Cj4gIAo+IC0gb3V0Ogo+IC0JaWYgKGRpc2Fi bGVfd2EpCj4gLQkJaHN3X2VuYWJsZV9pcHMoY3J0Y19zdGF0ZSk7Cj4gLQlyZXR1cm4gcmV0Owo+ IC19Cj4gLQo+IC1zdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3JjX3N0YXJ0KHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsCj4gLQkJCQkgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSkKPiAtewo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90 b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ IC0JdTggYnVmOwo+IC0JaW50IHJldDsKPiAtCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOS19NSVNDLCAmYnVmKSA8IDApCj4gLQkJcmV0dXJuIC1F SU87Cj4gLQo+IC0JaWYgKCEoYnVmICYgRFBfVEVTVF9DUkNfU1VQUE9SVEVEKSkKPiAtCQlyZXR1 cm4gLUVOT1RUWTsKPiAtCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgs IERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKQo+IC0JCXJldHVybiAtRUlPOwo+IC0KPiAtCWlmIChi dWYgJiBEUF9URVNUX1NJTktfU1RBUlQpIHsKPiAtCQlyZXQgPSBpbnRlbF9kcF9zaW5rX2NyY19z dG9wKGludGVsX2RwLCBjcnRjX3N0YXRlLCBmYWxzZSk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0 dXJuIHJldDsKPiAtCX0KPiAtCj4gLQloc3dfZGlzYWJsZV9pcHMoY3J0Y19zdGF0ZSk7Cj4gLQo+ IC0JaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ IC0JCQkgICAgICAgYnVmIHwgRFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApIHsKPiAtCQloc3dfZW5h YmxlX2lwcyhjcnRjX3N0YXRlKTsKPiAtCQlyZXR1cm4gLUVJTzsKPiAtCX0KPiAtCj4gLQlpbnRl bF93YWl0X2Zvcl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+IC0JcmV0dXJu IDA7Cj4gLX0KPiAtCj4gLWludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwLCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwgdTggKmNyYykKPiAt ewo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdfcG9y dChpbnRlbF9kcCk7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p OTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRl bF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+IC0JdTggYnVm Owo+IC0JaW50IGNvdW50LCByZXQ7Cj4gLQlpbnQgYXR0ZW1wdHMgPSA2Owo+IC0KPiAtCXJldCA9 IGludGVsX2RwX3NpbmtfY3JjX3N0YXJ0KGludGVsX2RwLCBjcnRjX3N0YXRlKTsKPiAtCWlmIChy ZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4gLQlkbyB7Cj4gLQkJaW50ZWxfd2FpdF9mb3JfdmJs YW5rKGRldl9wcml2LCBpbnRlbF9jcnRjLT5waXBlKTsKPiAtCj4gLQkJaWYgKGRybV9kcF9kcGNk X3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+IC0JCQkJICAgICAgRFBfVEVTVF9TSU5LX01JU0MsICZi dWYpIDwgMCkgewo+IC0JCQlyZXQgPSAtRUlPOwo+IC0JCQlnb3RvIHN0b3A7Cj4gLQkJfQo+IC0J CWNvdW50ID0gYnVmICYgRFBfVEVTVF9DT1VOVF9NQVNLOwo+IC0KPiAtCX0gd2hpbGUgKC0tYXR0 ZW1wdHMgJiYgY291bnQgPT0gMCk7Cj4gLQo+IC0JaWYgKGF0dGVtcHRzID09IDApIHsKPiAtCQlE Uk1fRVJST1IoIlBhbmVsIGlzIHVuYWJsZSB0byBjYWxjdWxhdGUgYW55IENSQyBhZnRlciA2IHZi bGFua3NcbiIpOwo+ICsJaWYgKGF0dGVtcHRzID09IDMpIHsKPiAgCQlyZXQgPSAtRVRJTUVET1VU Owo+IC0JCWdvdG8gc3RvcDsKPiArCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4gIAlpZiAoZHJtX2Rw X2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9DUkNfUl9DUiwgY3JjLCA2KSAhPSA2 KSB7Cj4gIAkJcmV0ID0gLUVJTzsKPiAtCQlnb3RvIHN0b3A7Cj4gKwkJZ290byBvdXQ7Cj4gIAl9 Cj4gIAo+IC1zdG9wOgo+IC0JaW50ZWxfZHBfc2lua19jcmNfc3RvcChpbnRlbF9kcCwgY3J0Y19z dGF0ZSwgdHJ1ZSk7Cj4gK291dDoKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCA0NGVkMjQ4ZjFmZTkuLmNhY2VlOTQ3NDllMiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE2NDQsOCArMTY0NCw3IEBAIHZvaWQgaW50 ZWxfZHBfc2lua19kcG1zKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGludCBtb2RlKTsKPiAg dm9pZCBpbnRlbF9kcF9lbmNvZGVyX3Jlc2V0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rlcik7 Cj4gIHZvaWQgaW50ZWxfZHBfZW5jb2Rlcl9zdXNwZW5kKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpp bnRlbF9lbmNvZGVyKTsKPiAgdm9pZCBpbnRlbF9kcF9lbmNvZGVyX2Rlc3Ryb3koc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyKTsKPiAtaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsCj4gLQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUsIHU4ICpjcmMpOwo+ICtpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgdTggKmNyYyk7Cj4gIGJvb2wgaW50ZWxfZHBfY29tcHV0ZV9jb25maWcoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCSAgICAgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJCQkgICAgIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRl ICpjb25uX3N0YXRlKTsKPiAtLSAKPiAyLjE0LjEKPiAKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==