From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video-uclass: Fix logical-not-parentheses warning
Date: Tue, 24 Apr 2018 21:03:11 +0200 [thread overview]
Message-ID: <20180424210311.13959dac@crub> (raw)
In-Reply-To: <1524404868-28053-1-git-send-email-trini@konsulko.com>
On Sun, 22 Apr 2018 09:47:48 -0400
Tom Rini trini at konsulko.com wrote:
> With clang-4.0 and later we see:
> warning: logical not is only applied to the left hand side of this bitwise
> operator [-Wlogical-not-parentheses]
> if ((!gd->flags & GD_FLG_RELOC))
> ^ ~
>
> And while the compiler suggests adding parenthesis around gd->flags, a
> reading of the code says that we want to know when GD_FLG_RELOC is not
> set and then return.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Anatolij Gustschin <agust@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> drivers/video/video-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-video/master, thanks!
--
Anatolij
prev parent reply other threads:[~2018-04-24 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 13:47 [U-Boot] [PATCH] video-uclass: Fix logical-not-parentheses warning Tom Rini
2018-04-24 19:03 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424210311.13959dac@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.