All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Subhash Jadavani <subhashj@codeaurora.org>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: ufs: Use freq table with devfreq
Date: Tue, 24 Apr 2018 15:14:09 -0700	[thread overview]
Message-ID: <20180424221409.GE18510@minitux> (raw)
In-Reply-To: <5e59150bf025e2caa1deadfec7293ecd@codeaurora.org>

On Tue 24 Apr 15:08 PDT 2018, Subhash Jadavani wrote:

> On 2018-04-23 17:20, Bjorn Andersson wrote:
> > devfreq requires that the client operates on actual frequencies, not
> > only 0 and UMAX_INT and as such UFS brok with the introduction of
> > f1d981eaecf8 ("PM / devfreq: Use the available min/max frequency").
> > 
> > This patch registers the frequencies of the first clock with devfreq and
> > use these to determine if we're trying to step up or down.
> > 
[..]
> 
> Looks good to me.
> Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
> 

Thanks Subhash. Unfortunately I need to respin this to register the opp
table based on our freq table, so there will be a v2 of this soon.

Regards,
Bjorn

      reply	other threads:[~2018-04-24 22:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  0:20 [PATCH 0/3] Fix UFS and devfreq interaction Bjorn Andersson
2018-04-24  0:20 ` [PATCH 1/3] PM / devfreq: Actually support providing freq_table Bjorn Andersson
2018-04-24  2:48   ` Chanwoo Choi
2018-04-24  5:29     ` Bjorn Andersson
2018-04-24  6:09       ` MyungJoo Ham
2018-04-24 18:48         ` Bjorn Andersson
2018-04-24  7:26       ` Chanwoo Choi
2018-04-24 18:38         ` Bjorn Andersson
2018-04-24  0:20 ` [PATCH 2/3] scsi: ufs: Extract devfreq registration Bjorn Andersson
2018-04-24 21:08   ` Subhash Jadavani
2018-04-24  0:20 ` [PATCH 3/3] scsi: ufs: Use freq table with devfreq Bjorn Andersson
2018-04-24 22:08   ` Subhash Jadavani
2018-04-24 22:14     ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424221409.GE18510@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.