From: "J. Bruce Fields" <bfields@fieldses.org>
To: Olga Kornievskaia <aglo@umich.edu>
Cc: Mailing List Linux NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Args need to be the same for replay cache
Date: Tue, 24 Apr 2018 18:16:12 -0400 [thread overview]
Message-ID: <20180424221612.GA30120@fieldses.org> (raw)
In-Reply-To: <CAN-5tyFZDJcQPyHyBjeS0BDS-dqe6iS1+k9jftxDqnDMy__D5g@mail.gmail.com>
On Tue, Apr 24, 2018 at 04:10:29PM -0400, Olga Kornievskaia wrote:
> Do you by any chance have a reference to this discussion?
This:
http://lkml.kernel.org/r/1507740502-5151-1-git-send-email-Thomas.Haynes@primarydata.com
and this:
http://lkml.kernel.org/r/E0161195-9F4A-4B36-A71D-6A924498C893@primarydata.com
and followups.
> I would like to reference it. For now I'm hijacking this thread to
> bring this up. I'm still concerned about the case where client sent a
> request and slot got interrupted (so by default the client doesn't
> increment the seq#). Then the client re-used the slot for the same
> kind of operation (WRITE is very interesting) with same arguments but
> say different FH. Is the server obligated the cache the whole call to
> address and check that? You have a patch to check for false retries
> that checks for different creds but I don't think you have something
> that would catch this case?
Right. I don't believe the spec requires us to catch false retries in
every possible case. That may mean we return a pretty bizarre reply
that doesn't match the request, but that's the client's own fault....
--b.
prev parent reply other threads:[~2018-04-24 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 16:48 [PATCH] Args need to be the same for replay cache Thomas Haynes
2017-10-12 18:32 ` pynfs replay cache test SEQ9f Thomas Haynes
2017-10-12 19:30 ` Trond Myklebust
2017-10-12 19:49 ` J. Bruce Fields
2017-10-12 21:39 ` [nfsv4] " Thomas Haynes
2017-10-12 21:44 ` J. Bruce Fields
2017-10-12 22:00 ` Tom Haynes
2017-10-13 1:52 ` J. Bruce Fields
2017-10-13 13:34 ` Trond Myklebust
2017-10-13 15:00 ` bfields
2017-10-13 15:26 ` Trond Myklebust
2017-10-13 18:50 ` bfields
2017-10-13 20:19 ` bfields
2017-10-17 21:31 ` bfields
2017-10-16 16:15 ` [nfsv4] " Frank Filz
2018-04-10 19:49 ` [PATCH] Args need to be the same for replay cache J. Bruce Fields
2018-04-24 20:10 ` Olga Kornievskaia
2018-04-24 22:16 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424221612.GA30120@fieldses.org \
--to=bfields@fieldses.org \
--cc=aglo@umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.