All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Bart Van Assche <Bart.VanAssche@wdc.com>
Subject: Re: [PATCH v4] blktests: regression test "block: do not use interruptible wait anywhere"
Date: Tue, 24 Apr 2018 15:46:04 -0700	[thread overview]
Message-ID: <20180424224604.GA28295@vader> (raw)
In-Reply-To: <20180417152136.16546-1-alan.christopher.jenkins@gmail.com>

On Tue, Apr 17, 2018 at 04:21:36PM +0100, Alan Jenkins wrote:
> > Without this fix, I get an IO error in this test:
> >
> > # dd if=/dev/sda of=/dev/null iflag=direct & \
> >   while killall -SIGUSR1 dd; do sleep 0.1; done & \
> >   echo mem > /sys/power/state ; \
> >   sleep 5; killall dd  # stop after 5 seconds
> 
> linux-block specifically asked for a test derived from this reproducer.
> They didn't come up with any suggestion for testing the code more directly
> (and robustly).  So this test uses system suspend, automated with pm_test.
> 
> Signed-off-by: Alan Jenkins <alan.christopher.jenkins@gmail.com>

Hi, Alan, thanks for the test. I was able to come up with a
deterministic reproducer which runs in a few seconds, added here:
https://github.com/osandov/blktests/blob/master/tests/block/016.

  reply	other threads:[~2018-04-24 22:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 16:23 [PATCH] block: do not use interruptible wait anywhere Alan Jenkins
2018-04-12 17:51 ` Bart Van Assche
2018-04-12 17:51   ` Bart Van Assche
2018-04-12 18:11   ` [PATCH v2] " Alan Jenkins
2018-04-13  8:31     ` Johannes Thumshirn
2018-04-14 19:46       ` blktest for " Alan Jenkins
2018-04-14 19:52         ` Jens Axboe
2018-04-15 12:15           ` Alan Jenkins
2018-04-16 21:23             ` [PATCH] blktests: regression test "block: do not use interruptible wait anywhere" Alan Jenkins
2018-04-16 21:52               ` Alan Jenkins
2018-04-17  7:21                 ` Johannes Thumshirn
2018-04-17 15:55                   ` Alan Jenkins
2018-04-17 15:10                     ` [PATCH v3] " Alan Jenkins
2018-04-17 15:21                       ` [PATCH v4] " Alan Jenkins
2018-04-24 22:46                         ` Omar Sandoval [this message]
2018-04-25  8:46                           ` Alan Jenkins
2018-04-18  7:25                     ` [PATCH] " Johannes Thumshirn
2018-04-14 19:54     ` [PATCH v2] block: do not use interruptible wait anywhere Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424224604.GA28295@vader \
    --to=osandov@osandov.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=alan.christopher.jenkins@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.