From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/udl: fix mode_valid's return type Date: Wed, 25 Apr 2018 09:08:58 +0200 Message-ID: <20180425070858.GL25142@phenom.ffwll.local> References: <20180424131520.2409-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95EC56E15B for ; Wed, 25 Apr 2018 07:09:02 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id o78so4862786wmg.0 for ; Wed, 25 Apr 2018 00:09:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180424131520.2409-1-luc.vanoostenryck@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luc Van Oostenryck Cc: Robert Tarasov , Keith Packard , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjQsIDIwMTggYXQgMDM6MTU6MTdQTSArMDIwMCwgTHVjIFZhbiBPb3N0ZW5y eWNrIHdyb3RlOgo+IFRoZSBtZXRob2Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNz Ojptb2RlX3ZhbGlkIGlzIGRlZmluZWQKPiBhcyByZXR1cm5pbmcgYW4gJ2VudW0gZHJtX21vZGVf c3RhdHVzJyBidXQgdGhlIGRyaXZlciBpbXBsZW1lbnRhdGlvbgo+IGZvciB0aGlzIG1ldGhvZCB1 c2VzIGFuICdpbnQnIGZvciBpdC4KPiAKPiBGaXggdGhpcyBieSB1c2luZyAnZW51bSBkcm1fbW9k ZV9zdGF0dXMnIGluIHRoZSBkcml2ZXIgdG9vLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1YyBWYW4g T29zdGVucnljayA8bHVjLnZhbm9vc3RlbnJ5Y2tAZ21haWwuY29tPgoKaGlzaWxpY29uLCBtZ2Fn MjAwIGFuZCB1ZGwgcGF0Y2hlcyBhbHNvIG1lcmdlZCB0byBkcm0tbWlzYy1uZXh0LgotRGFuaWVs Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9jb25uZWN0b3IuYyB8IDIgKy0KPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX2Nvbm5lY3Rvci5jIGIvZHJpdmVycy9ncHUv ZHJtL3VkbC91ZGxfY29ubmVjdG9yLmMKPiBpbmRleCBjM2RjMWZkMjAuLjA5ZGM1ODVhYSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9jb25uZWN0b3IuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS91ZGwvdWRsX2Nvbm5lY3Rvci5jCj4gQEAgLTEwNSw3ICsxMDUsNyBAQCBz dGF0aWMgaW50IHVkbF9nZXRfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikK PiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IHVkbF9tb2RlX3ZhbGlkKHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gK3N0YXRpYyBlbnVtIGRybV9tb2RlX3N0YXR1 cyB1ZGxfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQkg IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+ICB7Cj4gIAlzdHJ1Y3QgdWRsX2Rldmlj ZSAqdWRsID0gY29ubmVjdG9yLT5kZXYtPmRldl9wcml2YXRlOwo+IC0tIAo+IDIuMTcuMAo+IAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbeDYHJE (ORCPT ); Wed, 25 Apr 2018 03:09:04 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39089 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbeDYHJC (ORCPT ); Wed, 25 Apr 2018 03:09:02 -0400 X-Google-Smtp-Source: AIpwx480yzxmNxtsN7ujNkTh9fpKvew7V2uu6jSQy/XXEJKC8e9DtiLTeYOxbUvyo7PzGUwlbwsL2A== Date: Wed, 25 Apr 2018 09:08:58 +0200 From: Daniel Vetter To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Dave Airlie , David Airlie , Alex Deucher , Robert Tarasov , Daniel Vetter , Keith Packard , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/udl: fix mode_valid's return type Message-ID: <20180425070858.GL25142@phenom.ffwll.local> Mail-Followup-To: Luc Van Oostenryck , linux-kernel@vger.kernel.org, Dave Airlie , David Airlie , Alex Deucher , Robert Tarasov , Keith Packard , dri-devel@lists.freedesktop.org References: <20180424131520.2409-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424131520.2409-1-luc.vanoostenryck@gmail.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 03:15:17PM +0200, Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck hisilicon, mgag200 and udl patches also merged to drm-misc-next. -Daniel > --- > drivers/gpu/drm/udl/udl_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index c3dc1fd20..09dc585aa 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -105,7 +105,7 @@ static int udl_get_modes(struct drm_connector *connector) > return 0; > } > > -static int udl_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status udl_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct udl_device *udl = connector->dev->dev_private; > -- > 2.17.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch