From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/virtio: fix mode_valid's return type Date: Wed, 25 Apr 2018 09:40:02 +0200 Message-ID: <20180425074002.GP25142@phenom.ffwll.local> References: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC9FD6E05A for ; Wed, 25 Apr 2018 07:40:06 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id n10so4991997wmc.1 for ; Wed, 25 Apr 2018 00:40:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luc Van Oostenryck Cc: David Airlie , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Gerd Hoffmann List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjQsIDIwMTggYXQgMDM6MTU6MjRQTSArMDIwMCwgTHVjIFZhbiBPb3N0ZW5y eWNrIHdyb3RlOgo+IFRoZSBtZXRob2Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNz Ojptb2RlX3ZhbGlkIGlzIGRlZmluZWQKPiBhcyByZXR1cm5pbmcgYW4gJ2VudW0gZHJtX21vZGVf c3RhdHVzJyBidXQgdGhlIGRyaXZlciBpbXBsZW1lbnRhdGlvbgo+IGZvciB0aGlzIG1ldGhvZCB1 c2VzIGFuICdpbnQnIGZvciBpdC4KPiAKPiBGaXggdGhpcyBieSB1c2luZyAnZW51bSBkcm1fbW9k ZV9zdGF0dXMnIGluIHRoZSBkcml2ZXIgdG9vLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1YyBWYW4g T29zdGVucnljayA8bHVjLnZhbm9vc3RlbnJ5Y2tAZ21haWwuY29tPgoKT2ssIGFwcGxpZWQgYWxs IHRoZSBvdGhlcnMgdGhhdCBoYXZlIGJlZW4gc3R1Y2sgaW4gbW9kZXJhdGlvbiBvcgpzb21ldGhp bmcsIGV4Y2VwdCBmb3IgYW55IHBhdGNoIHRvdWNoaW5nIG5vdXZlYXUvcmFkZW9uL2FtZGdwdS4g VGhvc2UgbmVlZApvdCBnbyBpbiB0aHJvdWdoIG90aGVyIHRyZWVzLgoKQWxsIG1lcmdlZCBpbnRv IGRybS1taXNjLW5leHQuCgpUaGFua3MsIERhbmllbAo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v dmlydGlvL3ZpcnRncHVfZGlzcGxheS5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3ZpcnRpby92aXJ0Z3B1X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdw dV9kaXNwbGF5LmMKPiBpbmRleCA4Y2M4YzM0ZDYuLmE1ZWRkODY2MCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2Rpc3BsYXkuYwo+IEBAIC0yMDgsNyArMjA4LDcgQEAgc3Rh dGljIGludCB2aXJ0aW9fZ3B1X2Nvbm5fZ2V0X21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IpCj4gIAlyZXR1cm4gY291bnQ7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgdmlydGlv X2dwdV9jb25uX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAr c3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzIHZpcnRpb19ncHVfY29ubl9tb2RlX3ZhbGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkgICAgICBzdHJ1Y3QgZHJtX2Rp c3BsYXlfbW9kZSAqbW9kZSkKPiAgewo+ICAJc3RydWN0IHZpcnRpb19ncHVfb3V0cHV0ICpvdXRw dXQgPQo+IC0tIAo+IDIuMTcuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbeDYHkI (ORCPT ); Wed, 25 Apr 2018 03:40:08 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39820 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbeDYHkG (ORCPT ); Wed, 25 Apr 2018 03:40:06 -0400 X-Google-Smtp-Source: AIpwx486V6uH6E/yuARuWhleJIUMwl55sAMoRP6mk3ba7UlJy0Qe+mGcJrxISSTX9aGMNoy7kjdjnA== Date: Wed, 25 Apr 2018 09:40:02 +0200 From: Daniel Vetter To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Gerd Hoffmann , virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drm/virtio: fix mode_valid's return type Message-ID: <20180425074002.GP25142@phenom.ffwll.local> Mail-Followup-To: Luc Van Oostenryck , linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Gerd Hoffmann , virtualization@lists.linux-foundation.org References: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424131524.2510-1-luc.vanoostenryck@gmail.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 03:15:24PM +0200, Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck Ok, applied all the others that have been stuck in moderation or something, except for any patch touching nouveau/radeon/amdgpu. Those need ot go in through other trees. All merged into drm-misc-next. Thanks, Daniel > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c > index 8cc8c34d6..a5edd8660 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -208,7 +208,7 @@ static int virtio_gpu_conn_get_modes(struct drm_connector *connector) > return count; > } > > -static int virtio_gpu_conn_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status virtio_gpu_conn_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct virtio_gpu_output *output = > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch