From: Vinod Koul <vinod.koul@intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com,
kuninori.morimoto.gx@renesas.com
Subject: Re: [PATCH 1/3] ASoC: compress: Only call free for components which have been opened
Date: Wed, 25 Apr 2018 14:22:19 +0530 [thread overview]
Message-ID: <20180425085219.GI6014@localhost> (raw)
In-Reply-To: <20180424153903.7693-1-ckeepax@opensource.cirrus.com>
On Tue, Apr 24, 2018 at 04:39:01PM +0100, Charles Keepax wrote:
> The core should only call free on a component if said component has
> already had open called on it. This is not presently the case and most
> compressed drivers in the kernel assume it will be. This causes null
> pointer dereferences in the drivers as they attempt clean up for stuff
> that was never put in place.
>
> This is fixed by aborting calling open callbacks once a failure is
> encountered and then during clean up only iterating through the
> component list to that point.
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2018-04-25 8:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:39 [PATCH 1/3] ASoC: compress: Only call free for components which have been opened Charles Keepax
2018-04-24 15:39 ` [PATCH 2/3] ASoC: Remove platform code now everything is componentised Charles Keepax
2018-04-25 8:53 ` Vinod Koul
2018-04-24 15:39 ` [PATCH 3/3] ASoC: compress: Add helper functions for component open/free Charles Keepax
2018-04-25 9:07 ` Vinod Koul
2018-04-26 11:46 ` Applied "ASoC: compress: Add helper functions for component open/free" to the asoc tree Mark Brown
2018-04-26 11:49 ` Mark Brown
2018-04-26 11:53 ` Mark Brown
2018-04-25 8:52 ` Vinod Koul [this message]
2018-04-26 11:46 ` Applied "ASoC: compress: Only call free for components which have been opened" " Mark Brown
2018-04-26 11:49 ` Mark Brown
2018-04-26 11:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425085219.GI6014@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.