From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Paul Durrant <paul.durrant@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: bogus wrap check in xen-netback
Date: Wed, 25 Apr 2018 11:47:39 +0100 [thread overview]
Message-ID: <20180425104739.bmq6srva2vpgotf4@citrix.com> (raw)
In-Reply-To: <20180425123511.0f66639d.olaf@aepfle.de>
On Wed, Apr 25, 2018 at 12:35:11PM +0200, Olaf Hering wrote:
> Am Wed, 25 Apr 2018 11:31:25 +0100
> schrieb Wei Liu <wei.liu2@citrix.com>:
>
> > My bad. Yes, they are converted to int, not unsigned int.
>
> Hopefully that happens only if the target is int, not if all involved variables are short.
>
> Unless there are objections I will prepare a patch to deal with RING_IDX being u16.
>
RING_IDX is a type defined in the public header -- I don't think you can
change that at all. You don't know what third party drivers rely on
that.
If you want to change the type locally in netback, then why? Aren't you
just debugging?
In that light, I don't see a point having a patch to deal with u16.
Wei.
> Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-04-25 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 7:19 bogus wrap check in xen-netback Olaf Hering
2018-04-25 7:28 ` Juergen Gross
2018-04-25 7:39 ` Olaf Hering
2018-04-25 8:59 ` Wei Liu
2018-04-25 9:04 ` Olaf Hering
2018-04-25 9:48 ` Jan Beulich
2018-04-25 10:06 ` Wei Liu
2018-04-25 10:26 ` Jan Beulich
2018-04-25 10:31 ` Wei Liu
2018-04-25 10:35 ` Olaf Hering
2018-04-25 10:47 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425104739.bmq6srva2vpgotf4@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=olaf@aepfle.de \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.