All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/6] block: byte-based AIO read/write
Date: Wed, 25 Apr 2018 12:59:35 +0200	[thread overview]
Message-ID: <20180425105935.GD4652@localhost.localdomain> (raw)
In-Reply-To: <20180424192506.149089-1-eblake@redhat.com>

Am 24.04.2018 um 21:25 hat Eric Blake geschrieben:
> While we would prefer that block drivers use coroutines instead
> of aio callbacks, it is a fairly easy exercise to prove that
> all existing drivers with aio callbacks are merely scaling
> from bytes into sectors and back to bytes.  So, even though I
> am not set up to completely run (or even compile-test) this
> full series, it seems pretty straightforward to change the
> signature to quit playing games with pointless scaling.
> 
> Incorporate Kevin's review on v1, which amounted to pretty much
> rewriting the series to be saner (the block layer now defaults
> to alignment of 1, so drivers that still need 512 for keeping the
> patch conservative have to override that; and improve the code
> in io.c to put byte-based access before sector-based fallbacks).

Thanks, applied to the block-next branch.

Kevin

      parent reply	other threads:[~2018-04-25 10:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 19:25 [Qemu-devel] [PATCH v2 0/6] block: byte-based AIO read/write Eric Blake
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 1/6] block: Support byte-based aio callbacks Eric Blake
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 2/6] file-win32: Switch to byte-based callbacks Eric Blake
2018-04-25 10:57   ` Kevin Wolf
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 3/6] null: Switch to byte-based read/write Eric Blake
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 4/6] rbd: Switch to byte-based callbacks Eric Blake
2018-04-24 19:53   ` [Qemu-devel] [Qemu-block] " Jason Dillaman
2018-04-25 10:58     ` Kevin Wolf
2018-04-25 13:00   ` Eric Blake
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 5/6] vxhs: " Eric Blake
2018-04-24 19:25 ` [Qemu-devel] [PATCH v2 6/6] block: Drop last of the sector-based aio callbacks Eric Blake
2018-04-25 10:59 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425105935.GD4652@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.