From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Alexander.Deucher@amd.com, Christian.Koenig@amd.com,
David.Panariti@amd.com, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.
Date: Wed, 25 Apr 2018 15:55:52 +0200 [thread overview]
Message-ID: <20180425135552.GD7592@redhat.com> (raw)
In-Reply-To: <877eowa5qh.fsf@xmission.com>
On 04/24, Eric W. Biederman wrote:
>
> Let me respectfully suggest that the wait_event_killable on that code
> path is wrong.
I tend to agree even if I don't know this code.
But if it can be called from f_op->release() then any usage of "current" or
signals looks suspicious. Simply because "current" can be completely irrelevant
task which does the last fput(), say, cat /proc/pid/fdinfo/... or even a kernel
thread.
Oleg.
next prev parent reply other threads:[~2018-04-25 13:55 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:30 Avoid uninterruptible sleep during process exit Andrey Grodzovsky
2018-04-24 15:30 ` Andrey Grodzovsky
[not found] ` <1524583836-12130-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2018-04-24 15:30 ` [PATCH 1/3] signals: Allow generation of SIGKILL to exiting task Andrey Grodzovsky
2018-04-24 15:30 ` Andrey Grodzovsky
2018-04-24 16:10 ` Eric W. Biederman
2018-04-24 16:10 ` Eric W. Biederman
2018-04-24 16:42 ` Eric W. Biederman
2018-04-24 16:42 ` Eric W. Biederman
[not found] ` <87y3hca73s.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-24 16:51 ` Andrey Grodzovsky
2018-04-24 16:51 ` Andrey Grodzovsky
2018-04-24 17:29 ` Eric W. Biederman
2018-04-25 13:13 ` Oleg Nesterov
2018-04-24 15:30 ` [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process Andrey Grodzovsky
2018-04-24 15:30 ` Andrey Grodzovsky
2018-04-24 15:46 ` Michel Dänzer
2018-04-24 15:52 ` Andrey Grodzovsky
2018-04-24 15:52 ` Andrey Grodzovsky
[not found] ` <7313704c-0693-0bb9-8818-99cd2b7c0ca0-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-04-24 15:51 ` Andrey Grodzovsky
2018-04-24 15:51 ` Andrey Grodzovsky
2018-04-24 19:44 ` Daniel Vetter
2018-04-24 19:44 ` Daniel Vetter
2018-04-24 21:00 ` Eric W. Biederman
[not found] ` <20180424194418.GE25142-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-24 21:02 ` Andrey Grodzovsky
2018-04-24 21:02 ` Andrey Grodzovsky
2018-04-24 21:21 ` Eric W. Biederman
[not found] ` <87tvs05mik.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-24 21:37 ` Andrey Grodzovsky
2018-04-24 21:37 ` Andrey Grodzovsky
2018-04-24 22:11 ` Eric W. Biederman
2018-04-25 7:14 ` Daniel Vetter
2018-04-25 13:08 ` Andrey Grodzovsky
2018-04-25 13:08 ` Andrey Grodzovsky
2018-04-25 15:29 ` Eric W. Biederman
2018-04-25 16:13 ` Andrey Grodzovsky
2018-04-25 16:31 ` Eric W. Biederman
2018-04-24 21:40 ` Daniel Vetter
2018-04-24 21:40 ` Daniel Vetter
2018-04-25 13:22 ` Oleg Nesterov
2018-04-25 13:36 ` Daniel Vetter
2018-04-25 14:18 ` Oleg Nesterov
2018-04-25 14:18 ` Oleg Nesterov
2018-04-25 13:43 ` Andrey Grodzovsky
2018-04-25 13:43 ` Andrey Grodzovsky
2018-04-24 16:23 ` Eric W. Biederman
2018-04-24 16:23 ` Eric W. Biederman
[not found] ` <87muxsbmkp.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-24 16:43 ` Andrey Grodzovsky
2018-04-24 16:43 ` Andrey Grodzovsky
2018-04-24 17:12 ` Eric W. Biederman
2018-04-25 13:55 ` Oleg Nesterov [this message]
[not found] ` <20180425135552.GD7592-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-04-25 14:21 ` Andrey Grodzovsky
2018-04-25 14:21 ` Andrey Grodzovsky
2018-04-25 17:17 ` Oleg Nesterov
[not found] ` <20180425171757.GA10441-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-04-25 18:40 ` Andrey Grodzovsky
2018-04-25 18:40 ` Andrey Grodzovsky
2018-04-26 0:01 ` Eric W. Biederman
[not found] ` <874ljyu98e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-26 12:34 ` Andrey Grodzovsky
2018-04-26 12:34 ` Andrey Grodzovsky
[not found] ` <611911a3-2858-200c-d5f8-679c5f41ee3a-5C7GfCeVMHo@public.gmane.org>
2018-04-26 12:52 ` Andrey Grodzovsky
2018-04-26 12:52 ` Andrey Grodzovsky
2018-04-26 15:57 ` Eric W. Biederman
[not found] ` <87zi1qq7t1.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-26 20:43 ` Andrey Grodzovsky
2018-04-26 20:43 ` Andrey Grodzovsky
2018-04-30 12:08 ` Christian König
2018-04-30 12:08 ` Christian König
[not found] ` <c3c9787d-b279-8169-43d1-74eeb666ffbd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-30 14:32 ` Andrey Grodzovsky
2018-04-30 14:32 ` Andrey Grodzovsky
[not found] ` <bceb1a1b-c453-782d-5a7d-40fa2f22c813-5C7GfCeVMHo@public.gmane.org>
2018-04-30 15:25 ` Christian König
2018-04-30 15:25 ` Christian König
2018-04-30 16:00 ` Oleg Nesterov
[not found] ` <20180430160006.GB10583-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-04-30 16:10 ` Andrey Grodzovsky
2018-04-30 16:10 ` Andrey Grodzovsky
[not found] ` <e5b0221d-84ba-10ff-4a58-4fa27c99650f-5C7GfCeVMHo@public.gmane.org>
2018-04-30 18:29 ` Christian König
2018-04-30 18:29 ` Christian König
[not found] ` <bb224134-7ccb-cc87-9a71-3ef1743eb074-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-30 19:28 ` Andrey Grodzovsky
2018-04-30 19:28 ` Andrey Grodzovsky
[not found] ` <79b2ce10-2cd7-b6f2-551e-0b4ae21072af-5C7GfCeVMHo@public.gmane.org>
2018-05-02 11:48 ` Christian König
2018-05-02 11:48 ` Christian König
2018-05-17 11:18 ` Andrey Grodzovsky
2018-05-17 14:48 ` Michel Dänzer
2018-05-17 15:33 ` Andrey Grodzovsky
2018-05-17 15:52 ` Michel Dänzer
2018-05-17 19:05 ` Andrey Grodzovsky
2018-05-18 8:46 ` Michel Dänzer
2018-05-18 9:42 ` Christian König
2018-05-18 14:44 ` Michel Dänzer
2018-05-18 14:50 ` Christian König
2018-05-18 15:02 ` Andrey Grodzovsky
2018-05-22 12:58 ` Christian König
2018-05-22 15:49 ` Andrey Grodzovsky
2018-05-22 16:09 ` Michel Dänzer
2018-05-22 16:30 ` Andrey Grodzovsky
2018-05-22 16:33 ` Michel Dänzer
2018-05-22 16:37 ` Andrey Grodzovsky
2018-05-01 14:35 ` Oleg Nesterov
[not found] ` <20180501143524.GA13017-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-05-23 15:08 ` Andrey Grodzovsky
2018-05-23 15:08 ` Andrey Grodzovsky
2018-04-30 15:29 ` Oleg Nesterov
2018-04-30 16:25 ` Eric W. Biederman
[not found] ` <87k1so8xv8.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-30 17:18 ` Andrey Grodzovsky
2018-04-30 17:18 ` Andrey Grodzovsky
2018-04-25 13:05 ` Oleg Nesterov
2018-04-24 15:30 ` [PATCH 3/3] drm/amdgpu: Switch to interrupted wait to recover from ring hang Andrey Grodzovsky
2018-04-24 15:30 ` Andrey Grodzovsky
2018-04-24 16:14 ` Eric W. Biederman
2018-04-24 16:14 ` Eric W. Biederman
[not found] ` <8736zkd1jz.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-24 16:38 ` Andrey Grodzovsky
2018-04-24 16:38 ` Andrey Grodzovsky
[not found] ` <1524583836-12130-4-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2018-04-24 15:52 ` Panariti, David
2018-04-24 15:52 ` Panariti, David
[not found] ` <DM5PR12MB244017F98FC732EB5DD86E0395880-2J9CzHegvk/fqmGed1UJxwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-04-24 15:58 ` Andrey Grodzovsky
2018-04-24 15:58 ` Andrey Grodzovsky
[not found] ` <b4309ea4-c1a0-5811-040b-4390ce6f297f-5C7GfCeVMHo@public.gmane.org>
2018-04-24 16:20 ` Panariti, David
2018-04-24 16:20 ` Panariti, David
2018-04-24 16:30 ` Eric W. Biederman
2018-04-24 16:30 ` Eric W. Biederman
[not found] ` <87bme8bm9g.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-25 17:17 ` Andrey Grodzovsky
2018-04-25 17:17 ` Andrey Grodzovsky
2018-04-25 20:55 ` Eric W. Biederman
2018-04-25 20:55 ` Eric W. Biederman
[not found] ` <87h8nzt39f.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-04-26 12:28 ` Andrey Grodzovsky
2018-04-26 12:28 ` Andrey Grodzovsky
2018-04-30 11:34 ` Christian König
2018-04-30 11:34 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425135552.GD7592@redhat.com \
--to=oleg@redhat.com \
--cc=Alexander.Deucher@amd.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David.Panariti@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.