All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Kevin Carli <k.carli@overkiz.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] tzdata: fix a typo
Date: Wed, 25 Apr 2018 10:01:56 -0400	[thread overview]
Message-ID: <20180425140156.GA23341@linux-uys3> (raw)
In-Reply-To: <20180425133142.10940-1-k.carli@overkiz.com>

Hi Kevin,

Thank you for this patch! A couple nitpics, however...

On Wed 2018-04-25 @ 03:31:42 PM, Kevin Carli wrote:
> Change-Id: I57f17f13aba2a2d26b9f6b72214563a86725def9

This isn't relevant to openembedded, please remove

> Signed-off-by: Kevin Carli <k.carli@overkiz.com>
> ---
>  meta/recipes-extended/tzdata/tzdata_2018c.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tzdata/tzdata_2018c.bb b/meta/recipes-extended/tzdata/tzdata_2018c.bb
> index c4014245ed..d4fee852df 100644
> --- a/meta/recipes-extended/tzdata/tzdata_2018c.bb
> +++ b/meta/recipes-extended/tzdata/tzdata_2018c.bb
> @@ -171,7 +171,7 @@ FILES_${PN} += "${datadir}/zoneinfo/Pacific/Honolulu     \
>                  ${datadir}/zoneinfo/Asia/Dubai           \
>                  ${datadir}/zoneinfo/Asia/Karachi         \
>                  ${datadir}/zoneinfo/Asia/Dhaka           \
> -                ${datadir}/zoneinfo/Asia/Bankok          \
> +                ${datadir}/zoneinfo/Asia/Bangkok         \
>                  ${datadir}/zoneinfo/Asia/Hong_Kong       \
>                  ${datadir}/zoneinfo/Asia/Tokyo           \
>                  ${datadir}/zoneinfo/Australia/Darwin     \
> -- 
> 2.14.3

I apologize if I wasn't clear in my other email. The first thing to do would
be to submit this patch against master. Master has tzdata_2018d.bb, so we'd
need a patch for that branch first. Patches for other branches (morty, I'm
guessing here) need to have the branch name in the subject line:

	https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Backporting_fixes_to_stable_releases


  reply	other threads:[~2018-04-25 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 13:31 [PATCH] tzdata: fix a typo Kevin Carli
2018-04-25 14:01 ` Trevor Woerner [this message]
2018-04-25 14:10 ` ✗ patchtest: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425140156.GA23341@linux-uys3 \
    --to=twoerner@gmail.com \
    --cc=k.carli@overkiz.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.