diff for duplicates of <20180425141507.GA4240@cisco> diff --git a/a/1.txt b/N1/1.txt index f6349e6..8d98f95 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,7 +8,7 @@ On Wed, Apr 25, 2018 at 07:36:21PM +0900, Tetsuo Handa wrote: > > >> > > > > + WARN(1, "big key algorithm changed?"); > > >> > > > >> > Please avoid using WARN() WARN_ON() etc. -> > >> > syzbot would catch it and panic() due to panic_on_warn == 1. +> > >> > syzbot would catch it and panic() due to panic_on_warn = 1. > > >> > > >> But it is really a programming bug in this case (and it seems better > > >> than BUG()...). Isn't this exactly the sort of case we want to catch? diff --git a/a/content_digest b/N1/content_digest index eb3e038..3365ffb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\0201804251936.GAG73463.HOJtFFOQSLFOVM@I-love.SAKURA.ne.jp\0" "From\0Tycho Andersen <tycho@tycho.ws>\0" "Subject\0Re: [PATCH 1/3] big key: get rid of stack array allocation\0" - "Date\0Wed, 25 Apr 2018 08:15:07 -0600\0" + "Date\0Wed, 25 Apr 2018 14:15:07 +0000\0" "To\0Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>\0" "Cc\0keescook@chromium.org" serge@hallyn.com @@ -30,7 +30,7 @@ "> > >> > > > > + WARN(1, \"big key algorithm changed?\");\n" "> > >> >\n" "> > >> > Please avoid using WARN() WARN_ON() etc.\n" - "> > >> > syzbot would catch it and panic() due to panic_on_warn == 1.\n" + "> > >> > syzbot would catch it and panic() due to panic_on_warn = 1.\n" "> > >>\n" "> > >> But it is really a programming bug in this case (and it seems better\n" "> > >> than BUG()...). Isn't this exactly the sort of case we want to catch?\n" @@ -67,4 +67,4 @@ "\n" Tycho -1bb86b66eb4cf949293cda904bee45d416c13f0bbcd6cacee7c73f1f5d268d36 +89ebd7f5de8bdbb229538c1bcc1a241eebcac7eea67f0b85a7aa4324401df247
diff --git a/a/1.txt b/N2/1.txt index f6349e6..5828935 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,7 +1,7 @@ On Wed, Apr 25, 2018 at 07:36:21PM +0900, Tetsuo Handa wrote: > Kees Cook wrote: > > On Tue, Apr 24, 2018 at 12:58 PM, Serge E. Hallyn <serge@hallyn.com> wrote: -> > > Quoting Tycho Andersen (tycho@tycho.ws): +> > > Quoting Tycho Andersen (tycho at tycho.ws): > > >> On Tue, Apr 24, 2018 at 11:46:38PM +0900, Tetsuo Handa wrote: > > >> > Tycho Andersen wrote: > > >> > > > > + if (unlikely(crypto_aead_ivsize(big_key_aead) != GCM_AES_IV_SIZE)) { @@ -44,3 +44,7 @@ But the algorithm is hard coded at the top of the file, so one check is enough. Tycho +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index eb3e038..264b429 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,26 +4,16 @@ "ref\020180424195845.GB23575@mail.hallyn.com\0" "ref\0CAGXu5j+SXCJpm9xnX1UaY0Qz2+E0qNETc+s8kwrH6hE9LLjgpw@mail.gmail.com\0" "ref\0201804251936.GAG73463.HOJtFFOQSLFOVM@I-love.SAKURA.ne.jp\0" - "From\0Tycho Andersen <tycho@tycho.ws>\0" - "Subject\0Re: [PATCH 1/3] big key: get rid of stack array allocation\0" + "From\0tycho@tycho.ws (Tycho Andersen)\0" + "Subject\0[PATCH 1/3] big key: get rid of stack array allocation\0" "Date\0Wed, 25 Apr 2018 08:15:07 -0600\0" - "To\0Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>\0" - "Cc\0keescook@chromium.org" - serge@hallyn.com - ebiggers3@gmail.com - dhowells@redhat.com - keyrings@vger.kernel.org - linux-security-module@vger.kernel.org - linux-kernel@vger.kernel.org - kernel-hardening@lists.openwall.com - jmorris@namei.org - " Jason@zx2c4.com\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Apr 25, 2018 at 07:36:21PM +0900, Tetsuo Handa wrote:\n" "> Kees Cook wrote:\n" "> > On Tue, Apr 24, 2018 at 12:58 PM, Serge E. Hallyn <serge@hallyn.com> wrote:\n" - "> > > Quoting Tycho Andersen (tycho@tycho.ws):\n" + "> > > Quoting Tycho Andersen (tycho at tycho.ws):\n" "> > >> On Tue, Apr 24, 2018 at 11:46:38PM +0900, Tetsuo Handa wrote:\n" "> > >> > Tycho Andersen wrote:\n" "> > >> > > > > + if (unlikely(crypto_aead_ivsize(big_key_aead) != GCM_AES_IV_SIZE)) {\n" @@ -65,6 +55,10 @@ "But the algorithm is hard coded at the top of the file, so one check\n" "is enough.\n" "\n" - Tycho + "Tycho\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -1bb86b66eb4cf949293cda904bee45d416c13f0bbcd6cacee7c73f1f5d268d36 +3af27374799f38d632b4f9c8a795583b5b6d2cb0e37cc260fcb65f6490bf1ed2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.