From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Ofer Heifetz <oferh@marvell.com>
Subject: Re: [PATCH 0/3] Changes in Marvell NAND controller DT parsing code
Date: Wed, 25 Apr 2018 15:20:07 +0200 [thread overview]
Message-ID: <20180425152007.0bc6d3c9@bbrezillon> (raw)
In-Reply-To: <20180425125331.8234-1-miquel.raynal@bootlin.com>
Hi Miquel,
On Wed, 25 Apr 2018 14:53:28 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hello,
>
> At first I just wanted to send a fix to avoid timeouts at boot time when
> using old bindings (harmless):
>
> [ 1.367460] marvell-nfc f2720000.nand: Timeout on CMDD (NDSR: 0x00000080)
> [ 1.474292] marvell-nfc f2720000.nand: Timeout on CMDD (NDSR: 0x00000280)
>
> This is addressed in the first patch and comes from the DT parsing of
> the number of Chip Select lines.
>
> While working on it, Boris pointed another issue with the 'num-cs'
> property (legacy bindings) in some code that should not exist anyway. I
> removed that code in patch 2.
>
> Finally, while writing the second patch, I discovered a better way to handle
> the code besides (that handles the CS count for new bindings) by using
> of_property_count_elems_of_size(). Patch 3 makes the switch.
>
> Regards,
> Miquèl
>
>
> Miquel Raynal (3):
> mtd: rawnand: marvell: fix the chip-select DT parsing logic
> mtd: rawnand: marvell: fix CS pin count with old bindings
> mtd: rawnand: marvell: use OF helper to read a property element count
I usually ask people to properly split their changes, but this time I'd
prefer to have everything in a single patch so that I can queue it to
the fixes branch.
Regards,
Boris
next prev parent reply other threads:[~2018-04-25 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 12:53 [PATCH 0/3] Changes in Marvell NAND controller DT parsing code Miquel Raynal
2018-04-25 12:53 ` [PATCH 1/3] mtd: rawnand: marvell: fix the chip-select DT parsing logic Miquel Raynal
2018-04-25 12:53 ` [PATCH 2/3] mtd: rawnand: marvell: fix CS pin count with old bindings Miquel Raynal
2018-04-25 12:53 ` [PATCH 3/3] mtd: rawnand: marvell: use OF helper to read a property element count Miquel Raynal
2018-04-25 13:20 ` Boris Brezillon [this message]
2018-04-25 14:13 ` [PATCH 0/3] Changes in Marvell NAND controller DT parsing code Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425152007.0bc6d3c9@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.