From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check Date: Wed, 25 Apr 2018 18:27:05 +0200 Message-ID: <20180425162705.GU4957@6wind.com> References: <20180425014929.72014-1-qi.z.zhang@intel.com> <20180425133816.198161-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org To: Qi Zhang Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 84E2A6D81 for ; Wed, 25 Apr 2018 18:27:20 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id j4so8199586wme.1 for ; Wed, 25 Apr 2018 09:27:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180425133816.198161-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: > After add RSS hash offload check, default rss_hf will fail on > devices that not support all bits, the patch take rss_hf as > a suggest value and only set bits that device supported base on > rte_eth_dev_get_info, also rss_hf will only be updated when new > rss offload is successfully updated on all ports by > "port config all rss [!default]" command. > > Fixes: 586ac442be96 ("ethdev: add supported hash function check") > Fixes: 8c1f4aff92a6 ("app/testpmd: new parameter for port config all RSS command") > Signed-off-by: Qi Zhang Although this approach prevents updating rss_hf if at least one port doesn't support RSS configuration (i.e. it can't be used to update defaults for subsequent flow rules on mlx4), I confirm it does fix the startup issue, therefore: Tested-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND