From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandru Gagniuc Subject: [RFC PATCH v3 3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" Date: Wed, 25 Apr 2018 15:39:51 -0500 Message-ID: <20180425203957.18224-4-mr.nuke.me@gmail.com> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180425203957.18224-1-mr.nuke.me@gmail.com> Return-path: In-Reply-To: <20180425203957.18224-1-mr.nuke.me@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org Cc: Alexandru Gagniuc , "Rafael J. Wysocki" , Len Brown , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org There seems to be a culture amongst BIOS teams to want to crash the OS when an error can't be handled in firmware. Marking GHES errors as "fatal" is a very common way to do this. However, a number of errors reported by GHES may be fatal in the sense a device or link is lost, but are not fatal to the system. When there is a disagreement with firmware about the handleability of an error, print a warning message. Signed-off-by: Alexandru Gagniuc --- drivers/acpi/apei/ghes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 8ccb9cc10fc8..34d0da692dd0 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -539,6 +539,12 @@ static void ghes_do_proc(struct ghes *ghes, sec_sev, err, gdata->error_data_length); } + + } + + if ((sev >= GHES_SEV_PANIC) && (ghes_actual_severity(ghes) < sev)) { + pr_warn("FIRMWARE BUG: Firmware sent fatal error that we were able to correct"); + pr_warn("BROKEN FIRMWARE: Complain to your hardware vendor"); } } -- 2.14.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v3,3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" From: Alexandru Gagniuc Message-Id: <20180425203957.18224-4-mr.nuke.me@gmail.com> Date: Wed, 25 Apr 2018 15:39:51 -0500 To: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org Cc: Alexandru Gagniuc , "Rafael J. Wysocki" , Len Brown , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-ID: VGhlcmUgc2VlbXMgdG8gYmUgYSBjdWx0dXJlIGFtb25nc3QgQklPUyB0ZWFtcyB0byB3YW50IHRv IGNyYXNoIHRoZQpPUyB3aGVuIGFuIGVycm9yIGNhbid0IGJlIGhhbmRsZWQgaW4gZmlybXdhcmUu IE1hcmtpbmcgR0hFUyBlcnJvcnMgYXMKImZhdGFsIiBpcyBhIHZlcnkgY29tbW9uIHdheSB0byBk byB0aGlzLgoKSG93ZXZlciwgYSBudW1iZXIgb2YgZXJyb3JzIHJlcG9ydGVkIGJ5IEdIRVMgbWF5 IGJlIGZhdGFsIGluIHRoZSBzZW5zZQphIGRldmljZSBvciBsaW5rIGlzIGxvc3QsIGJ1dCBhcmUg bm90IGZhdGFsIHRvIHRoZSBzeXN0ZW0uIFdoZW4gdGhlcmUKaXMgYSBkaXNhZ3JlZW1lbnQgd2l0 aCBmaXJtd2FyZSBhYm91dCB0aGUgaGFuZGxlYWJpbGl0eSBvZiBhbiBlcnJvciwKcHJpbnQgYSB3 YXJuaW5nIG1lc3NhZ2UuCgpTaWduZWQtb2ZmLWJ5OiBBbGV4YW5kcnUgR2Fnbml1YyA8bXIubnVr ZS5tZUBnbWFpbC5jb20+Ci0tLQogZHJpdmVycy9hY3BpL2FwZWkvZ2hlcy5jIHwgNiArKysrKysK IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2Fj cGkvYXBlaS9naGVzLmMgYi9kcml2ZXJzL2FjcGkvYXBlaS9naGVzLmMKaW5kZXggOGNjYjljYzEw ZmM4Li4zNGQwZGE2OTJkZDAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvYWNwaS9hcGVpL2doZXMuYwor KysgYi9kcml2ZXJzL2FjcGkvYXBlaS9naGVzLmMKQEAgLTUzOSw2ICs1MzksMTIgQEAgc3RhdGlj IHZvaWQgZ2hlc19kb19wcm9jKHN0cnVjdCBnaGVzICpnaGVzLAogCQkJCQkgICAgICAgc2VjX3Nl diwgZXJyLAogCQkJCQkgICAgICAgZ2RhdGEtPmVycm9yX2RhdGFfbGVuZ3RoKTsKIAkJfQorCisJ fQorCisJaWYgKChzZXYgPj0gR0hFU19TRVZfUEFOSUMpICYmIChnaGVzX2FjdHVhbF9zZXZlcml0 eShnaGVzKSA8IHNldikpIHsKKwkJcHJfd2FybigiRklSTVdBUkUgQlVHOiBGaXJtd2FyZSBzZW50 IGZhdGFsIGVycm9yIHRoYXQgd2Ugd2VyZSBhYmxlIHRvIGNvcnJlY3QiKTsKKwkJcHJfd2Fybigi QlJPS0VOIEZJUk1XQVJFOiBDb21wbGFpbiB0byB5b3VyIGhhcmR3YXJlIHZlbmRvciIpOwogCX0K IH0KIAo=