From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/3] drm/i915/dp: Fix sink-crc reads. Date: Wed, 25 Apr 2018 16:19:17 -0700 Message-ID: <20180425231914.GA3617@intel.com> References: <20180424025659.23659-2-dhinakaran.pandiyan@intel.com> <20180425215757.2316-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF5856E284 for ; Wed, 25 Apr 2018 23:19:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180425215757.2316-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDI6NTc6NTdQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBTaW5rIGNyYyBpcyBjYWxjdWxhdGVkIGJ5IHRoZSBzaW5rIGZvciBzdGF0 aWMgZnJhbWVzIGlycmVzcGVjdGl2ZSBvZgo+IHdoYXQgdGhlIGRyaXZlciBzZXRzIGluIFRFU1Rf U0lOS19TVEFSVCBkcGNkLiBTaW5jZSBQU1IgaXMgdGhlIG9ubHkgdXNlCj4gY2FzZSBmb3Igc2lu ayBjcmMsIHdlIGRvbid0IHJlYWxseSBuZWVkIHRoZSBzaW5rX2NyY197c3RhcnQsIHN0b3B9IGNv ZGUuCj4gCj4gVGhlIHNlY29uZCBwcm9ibGVtIHdpdGggdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRp b24gaXMgdmJsYW5rIHdhaXRzLgo+IEVuYWJsaW5nIHZibGFuayBpbnRlcnJ1cHRzIHRyaWdnZXJz IFBTUiBleGl0LCB3aGljaCBtZWFucyB3ZSBhcmVuJ3QKPiByZWFsbHkgcmVhZGluZyB0aGUgY29y cmVjdCBDUkMgdmFsdWVzIGZvciBQU1IgdGVzdHMuIHZibGFuayB3YWl0cyBhcmUKPiByZXBsYWNl ZCBieSBkZWxheXMuCj4gCj4gV2l0aCB0aGUgY2hhbmdlcyBtYWRlIGluIHRoaXMgcGF0Y2gsIHNp bmsgQ1JDIGlzIGF2YWlsYWJsZSBvbmx5IGZvcgo+IHN0YXRpYyBmcmFtZXMuIEkgaGF2ZSB0ZXN0 ZWQgdGhpcyBvbiBhIFNLTCBsYXB0b3Agd2l0aCBQU1IgcGFuZWwuCj4gCj4gdjI6IFVzZSByZWZy ZXNoIHJhdGUgdG8gY2FsY3VsYXRlIGZyYW1lIHRpbWUuCgpDb29sISA6KQoKPiAKPiBTaWduZWQt b2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNv bT4KClJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8ICAgNCArLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICB8IDExNSArKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2Lmgg ICAgfCAgIDMgKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMDQgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRleCAyZjA1 ZjUyNjJiYmEuLmU0YmE2NTI3YzE2ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jCj4gQEAgLTI3NDksNiArMjc0OSw3IEBAIHN0YXRpYyBpbnQgaTkxNV9zaW5rX2NyYyhzdHJ1 Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAkJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ ICAJCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpzdGF0ZTsKPiAgCQlzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCQlpbnQgdnJlZnJlc2g7Cj4gIAo+ICAJCWlmIChj b25uZWN0b3ItPmJhc2UuY29ubmVjdG9yX3R5cGUgIT0gRFJNX01PREVfQ09OTkVDVE9SX2VEUCkK PiAgCQkJY29udGludWU7Cj4gQEAgLTI3ODMsOCArMjc4NCw5IEBAIHN0YXRpYyBpbnQgaTkxNV9z aW5rX2NyYyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAkJfQo+ICAKPiAgCQlp bnRlbF9kcCA9IGVuY190b19pbnRlbF9kcChzdGF0ZS0+YmVzdF9lbmNvZGVyKTsKPiArCQl2cmVm cmVzaCA9IGNydGNfc3RhdGUtPmJhc2UuYWRqdXN0ZWRfbW9kZS52cmVmcmVzaDsKPiAgCj4gLQkJ cmV0ID0gaW50ZWxfZHBfc2lua19jcmMoaW50ZWxfZHAsIGNydGNfc3RhdGUsIGNyYyk7Cj4gKwkJ cmV0ID0gaW50ZWxfZHBfc2lua19jcmMoaW50ZWxfZHAsIHZyZWZyZXNoLCBjcmMpOwo+ICAJCWlm IChyZXQpCj4gIAkJCWdvdG8gZXJyOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRl eCA3ZGNjODc0YjdkOGYuLjNhYjNmODJlMzNmNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu Ywo+IEBAIC0zODc2LDMyICszODc2LDE5IEBAIGludGVsX2RwX2NvbmZpZ3VyZV9tc3Qoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQkJCQlpbnRlbF9kcC0+aXNfbXN0KTsKPiAgfQo+ICAK PiAtc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAsCj4gLQkJCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLCBib29s IGRpc2FibGVfd2EpCj4gK2ludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwLCBpbnQgdnJlZnJlc2gsIHU4ICpjcmMpCj4gIHsKPiAtCXN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+IC0Jc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkaWdfcG9ydC0+YmFzZS5iYXNl LmRldik7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMo Y3J0Y19zdGF0ZS0+YmFzZS5jcnRjKTsKPiAtCXU4IGJ1ZjsKPiAtCWludCByZXQgPSAwOwo+IC0J aW50IGNvdW50ID0gMDsKPiAtCWludCBhdHRlbXB0cyA9IDEwOwo+ICsJaW50IGNvdW50ID0gMCwg cmV0ID0gMCwgYXR0ZW1wdHM7Cj4gKwlpbnQgaGFsZl9mcmFtZV91cyA9IERJVl9ST1VORF9VUCgx MDAwMDAwLzIsIHZyZWZyZXNoKTsKPiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVs X2RwLT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygi U2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZCBwcm9wZXJseVxuIik7Cj4gLQkJcmV0ID0gLUVJ TzsKPiAtCQlnb3RvIG91dDsKPiAtCX0KPiArCWZvciAoYXR0ZW1wdHMgPSAwOyBhdHRlbXB0cyA8 IDMgJiYgY291bnQgPT0gMDsgYXR0ZW1wdHMrKykgewo+ICsJCXU4IGJ1ZjsKPiAgCj4gLQlpZiAo ZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssCj4gLQkJCSAg ICAgICBidWYgJiB+RFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApIHsKPiAtCQlEUk1fREVCVUdfS01T KCJTaW5rIENSQyBjb3VsZG4ndCBiZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsKPiAtCQlyZXQgPSAt RUlPOwo+IC0JCWdvdG8gb3V0Owo+IC0JfQo+IC0KPiAtCWRvIHsKPiAtCQlpbnRlbF93YWl0X2Zv cl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+ICsJCS8qIFdhaXQgZm9yIGFw cHJveGltYXRlbHkgaGFsZiBhIGZyYW1lLCB3ZSBjYW5ub3Qgd2FpdCBmb3IgYQo+ICsJCSAqIHZi bGFuayBpbnRlcnJ1cHQgYXMgaXQgdHJpZ2dlcnMgUFNSIGV4aXQuCj4gKwkJICovCj4gKwkJaWYg KGF0dGVtcHRzKQo+ICsJCQl1c2xlZXBfcmFuZ2UoaGFsZl9mcmFtZV91cywgaGFsZl9mcmFtZV91 cyArIDEwMCk7Cj4gIAo+ICAJCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwK PiAgCQkJCSAgICAgIERQX1RFU1RfU0lOS19NSVNDLCAmYnVmKSA8IDApIHsKPiBAQCAtMzkwOSw5 MyArMzg5NiwxOSBAQCBzdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3JjX3N0b3Aoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCwKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+ICAJCWNvdW50ID0gYnVm ICYgRFBfVEVTVF9DT1VOVF9NQVNLOwo+IC0JfSB3aGlsZSAoLS1hdHRlbXB0cyAmJiBjb3VudCk7 Cj4gLQo+IC0JaWYgKGF0dGVtcHRzID09IDApIHsKPiAtCQlEUk1fREVCVUdfS01TKCJUSU1FT1VU OiBTaW5rIENSQyBjb3VudGVyIGlzIG5vdCB6ZXJvZWQgYWZ0ZXIgY2FsY3VsYXRpb24gaXMgc3Rv cHBlZFxuIik7Cj4gLQkJcmV0ID0gLUVUSU1FRE9VVDsKPiAgCX0KPiAgCj4gLSBvdXQ6Cj4gLQlp ZiAoZGlzYWJsZV93YSkKPiAtCQloc3dfZW5hYmxlX2lwcyhjcnRjX3N0YXRlKTsKPiAtCXJldHVy biByZXQ7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQgaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAtCQkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+IC17Cj4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9y dCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+IC0Jc3RydWN0 IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2Uu Y3J0Yyk7Cj4gLQl1OCBidWY7Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCWlmIChkcm1fZHBfZHBjZF9y ZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LX01JU0MsICZidWYpIDwgMCkKPiAtCQly ZXR1cm4gLUVJTzsKPiAtCj4gLQlpZiAoIShidWYgJiBEUF9URVNUX0NSQ19TVVBQT1JURUQpKQo+ IC0JCXJldHVybiAtRU5PVFRZOwo+IC0KPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxf ZHAtPmF1eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApCj4gLQkJcmV0dXJuIC1FSU87Cj4gLQo+ IC0JaWYgKGJ1ZiAmIERQX1RFU1RfU0lOS19TVEFSVCkgewo+IC0JCXJldCA9IGludGVsX2RwX3Np bmtfY3JjX3N0b3AoaW50ZWxfZHAsIGNydGNfc3RhdGUsIGZhbHNlKTsKPiAtCQlpZiAocmV0KQo+ IC0JCQlyZXR1cm4gcmV0Owo+IC0JfQo+IC0KPiAtCWhzd19kaXNhYmxlX2lwcyhjcnRjX3N0YXRl KTsKPiAtCj4gLQlpZiAoZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNU X1NJTkssCj4gLQkJCSAgICAgICBidWYgfCBEUF9URVNUX1NJTktfU1RBUlQpIDwgMCkgewo+IC0J CWhzd19lbmFibGVfaXBzKGNydGNfc3RhdGUpOwo+IC0JCXJldHVybiAtRUlPOwo+IC0JfQo+IC0K PiAtCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4g LQlyZXR1cm4gMDsKPiAtfQo+IC0KPiAtaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLCB1OCAq Y3JjKQo+IC17Cj4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3Rv X2RpZ19wb3J0KGludGVsX2RwKTsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+IC0Jc3RydWN0IGludGVsX2Ny dGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4g LQl1OCBidWY7Cj4gLQlpbnQgY291bnQsIHJldDsKPiAtCWludCBhdHRlbXB0cyA9IDY7Cj4gLQo+ IC0JcmV0ID0gaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoaW50ZWxfZHAsIGNydGNfc3RhdGUpOwo+ IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAtCWRvIHsKPiAtCQlpbnRlbF93YWl0 X2Zvcl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+IC0KPiAtCQlpZiAoZHJt X2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gLQkJCQkgICAgICBEUF9URVNUX1NJTktf TUlTQywgJmJ1ZikgPCAwKSB7Cj4gLQkJCXJldCA9IC1FSU87Cj4gLQkJCWdvdG8gc3RvcDsKPiAt CQl9Cj4gLQkJY291bnQgPSBidWYgJiBEUF9URVNUX0NPVU5UX01BU0s7Cj4gLQo+IC0JfSB3aGls ZSAoLS1hdHRlbXB0cyAmJiBjb3VudCA9PSAwKTsKPiAtCj4gLQlpZiAoYXR0ZW1wdHMgPT0gMCkg ewo+IC0JCURSTV9FUlJPUigiUGFuZWwgaXMgdW5hYmxlIHRvIGNhbGN1bGF0ZSBhbnkgQ1JDIGFm dGVyIDYgdmJsYW5rc1xuIik7Cj4gKwlpZiAoYXR0ZW1wdHMgPT0gMykgewo+ICAJCXJldCA9IC1F VElNRURPVVQ7Cj4gLQkJZ290byBzdG9wOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgCWlm IChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMs IDYpICE9IDYpIHsKPiAgCQlyZXQgPSAtRUlPOwo+IC0JCWdvdG8gc3RvcDsKPiArCQlnb3RvIG91 dDsKPiAgCX0KPiAgCj4gLXN0b3A6Cj4gLQlpbnRlbF9kcF9zaW5rX2NyY19zdG9wKGludGVsX2Rw LCBjcnRjX3N0YXRlLCB0cnVlKTsKPiArb3V0Ogo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDQ0ZWQyNDhmMWZlOS4uNDgwNzNiZThhMDIz IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTY0NCw4ICsxNjQ0LDcgQEAg dm9pZCBpbnRlbF9kcF9zaW5rX2RwbXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgaW50IG1v ZGUpOwo+ICB2b2lkIGludGVsX2RwX2VuY29kZXJfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICpl bmNvZGVyKTsKPiAgdm9pZCBpbnRlbF9kcF9lbmNvZGVyX3N1c3BlbmQoc3RydWN0IGludGVsX2Vu Y29kZXIgKmludGVsX2VuY29kZXIpOwo+ICB2b2lkIGludGVsX2RwX2VuY29kZXJfZGVzdHJveShz dHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+IC1pbnQgaW50ZWxfZHBfc2lua19jcmMoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAtCQkgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqY3J0Y19zdGF0ZSwgdTggKmNyYyk7Cj4gK2ludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwLCBpbnQgdnJlZnJlc2gsIHU4ICpjcmMpOwo+ICBib29sIGludGVs X2RwX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkg ICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCQkJICAgICBzdHJ1 Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSk7Cj4gLS0gCj4gMi4xNC4xCj4gCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=