From: Christoph Hellwig <hch@infradead.org>
To: dsterba@suse.cz, Alexey Dobriyan <adobriyan@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: use #pragma once
Date: Thu, 26 Apr 2018 03:33:04 -0700 [thread overview]
Message-ID: <20180426103304.GA4639@infradead.org> (raw)
In-Reply-To: <20180426102629.scwtdeijbo3342gp@twin.jikos.cz>
On Thu, Apr 26, 2018 at 12:26:29PM +0200, David Sterba wrote:
> There are about 20k header files, none of them has #pragma once.
> Updating that will bring many unnesessry git commits.
>
> I doubt that one more define in preprocessor tables is a problem we
> should fix. The LOC argument also does not sound very convincing. The
> include protection is at the top of the file, not mixed among other
> code. Replacing 2-3 lines with one will be barely noticeable.
Let's put it another way: does this make any noticable difference
for compile times?
next prev parent reply other threads:[~2018-04-26 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:35 [PATCH] proc: use #pragma once Alexey Dobriyan
2018-04-24 13:54 ` Christoph Hellwig
2018-04-25 20:55 ` Alexey Dobriyan
2018-04-26 10:26 ` David Sterba
2018-04-26 10:33 ` Christoph Hellwig [this message]
2018-04-26 19:25 ` Alexey Dobriyan
2018-04-26 19:24 ` Alexey Dobriyan
2018-05-01 22:13 ` Andrew Morton
2018-05-03 22:14 ` Rasmus Villemoes
2018-05-03 22:42 ` Al Viro
2018-05-03 23:23 ` Rasmus Villemoes
2018-05-04 2:58 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426103304.GA4639@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.