From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC] drm/i915: Rework "Potential atomic update error" to handle PSR exit Date: Thu, 26 Apr 2018 16:41:57 +0300 Message-ID: <20180426134157.GL23723@intel.com> References: <20180426021009.178880-1-tarun.vyas@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36D836E6DA for ; Thu, 26 Apr 2018 13:42:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180426021009.178880-1-tarun.vyas@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: tarun.vyas@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDc6MTA6MDlQTSAtMDcwMCwgdGFydW4udnlhc0BpbnRl bC5jb20gd3JvdGU6Cj4gRnJvbTogVGFydW4gPHRhcnVuLnZ5YXNAaW50ZWwuY29tPgo+IAo+IFRo ZSBEaXNwbGF5IHNjYW5saW5lIGNvdW50ZXIgZnJlZXplcyBvbiBQU1IgZW50cnkuIEluc2lkZQo+ IGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0LCBvbmNlIFZibGFuayBpbnRlcnJ1cHRzIGFyZSBlbmFi bGVkLCB3ZSBzdGFydAo+IGV4aXRpbmcgUFNSLCBidXQgYnkgdGhlIHRpbWUgdGhlIHNjYW5saW5l IGNvdW50ZXIgaXMgcmVhZCwgd2UgbWF5IG5vdAo+IGhhdmUgY29tcGxldGVseSBleGl0ZWQgUFNS IHdoaWNoIGxlYWRzIHVzIHRvIHNjaGVkdWxlIG91dCBhbmQgY2hlY2sgYmFjawo+IGxhdGVyLgo+ IE9uIENocm9tZU9TLTQuNCBrZXJuZWwsIHdoaWNoIGlzIGZhaXJseSB1cC10by1kYXRlIHcuci50 IGRybS9pOTE1IGJ1dAo+IGxhZ3Mgdy5yLnQgY29yZSBrZXJuZWwgY29kZSwgaG90IHBsdWdnaW5n IGFuIGV4dGVybmFsIGRpc3BsYXkgdHJpZ2dlcnMKPiB0b25zIG9mICJwb3RlbnRpYWwgYXRvbWlj IHVwZGF0ZSBlcnJvcnMiIGluIHRoZSBkbWVzZywgb24gKnBpcGUgQSouIEEKPiBjbG9zZXIgYW5h bHlzaXMgcmV2ZWFscyB0aGF0IHdlIHRyeSB0byByZWFkIHRoZSBzY2FubGluZSAzIHRpbWVzIGFu ZAo+IGV2ZW50dWFsbHkgdGltZW91dCwgYi9jIFBTUiBoYXNuJ3QgZXhpdGVkIGZ1bGx5IGxlYWRp bmcgdG8gYSBQSVBFRFNMIHN0dWNrIEAKPiAxNTk5Lgo+IFRoaXMgaXNzdWUgaXMgbm90IHNlZW4g b24gdXBzdHJlYW0ga2VybmVscywgYi9jIGZvciAqc29tZSogcmVhc29uIHdlCj4gbG9vcCBpbnNp ZGUgaW50ZWxfcGlwZV91cGRhdGUgc3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGluIHRoaXMgY2Fz ZSBpcwo+IG1vcmUgdGhhbiBlbm91Z2ggdG8gZXhpdCBQU1IgZnVsbHksIGhlbmNlIGFuICp1bnN0 dWNrKiBQSVBFRFNMIGNvdW50ZXIsCj4gaGVuY2Ugbm8gZXJyb3IuIE9uIHRoZSBvdGhlciBoYW5k LCB0aGUgQ2hyb21lT1Mga2VybmVsIHNwZW5kcyB+MS4xIG1zZWMKPiBsb29waW5nIGluc2lkZSBp bnRlbF9waXBlX3VwZGF0ZV9zdGFydCBhbmQgaGVuY2UgZXJyb3JzIG91dCBiL2MgdGhlCj4gc291 cmNlIGlzIHN0aWxsIGluIFBTUi4KPiAKPiBJZiBQU1IgaXMgZW5hYmxlZCwgdGhlbiB3ZSBzaG91 bGQgKndhaXQqIGZvciAgdGhlIFBTUgo+IHN0YXRlIHRvIG1vdmUgdG8gSURMRSBiZWZvcmUgcmUt cmVhZGluZyB0aGUgUElQRURTTCBzbyBhcyB0byBhdm9pZCBib2d1cwo+IGFuZCBhbm5veWluZyAi cG90ZW50aWFsIGF0b21pYyB1cGRhdGUgZXJyb3IiIG1lc3NhZ2VzLgo+IAo+IFAuUzogVGhpcyBz Y2VuYXJpbyBhcHBsaWVzIHRvIGEgY29uZmlndXJhdGlvbiB3aXRoIGFuIGFkZGl0aW9uYWwgcGlw ZSwKPiBhcyBvZiBub3cuCj4gCj4gU2lnbmVkLW9mZi1ieTogVGFydW4gPHRhcnVuLnZ5YXNAaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDE5 ICsrKysrKysrKysrKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBpbmRl eCBhYTFkZmFhNjkyYjkuLjc3ZGQzYjkzNjEzMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCj4gQEAgLTkyLDExICs5MiwxMyBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0 YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYp Owo+ICAJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPSAmbmV3 X2NydGNfc3RhdGUtPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiAgCWxvbmcgdGltZW91dCA9IG1zZWNz X3RvX2ppZmZpZXNfdGltZW91dCgxKTsKPiAtCWludCBzY2FubGluZSwgbWluLCBtYXgsIHZibGFu a19zdGFydDsKPiArCWludCBzY2FubGluZSwgbWluLCBtYXgsIHZibGFua19zdGFydCwgb2xkX3Nj YW5saW5lLCBuZXdfc2NhbmxpbmU7Cj4gKwlib29sIHJldHJpZWQgPSBmYWxzZTsKPiAgCXdhaXRf cXVldWVfaGVhZF90ICp3cSA9IGRybV9jcnRjX3ZibGFua193YWl0cXVldWUoJmNydGMtPmJhc2Up Owo+ICAJYm9vbCBuZWVkX3Zsdl9kc2lfd2EgPSAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwg SVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpICYmCj4gIAkJaW50ZWxfY3J0Y19oYXNfdHlwZShuZXdf Y3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX0RTSSk7Cj4gIAlERUZJTkVfV0FJVCh3YWl0KTsKPiAr CW9sZF9zY2FubGluZSA9IG5ld19zY2FubGluZSA9IC0xOwo+ICAKPiAgCXZibGFua19zdGFydCA9 IGFkanVzdGVkX21vZGUtPmNydGNfdmJsYW5rX3N0YXJ0Owo+ICAJaWYgKGFkanVzdGVkX21vZGUt PmZsYWdzICYgRFJNX01PREVfRkxBR19JTlRFUkxBQ0UpCj4gQEAgLTEyNiwxNSArMTI4LDI0IEBA IHZvaWQgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKm5ld19jcnRjX3N0YXRlKQo+ICAJCSAqIHJlYWQgdGhlIHNjYW5saW5lLgo+ICAJCSAqLwo+ ICAJCXByZXBhcmVfdG9fd2FpdCh3cSwgJndhaXQsIFRBU0tfVU5JTlRFUlJVUFRJQkxFKTsKPiAt Cj4gK3JldHJ5Ogo+ICAJCXNjYW5saW5lID0gaW50ZWxfZ2V0X2NydGNfc2NhbmxpbmUoY3J0Yyk7 Cj4gKwkJb2xkX3NjYW5saW5lID0gbmV3X3NjYW5saW5lLCBuZXdfc2NhbmxpbmUgPSBzY2FubGlu ZTsKPiArCj4gIAkJaWYgKHNjYW5saW5lIDwgbWluIHx8IHNjYW5saW5lID4gbWF4KQo+ICAJCQli cmVhazsKPiAgCj4gIAkJaWYgKHRpbWVvdXQgPD0gMCkgewo+IC0JCQlEUk1fRVJST1IoIlBvdGVu dGlhbCBhdG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwKPiArCQkJaWYoIWk5MTUu ZW5hYmxlX3BzciB8fCByZXRyaWVkKSB7Cj4gKwkJCQlEUk1fRVJST1IoIlBvdGVudGlhbCBhdG9t aWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwKPiAgCQkJCSAgcGlwZV9uYW1lKGNydGMt PnBpcGUpKTsKPiAtCQkJYnJlYWs7Cj4gKwkJCQlicmVhazsKPiArCQkJfQo+ICsJCQllbHNlIGlm KG9sZF9zY2FubGluZSA9PSBuZXdfc2NhbmxpbmUgJiYgIXJldHJpZWQpIHsKPiArCQkJCXJldHJp ZWQgPSB0cnVlOwo+ICsJCQkJaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIEVEUF9Q U1JfU1RBVFVTX0NUTCwgRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSywgRURQX1BTUl9TVEFUVVNf U1RBVEVfSURMRSwgMTApOwoKV2hhdCdzIHRoZSBwb2ludCBvZiBvYmZ1c2NhdGluZyB0aGUgbG9v cCB3aXRoIHRoaXMgc3R1ZmY/Ckp1c3Qgd2FpdCBmb3IgdGhlIFBTUiBleGl0IGJlZm9yZSB3ZSBl dmVuIGVudGVyIHRoZSBsb29wPwoKPiArCQkJCWdvdG8gcmV0cnk7Cj4gKwkJCX0KPiAgCQl9Cj4g IAo+ICAJCWxvY2FsX2lycV9lbmFibGUoKTsKPiAtLSAKPiAyLjEzLjUKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==