From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/2] drm/panel: rm67191: Add support for new bus formats Date: Thu, 26 Apr 2018 16:56:11 +0200 Message-ID: <20180426145611.GE31888@ulmo> References: <1522751401-3381-1-git-send-email-robert.chiras@nxp.com> <1522751401-3381-3-git-send-email-robert.chiras@nxp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0775358040==" Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id E52A66E6E1 for ; Thu, 26 Apr 2018 14:56:14 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id f6so13521304wmc.4 for ; Thu, 26 Apr 2018 07:56:14 -0700 (PDT) In-Reply-To: <1522751401-3381-3-git-send-email-robert.chiras@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robert Chiras Cc: linux-imx@nxp.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0775358040== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="//IivP0gvsAy3Can" Content-Disposition: inline --//IivP0gvsAy3Can Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 03, 2018 at 01:30:01PM +0300, Robert Chiras wrote: > From: Mirela Rabulea >=20 > Do not hardcode pixel_format to 0x77 but calculate it from dsi->format. > Report all the supported bus formats in get_modes: > MEDIA_BUS_FMT_RGB888_1X24 > MEDIA_BUS_FMT_RGB666_1X18 > MEDIA_BUS_FMT_RGB565_1X16 > Change pixelclock from 120 to 132 MHz, or 16 bpp formats will not work. >=20 > Signed-off-by: Mirela Rabulea > --- > drivers/gpu/drm/panel/panel-raydium-rm67191.c | 33 +++++++++++++++++++++= ++---- > 1 file changed, 28 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67191.c b/drivers/gpu/= drm/panel/panel-raydium-rm67191.c > index 07b0bd4..6331fef 100644 > --- a/drivers/gpu/drm/panel/panel-raydium-rm67191.c > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > @@ -178,6 +178,12 @@ static const cmd_set_table manufacturer_cmd_set[] = =3D { > {0x51, 0x04}, > }; > =20 > +static const u32 rad_bus_formats[] =3D { > + MEDIA_BUS_FMT_RGB888_1X24, > + MEDIA_BUS_FMT_RGB666_1X18, > + MEDIA_BUS_FMT_RGB565_1X16, > +}; > + > struct rad_panel { > struct drm_panel base; > struct mipi_dsi_device *dsi; > @@ -215,11 +221,27 @@ static int rad_panel_push_cmd_list(struct mipi_dsi_= device *dsi) > return ret; > }; > =20 > +static int color_format_from_dsi_format(enum mipi_dsi_pixel_format forma= t) > +{ > + switch (format) { > + case MIPI_DSI_FMT_RGB565: > + return 0x55; > + case MIPI_DSI_FMT_RGB666: > + case MIPI_DSI_FMT_RGB666_PACKED: > + return 0x66; > + case MIPI_DSI_FMT_RGB888: > + return 0x77; > + default: > + return 0x77; /* for backward compatibility */ > + } > +}; > + > static int rad_panel_prepare(struct drm_panel *panel) > { > struct rad_panel *rad =3D to_rad_panel(panel); > struct mipi_dsi_device *dsi =3D rad->dsi; > struct device *dev =3D &dsi->dev; > + int color_format =3D color_format_from_dsi_format(dsi->format); > int ret; > =20 > if (rad->prepared) > @@ -276,8 +298,10 @@ static int rad_panel_prepare(struct drm_panel *panel) > DRM_DEV_ERROR(dev, "Failed to set tear scanline (%d)\n", ret); > goto fail; > } > - /* Set pixel format to RGB888 */ > - ret =3D mipi_dsi_dcs_set_pixel_format(dsi, 0x77); > + /* Set pixel format */ > + ret =3D mipi_dsi_dcs_set_pixel_format(dsi, color_format); > + DRM_DEV_DEBUG_DRIVER(dev, "Interface color format set to 0x%x\n", > + color_format); > if (ret < 0) { > DRM_DEV_ERROR(dev, "Failed to set pixel format (%d)\n", ret); > goto fail; > @@ -393,7 +417,6 @@ static int rad_panel_get_modes(struct drm_panel *pane= l) > struct device *dev =3D &rad->dsi->dev; > struct drm_connector *connector =3D panel->connector; > struct drm_display_mode *mode; > - u32 bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; > u32 *bus_flags =3D &connector->display_info.bus_flags; > int ret; > =20 > @@ -420,7 +443,7 @@ static int rad_panel_get_modes(struct drm_panel *pane= l) > *bus_flags |=3D DRM_BUS_FLAG_PIXDATA_POSEDGE; > =20 > ret =3D drm_display_info_set_bus_formats(&connector->display_info, > - &bus_format, 1); > + rad_bus_formats, ARRAY_SIZE(rad_bus_formats)); > if (ret) > return ret; > =20 > @@ -492,7 +515,7 @@ static const struct drm_panel_funcs rad_panel_funcs = =3D { > * to 132MHz (60Hz refresh rate) > */ > static const struct display_timing rad_default_timing =3D { > - .pixelclock =3D { 66000000, 120000000, 132000000 }, > + .pixelclock =3D { 66000000, 132000000, 132000000 }, This seems like a fix that should be squashed into patch 1. Thierry --//IivP0gvsAy3Can Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlrh6IsACgkQ3SOs138+ s6H8gA/+KHFkVmYMqHLtjoQUT2+BZc3FoBIe8G7jWrqLrWTI9wNXNfKszDEvs9tO 6er1snuSHntU3GTHSC6YzP676DZWoeWQvCKnYeAZoZ7q7ahkP1Duyz3//dkoosFH /JjeOqnNH6GNorxOhP6Pp9fxi8yoIGk0iUDn3idQiEsn40O/ZOEpa9w0+M5p83CG MYM37xt0hCc7YsNxoANlGhWOxFdT/Rx3Q8auHogKXGmkQuUAo4ieYWbwWZIe6ACR zmCKs4p4WM3FW8LROJinxpHcJPssKkw2s1VyxW9nTjcIQy+1KyMUK/pzn5JtDUV5 Aa2XctHpRXzzqdivhJZDG09WjGbBkk4vI9Fe5iStkd0Z0HABOYttpBNw9iqqS9OX VGl2ZyiXSR9mUBoFFHp21FHg/5mhp//p5tTE+QE+rpCSAB0/OzMoQlDVXABKCwbb Els+QcxrniNhFX1DbiicpgBBdKFDRDRNGZpNAxLxavuwQxyNoih6+OHCqx0zXDqv OfbGMP/jZ8zphvHf5UrA89Jbj8bOJ5B5ULgLe94ogRfsPK/dmni/LFMoUDopYYbx RQKU+UQhRcMFqjYwcCE2/pKxHH43tcYBx8Ak+MuW2aImJnAOt+0lAVfbtj2oxaZK vgyfOdRZ7HbsBPLUuQ6ofenHviDxctOi2MMfSzf0LbaJnr01Q1A= =hDFf -----END PGP SIGNATURE----- --//IivP0gvsAy3Can-- --===============0775358040== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0775358040==--