From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/bridge: cdns: Mark runtime PM operations as maybe unused Date: Thu, 26 Apr 2018 17:15:03 +0200 Message-ID: <20180426151503.GG31888@ulmo> References: <20180426135853.30895-1-thierry.reding@gmail.com> <20180426142103.GD12521@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1661437444==" Return-path: Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 541946E712 for ; Thu, 26 Apr 2018 15:15:07 +0000 (UTC) Received: by mail-wm0-x22a.google.com with SMTP id t11so6756022wmt.0 for ; Thu, 26 Apr 2018 08:15:07 -0700 (PDT) In-Reply-To: <20180426142103.GD12521@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1661437444== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cgrdyab2wu3Akvjd" Content-Disposition: inline --Cgrdyab2wu3Akvjd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 26, 2018 at 04:21:04PM +0200, Daniel Vetter wrote: > On Thu, Apr 26, 2018 at 03:58:53PM +0200, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Building the driver in a configuration with !PM currently causes a > > warning about these operations being unused. Mark them as such to shut > > up the compiler. > >=20 > > Signed-off-by: Thierry Reding >=20 > I'd so love if we could use LTO (or at least link time garbage collection > of functions/heap allocations) instead of tons of #ifdef (even in macros) > and __maybe_unused. I had discussed this with Arnd Bergmann a long time ago and neither of us could figure out a way to make that work in this case, so we agreed that __maybe_unused was the preferred way forward until somebody would figure out a better way. > Patch looks fine itself. >=20 > Reviewed-by: Daniel Vetter Thanks, applied to drm-misc-next. Thierry --Cgrdyab2wu3Akvjd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlrh7PcACgkQ3SOs138+ s6Ft9w//W2+JE3YKgyBBuUZ0YFSgeCY70usPwl+XwoIzRYL5+B6qrDVyE/mesXWJ rmhdwvrdFhv/S8oy5DKvOZh4quHFwF8PsNzgCdCab7YYWyrgro4Oz7hjgGZ+Oa89 V/VWWoqMqTdc1D2YxFme2XeIiZ/IKKlMWums/o3icQ/T3Z71bKcE17/NNIb4f/iJ uQSckNyHZqBOsW3sj4MDcUgmG1ShJYqCQmPMDLr9szmU8Vq2wW/tm8G/0+4UnOB8 /F6xTduaSwaEUSpBgp+r3dSBzQRk6Xo5263muE6syDc0TEt6XcpgrkTkOrYbJJMp ZJtzIB72edqnDkRhy1NDx5LI2XtL/QFQU/9IVXCfLmqTM5bidquyVPUvXwnpIXGH 5eSbsGlk5YIjvZR5gpta5iH2JEuIEJDDir040JusG5MaP/54XzQ0J8D7VBQBHkvt KYF+utqfHa1oJbv8wxVyVZUmqkNjFWrS8A8KtrG90+Wed1VA1JlQvdXkx/PlPqaw 2/1WnG1v6M5hyVUJILF5FtBfgwTqcvu8+NrtRgKuMv0DDKES72b85i0ENcYbyWr3 4FITyYxLSm63vaf+5ZAGb0RcMEJ9BWWfHkQ03t4CmtKcEOOZtU94xAoiQ6+l/kRy u1APerxS05/duY9LNiU0eDxqCXOEHkMLy3MrS2/XAxROUIfSIaU= =M2HM -----END PGP SIGNATURE----- --Cgrdyab2wu3Akvjd-- --===============1661437444== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1661437444==--