From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: 4.17-rc2: Could not determine valid watermarks for inherited state Date: Thu, 26 Apr 2018 18:16:41 +0300 Message-ID: <20180426151641.GQ23723@intel.com> References: <20180423152713.2rrwwye3wfstbv5v@codemonkey.org.uk> <20180426131045.GH23723@intel.com> <20180426142719.fzivt2e6kialcbp4@codemonkey.org.uk> <20180426145614.GP23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9BD16E706 for ; Thu, 26 Apr 2018 15:16:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180426145614.GP23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Jones , Linux Kernel , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMDU6NTY6MTRQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgQXByIDI2LCAyMDE4IGF0IDEwOjI3OjE5QU0gLTA0MDAsIERhdmUg Sm9uZXMgd3JvdGU6Cj4gPiBbICAgIDEuMTc2MTMxXSBbZHJtOmk5eHhfZ2V0X2luaXRpYWxfcGxh bmVfY29uZmlnXSBwaXBlIEEvcHJpbWFyeSBBIHdpdGggZmI6IHNpemU9ODAweDYwMEAzMiwgb2Zm c2V0PTAsIHBpdGNoIDMyMDAsIHNpemUgMHgxZDRjMDAKPiA+IFsgICAgMS4xNzYxNjFdIFtkcm06 aTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW5fZm9yX3ByZWFsbG9jYXRlZF0gY3JlYXRpbmcg cHJlYWxsb2NhdGVkIHN0b2xlbiBvYmplY3Q6IHN0b2xlbl9vZmZzZXQ9MHgwMDAwMDAwMDAwMDAw MDAwLCBndHRfb2Zmc2V0PTB4MDAwMDAwMDAwMDAwMDAwMCwgc2l6ZT0weDAwMDAwMDAwMDAxZDUw MDAKPiA+IFsgICAgMS4xNzYzMTJdIFtkcm06aW50ZWxfYWxsb2NfaW5pdGlhbF9wbGFuZV9vYmou aXNyYS4xMjddIGluaXRpYWwgcGxhbmUgZmIgb2JqICAgICAgICAgKHB0cnZhbCkKPiA+IFsgICAg MS4xNzYzNTFdIFtkcm06aW50ZWxfbW9kZXNldF9pbml0XSBwaXBlIEEgYWN0aXZlIHBsYW5lcyAw eDEKPiA+IFsgICAgMS4xNzY0NTZdIFtkcm06ZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVf c3RhdGVdIFBsYW5lIG11c3QgY292ZXIgZW50aXJlIENSVEMKPiA+IFsgICAgMS4xNzY0ODFdIFtk cm06ZHJtX3JlY3RfZGVidWdfcHJpbnRdIGRzdDogODAweDYwMCswKzAKPiA+IFsgICAgMS4xNzY0 OTRdIFtkcm06ZHJtX3JlY3RfZGVidWdfcHJpbnRdIGNsaXA6IDEzNjZ4NzY4KzArMAo+IAo+IE9L LCBzbyB0aGF0J3MgdGhlIHByb2JsZW0gcmlnaHQgdGhlcmUuIFRoZSBmYiB3ZSB0b29rIG92ZXIg ZnJvbSB0aGUKPiBCSU9TIHdhcyA4MDB4NjAwLCBidXQgbm93IHdlJ3JlIHRyeWluZyB0byBzZXQg dXAgYSAxMzY2eDc2OCBtb2RlLgo+IAo+IFdlIHNlZW0gdG8gYmUgbWlzc2luZyBjaGVja3MgdG8g bWFrZSBzdXJlIHRoZSBpbml0aWFsIGZiIGlzIGFjdHVhbGx5Cj4gYmlnIGVub3VnaCBmb3IgdGhl IG1vZGUgd2UncmUgY3VycmVudGx5IHVzaW5nIDooCgpBY3R1YWxseSB3ZSBkbyByZWFkIG91dCB0 aGUgcGlwZSBzcmMgc2l6ZSBhcyA4MDB4NjAwIGluaXRpYWxseSwgd2hpY2gKbWFrZSBzZW5zZS4g QW5kIHdlIGV2ZW4gc3R1ZmYgdGhhdCBpbnRvIHRoZSBtb2RlLmgvdmRpc3BsYXksIHNvIHVwIHRv CnRoYXQgcG9pbnQgZXZlcnl0aGluZyBpcyBwcmV0dHkgbXVjaCBjb3JyZWN0LiBJdCBnb2VzIHdy b25nIGlzIHdoZW4KaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKCkgY2FsbHMgaW50ZWxf bW9kZV9mcm9tX3BpcGVfY29uZmlnKCkKYXMgdGhhdCB3aWxsIG92ZXJyaWRlIHRoZSBoL3ZkaXNw bGF5IHdpdGggdGhlIGFjdHVhbCBjcnRjIHRpbWluZ3MKaW5zdGVhZCBvZiB0aGUgcGlwZSBzcmMg c2l6ZS4KClNvIEkgc3VwcG9zZSB3ZSBzaG91bGQgYmUgYWJsZSB0byBqdXN0IGFkZCB0aGUgc2Fu aXR5IGNoZWNrcyBmb3IgdGhlCmZiIHZzLiBoL3ZkaXNwbGF5LCBhbmQgYXQgbGVhc3Qgd2Ugc2hv dWxkIGdldCBwYXN0IHRoaXMgZXJyb3IuIEEKc2xpZ2h0bHkgYmlnZ2VyIG15c3RlcnkgaXMgd2hh dCB3aWxsIGhhcHBlbiBsYXRlciB3aGVuIG91ciBwaXBlIHNyYwpzaXplIGRvZXNuJ3QgYWN0dWFs bHkgYWdyZWUgd2l0aCB0aGUgaC92ZGlzcGxheS4gVGhlIGZpcnN0IG1vZGVzZXQKd2lsbCBjb3Jy ZWN0IGl0LCBidXQgd2UgbWlnaHQgd2FudCBzb21lIGtpbmQgb2YgZXh0cmEgc2FuaXRpemUgc3Rl cApmb3IgZmFzdGJvb3QgdHlwZSBvZiBzdHVmZi4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756615AbeDZPQt (ORCPT ); Thu, 26 Apr 2018 11:16:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:2001 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756204AbeDZPQq (ORCPT ); Thu, 26 Apr 2018 11:16:46 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="34848870" Date: Thu, 26 Apr 2018 18:16:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Dave Jones , Linux Kernel , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] 4.17-rc2: Could not determine valid watermarks for inherited state Message-ID: <20180426151641.GQ23723@intel.com> References: <20180423152713.2rrwwye3wfstbv5v@codemonkey.org.uk> <20180426131045.GH23723@intel.com> <20180426142719.fzivt2e6kialcbp4@codemonkey.org.uk> <20180426145614.GP23723@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180426145614.GP23723@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 05:56:14PM +0300, Ville Syrjälä wrote: > On Thu, Apr 26, 2018 at 10:27:19AM -0400, Dave Jones wrote: > > [ 1.176131] [drm:i9xx_get_initial_plane_config] pipe A/primary A with fb: size=800x600@32, offset=0, pitch 3200, size 0x1d4c00 > > [ 1.176161] [drm:i915_gem_object_create_stolen_for_preallocated] creating preallocated stolen object: stolen_offset=0x0000000000000000, gtt_offset=0x0000000000000000, size=0x00000000001d5000 > > [ 1.176312] [drm:intel_alloc_initial_plane_obj.isra.127] initial plane fb obj (ptrval) > > [ 1.176351] [drm:intel_modeset_init] pipe A active planes 0x1 > > [ 1.176456] [drm:drm_atomic_helper_check_plane_state] Plane must cover entire CRTC > > [ 1.176481] [drm:drm_rect_debug_print] dst: 800x600+0+0 > > [ 1.176494] [drm:drm_rect_debug_print] clip: 1366x768+0+0 > > OK, so that's the problem right there. The fb we took over from the > BIOS was 800x600, but now we're trying to set up a 1366x768 mode. > > We seem to be missing checks to make sure the initial fb is actually > big enough for the mode we're currently using :( Actually we do read out the pipe src size as 800x600 initially, which make sense. And we even stuff that into the mode.h/vdisplay, so up to that point everything is pretty much correct. It goes wrong is when intel_modeset_readout_hw_state() calls intel_mode_from_pipe_config() as that will override the h/vdisplay with the actual crtc timings instead of the pipe src size. So I suppose we should be able to just add the sanity checks for the fb vs. h/vdisplay, and at least we should get past this error. A slightly bigger mystery is what will happen later when our pipe src size doesn't actually agree with the h/vdisplay. The first modeset will correct it, but we might want some kind of extra sanitize step for fastboot type of stuff. -- Ville Syrjälä Intel